Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
Hello Andrew, Andrew Pinski writes: > On Mon, Feb 5, 2024 at 10:40 AM Thiago Jung Bauermann > wrote: >> >> >> Thiago Jung Bauermann writes: >> >> > Hello Luis, >> > >> > Luis Machado writes: >> >> >> >> Approved-By: Luis Machado >> > >> > Thanks! Since this is a patch for the repository top-level, is your >> > approval sufficient to commit the patch, or should I have approval from >> > a binutils maintainer as well? >> >> Answering my own question: binutils/MAINTAINERS says: >> >> GDB global maintainers also have permission to commit and approve >> patches to the top level files and to those parts of bfd files >> primarily used by GDB. >> >> So pushed as commit 9c0aa4c53104. > > Please also submit/commit to the gcc trunk too since the toplevel > configure should be insync between the 2 repos. I don't have commit access to the gcc repo so I sent a patch to the gcc-patches mailing list. -- Thiago
[PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by
default") fixed a mismatch between 64-bit time_t in GDB and system headers
and 32-bit time_t in BFD.
However, since commit 862776f26a59 ("Finalized intl-update patches")
gnulib's year 2038 support has been accidentally re-enabled — causing
problems for 32-bit hosts again. The commit split baseargs into
{h,b}baseargs, but this hasn't been done for the code that handles
--disable-year2038.
This patch restores the intended behaviour. With this change, the number
of unexpected core files goes from 18 to 4.
Tested on armv8l-linux-gnueabihf.
Approved-By: Luis Machado
---
Hello,
Yesterday I committed this patch to the binutils-gdb repo. Since the
toplevel configure should be in sync between the 2 repos, could someone
please commit it to the gcc one? I don't have commit access.
configure| 3 ++-
configure.ac | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 874966fb9f09..1da0e67c28fa 100755
--- a/configure
+++ b/configure
@@ -10301,7 +10301,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
diff --git a/configure.ac b/configure.ac
index 4f34004a0726..fa508a0612a3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3420,7 +3420,8 @@ hbaseargs="$hbaseargs --disable-option-checking"
tbaseargs="$tbaseargs --disable-option-checking"
if test "$enable_year2038" = no; then
- baseargs="$baseargs --disable-year2038"
+ bbaseargs="$bbaseargs --disable-year2038"
+ hbaseargs="$hbaseargs --disable-year2038"
tbaseargs="$tbaseargs --disable-year2038"
fi
Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default
On Mon, Feb 5, 2024 at 10:40 AM Thiago Jung Bauermann wrote: > > > Thiago Jung Bauermann writes: > > > Hello Luis, > > > > Luis Machado writes: > >> > >> Approved-By: Luis Machado > > > > Thanks! Since this is a patch for the repository top-level, is your > > approval sufficient to commit the patch, or should I have approval from > > a binutils maintainer as well? > > Answering my own question: binutils/MAINTAINERS says: > > GDB global maintainers also have permission to commit and approve > patches to the top level files and to those parts of bfd files > primarily used by GDB. > > So pushed as commit 9c0aa4c53104. Please also submit/commit to the gcc trunk too since the toplevel configure should be insync between the 2 repos. Thanks, Andrew > > -- > Thiago
