Re: [PATCH] Fix target selector in builtin-apply-2.c

[Jeff Law]

On 02/06/2017 07:37 PM, Segher Boessenkool wrote:

Revision r245228 introduced a syntax error in a target selector in
builtin-apply-2.c: || wants a single expression on each side, you
cannot have "{a} || {b} || {c}", instead you need to write this as
"{a} || {{b} || {c}}".  In this testcase b and c are real target
selectors (not effect target keywords) however, so we can just write
"{a} || {b c}".  This also removes the unnecessary default arguments.

Tested on powerpc64-linux {-m32,-m64}; is this okay for trunk?


Segher


2017-02-07  Segher Boessenkool  

gcc/testsuite/
* gcc.dg/torture/stackalign/builtin-apply-2.c: Fix syntax error in
target selector.  Delete superfluous default arguments.

OK.  Jeff

Re: [PATCH] Fix target selector in builtin-apply-2.c

[Mike Stump]

On Feb 6, 2017, at 6:37 PM, Segher Boessenkool  
wrote:
> 
> Revision r245228 introduced a syntax error in a target selector in
> builtin-apply-2.c: || wants a single expression on each side, you
> cannot have "{a} || {b} || {c}", instead you need to write this as
> "{a} || {{b} || {c}}".  In this testcase b and c are real target
> selectors (not effect target keywords) however, so we can just write
> "{a} || {b c}".  This also removes the unnecessary default arguments.
> 
> Tested on powerpc64-linux {-m32,-m64}; is this okay for trunk?

Ok.

[PATCH] Fix target selector in builtin-apply-2.c

[Segher Boessenkool]

Revision r245228 introduced a syntax error in a target selector in
builtin-apply-2.c: || wants a single expression on each side, you
cannot have "{a} || {b} || {c}", instead you need to write this as
"{a} || {{b} || {c}}".  In this testcase b and c are real target
selectors (not effect target keywords) however, so we can just write
"{a} || {b c}".  This also removes the unnecessary default arguments.

Tested on powerpc64-linux {-m32,-m64}; is this okay for trunk?


Segher


2017-02-07  Segher Boessenkool  

gcc/testsuite/
* gcc.dg/torture/stackalign/builtin-apply-2.c: Fix syntax error in
target selector.  Delete superfluous default arguments.

---
 gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c 
b/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
index eb9d3a9..d033010 100644
--- a/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
+++ b/gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
@@ -9,8 +9,8 @@
 /* arm_hf_eabi: Variadic funcs use Base AAPCS.  Normal funcs use VFP variant.
avr: Variadic funcs don't pass arguments in registers, while normal funcs
 do.  */
-/* { dg-skip-if "Variadic funcs use different argument passing from normal 
funcs" { arm_hf_eabi || { avr-*-* } || { riscv*-*-* } } "*" "" } */
-/* { dg-skip-if "Variadic funcs have all args on stack. Normal funcs have args 
in registers." { nds32*-*-* } "*" "" } */
+/* { dg-skip-if "Variadic funcs use different argument passing from normal 
funcs" { arm_hf_eabi || { avr-*-* riscv*-*-* } } } */
+/* { dg-skip-if "Variadic funcs have all args on stack. Normal funcs have args 
in registers." { nds32*-*-* } } */
 /* { dg-require-effective-target untyped_assembly } */

 
-- 
1.9.3