Re: [PATCH] Fix two missed Makefile.in dependencies

2014-02-06 Thread Richard Biener
On Thu, Feb 6, 2014 at 8:12 AM, Jakub Jelinek ja...@redhat.com wrote:
 Hi!

 I have noticed that with the .deps introduction for gcc/ we've lost
 these two dependencies, which autodependency creation isn't aware of,
 as the Makefile runs cat on those files and passes the content through
 -D option.

 Ok for trunk?

Ok.

Richard.

 2014-02-06  Jakub Jelinek  ja...@redhat.com

 * Makefile.in (prefix.o, cppbuiltin.o): Depend on $(BASEVER).

 --- gcc/Makefile.in.jj  2014-01-28 14:03:49.0 +0100
 +++ gcc/Makefile.in 2014-02-05 13:09:26.871019299 +0100
 @@ -1925,6 +1925,7 @@ default-c.o: config/default-c.c
  # Files used by all variants of C and some other languages.

  CFLAGS-prefix.o += -DPREFIX=\$(prefix)\ -DBASEVER=$(BASEVER_s)
 +prefix.o: $(BASEVER)

  # Language-independent files.

 @@ -2540,6 +2541,7 @@ PREPROCESSOR_DEFINES = \
@TARGET_SYSTEM_ROOT_DEFINE@

  CFLAGS-cppbuiltin.o += $(PREPROCESSOR_DEFINES) -DBASEVER=$(BASEVER_s)
 +cppbuiltin.o: $(BASEVER)

  CFLAGS-cppdefault.o += $(PREPROCESSOR_DEFINES)


 Jakub


[PATCH] Fix two missed Makefile.in dependencies

2014-02-05 Thread Jakub Jelinek
Hi!

I have noticed that with the .deps introduction for gcc/ we've lost
these two dependencies, which autodependency creation isn't aware of,
as the Makefile runs cat on those files and passes the content through
-D option.

Ok for trunk?

2014-02-06  Jakub Jelinek  ja...@redhat.com

* Makefile.in (prefix.o, cppbuiltin.o): Depend on $(BASEVER).

--- gcc/Makefile.in.jj  2014-01-28 14:03:49.0 +0100
+++ gcc/Makefile.in 2014-02-05 13:09:26.871019299 +0100
@@ -1925,6 +1925,7 @@ default-c.o: config/default-c.c
 # Files used by all variants of C and some other languages.
 
 CFLAGS-prefix.o += -DPREFIX=\$(prefix)\ -DBASEVER=$(BASEVER_s)
+prefix.o: $(BASEVER)
 
 # Language-independent files.
 
@@ -2540,6 +2541,7 @@ PREPROCESSOR_DEFINES = \
   @TARGET_SYSTEM_ROOT_DEFINE@
 
 CFLAGS-cppbuiltin.o += $(PREPROCESSOR_DEFINES) -DBASEVER=$(BASEVER_s)
+cppbuiltin.o: $(BASEVER)
 
 CFLAGS-cppdefault.o += $(PREPROCESSOR_DEFINES)
 

Jakub