Re: [PATCH] Fix whitespace in comments.

2014-09-22 Thread Jeff Law

On 09/20/14 08:48, Tobias Burnus wrote:

Hi Joost and Thomas,

On 20.09.2014 12:02, Thomas Koenig wrote:

A somewhat trivial patch to cleanup whitespace issues in comments:
sed "s/\. \*\//\.  \*\//g"
Tested with a recompile only. Ok for trunk ?

OK.  (Obvious, really).


I want to point a downside of massive code changes: It makes it more
difficult to find out with "git/svn blame" when or why a line of code
was changed.

That's not so much a problem of comment changes like this one – and I am
fine with that change. :-)

However, I wanted to point out that seemingly trivial and obviously
correct patches can have a downside. (One can still do such changes, but
at least one should have weighted them against the downside.)

Yup.

I still want a commit hook which cleans this kind of stuff up so that we 
can be done with worry about this kind of stuff.


jeff


RE: [PATCH] Fix whitespace in comments.

2014-09-20 Thread VandeVondele Joost
Hi Tobias,

> However, I wanted to point out that seemingly trivial and obviously
> correct patches can have a downside. (One can still do such changes, but
> at least one should have weighted them against the downside.)

I agree, that's why I asked explicitly.

Joost

Re: [PATCH] Fix whitespace in comments.

2014-09-20 Thread Tobias Burnus

Hi Joost and Thomas,

On 20.09.2014 12:02, Thomas Koenig wrote:

A somewhat trivial patch to cleanup whitespace issues in comments: sed "s/\. \*\//\. 
 \*\//g"
Tested with a recompile only. Ok for trunk ?

OK.  (Obvious, really).


I want to point a downside of massive code changes: It makes it more 
difficult to find out with "git/svn blame" when or why a line of code 
was changed.


That's not so much a problem of comment changes like this one – and I am 
fine with that change. :-)


However, I wanted to point out that seemingly trivial and obviously 
correct patches can have a downside. (One can still do such changes, but 
at least one should have weighted them against the downside.)


Tobias


Re: [PATCH] Fix whitespace in comments.

2014-09-20 Thread Thomas Koenig
Hi Joost,

> A somewhat trivial patch to cleanup whitespace issues in comments: sed "s/\. 
> \*\//\.  \*\//g"
> 
> Tested with a recompile only.
> 
> Ok for trunk ?

OK.  (Obvious, really).

Thomas



[PATCH] Fix whitespace in comments.

2014-09-20 Thread VandeVondele Joost
A somewhat trivial patch to cleanup whitespace issues in comments: sed "s/\. 
\*\//\.  \*\//g"

Tested with a recompile only.

Ok for trunk ?





gcc/fortran/ChangeLog:

2014-09-20  Joost VandeVondele  

* trans-expr.c (gfc_reset_vptr): Fix comment whitespace.
(gfc_conv_class_to_class): Likewise.
(gfc_conv_procedure_call): Likewise.
(arrayfunc_assign_needs_temporary): Likewise.
(realloc_lhs_loop_for_fcn_call): Likewise.
(gfc_trans_assignment_1): Likewise.
* trans-array.c (gfc_conv_array_ref): Likewise.
(gfc_array_allocate): Likewise.
(gfc_alloc_allocatable_for_assignment): Likewise.
* symbol.c (generate_isocbinding_symbol): Likewise.
* class.c (finalization_scalarizer): Likewise.
(finalizer_insert_packed_call): Likewise.
(generate_finalization_wrapper): Likewise.
(find_intrinsic_vtab): Likewise.
* decl.c (gfc_match_import): Likewise.
(match_procedure_decl): Likewise.
(gfc_match_subroutine): Likewise.
(gfc_match_bind_c): Likewise.
(gfc_match_volatile): Likewise.
* trans-common.c (create_common): Likewise.
* error.c (gfc_diagnostic_starter): Likewise.
* trans-stmt.c (gfc_trans_sync): Likewise.
(gfc_trans_critical): Likewise.
(gfc_trans_simple_do): Likewise.
(gfc_trans_do): Likewise.
(gfc_trans_where_assign): Likewise.
* expr.c (gfc_is_simply_contiguous): Likewise.
* module.c (unquote_string): Likewise.
* trans.c (gfc_add_finalizer_call): Likewise.
* trans-types.c (gfc_init_kinds): Likewise.
* scanner.c (preprocessor_line): Likewise.
* gfortranspec.c (lang_specific_driver): Likewise.
* frontend-passes.c (create_var): Likewise.
(cfe_expr_0): Likewise.
* resolve.c (check_host_association): Likewise.
(gfc_resolve_code): Likewise.
(resolve_fl_derived0): Likewise.
(resolve_symbol): Likewise.
* f95-lang.c (poplevel): Likewise.
* trans-decl.c (create_main_function): Likewise.
* trans-io.c (transfer_expr): Likewise.
* arith.c (gfc_arith_divide): Likewise.
* parse.c (resolve_all_program_units): Likewise.
* check.c (gfc_check_rank): Likewise.
(gfc_check_sizeof): Likewise.
(is_c_interoperable): Likewise.
* dependency.c (gfc_dep_difference): Likewise.
* primary.c (gfc_match_rvalue): Likewise.
* trans-intrinsic.c (conv_intrinsic_system_clock): Likewise.
(conv_isocbinding_subroutine): Likewise.
* options.c (gfc_post_options): Likewise.
(gfc_handle_fpe_option): Likewise.
(gfc_get_option_string): Likewise.
* simplify.c (simplify_transformation_to_scalar): Likewise.
(gfc_simplify_spread): Likewise.


Index: gcc/fortran/trans-expr.c
===
--- gcc/fortran/trans-expr.c	(revision 215323)
+++ gcc/fortran/trans-expr.c	(working copy)
@@ -231,7 +231,7 @@ gfc_reset_vptr (stmtblock_t *block, gfc_
   gfc_ref *ref;
 
   /* If we have a class array, we need go back to the class
- container. */
+ container.  */
   if (lhs->ref && lhs->ref->next && !lhs->ref->next->next
   && lhs->ref->next->type == REF_ARRAY
   && lhs->ref->next->u.ar.type == AR_FULL
@@ -729,7 +729,7 @@ gfc_conv_class_to_class (gfc_se *parmse,
   ctree = gfc_class_vptr_get (var);
 
   /* The vptr is the second field of the actual argument.
- First we have to find the corresponding class reference. */
+ First we have to find the corresponding class reference.  */
 
   tmp = NULL_TREE;
   if (class_ref == NULL
@@ -4953,7 +4953,7 @@ gfc_conv_procedure_call (gfc_se * se, gf
 		  && CLASS_DATA (fsym)->attr.codimension
 		  && !CLASS_DATA (fsym)->attr.allocatable)))
 	{
-	  /* Token and offset. */
+	  /* Token and offset.  */
 	  vec_safe_push (stringargs, null_pointer_node);
 	  vec_safe_push (stringargs, build_int_cst (gfc_array_index_type, 0));
 	  gcc_assert (fsym->attr.optional);
@@ -7391,7 +7391,7 @@ arrayfunc_assign_needs_temporary (gfc_ex
 {
   /* A temporary is not needed if the function is not contained and
 	 the variable is local or host associated and not a pointer or
-	 a target. */
+	 a target.  */
   if (!expr2->value.function.esym->attr.contained)
 	return false;
 
@@ -7420,7 +7420,7 @@ realloc_lhs_loop_for_fcn_call (gfc_se *s
 			   gfc_loopinfo *loop)
 {
   /* Signal that the function call should not be made by
- gfc_conv_loop_setup. */
+ gfc_conv_loop_setup.  */
   se->ss->is_alloc_lhs = 1;
   gfc_init_loopinfo (loop);
   gfc_add_ss_to_loop (loop, *ss);
@@ -8252,7 +8252,7 @@ gfc_trans_assignment_1 (gfc_expr * expr1
  the function call must happen before the (re)allocation of the lhs -
  otherwise the character length of the result is not known.
  NOTE: This relies on having the exact dependence of the lengt