Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392
Hi Mark, ping Looks good. Thanks!
Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392
ping On 19/05/2020 08:49, Mark Eggleston wrote: Please find attached patch for PR50392. This patch was extracted from the comments in the PR and was written back in 2011! I have verified that it fixes the PR on master, gcc-8, gcc-9 and gcc-10. Commit message: Fortran : ICE in gfc_trans_label_assign PR50392 A function may contain an assigned goto. If the the return variable is an integer a statement can be assigned to it. Prior to this fix this resulted in an ICE. 2020-05-19 Tobias Burnus gcc/fortran/ * trans-decl.c (gfc_get_symbol_decl): Remove unnecessary block delimiters. Add auxiliary variables if a label is assigned to a return variable. (gfc_gat_fake_result): ??? 2020-05-19 Mark Eggleston gcc/testsuite/ * gfortran.dg/pr50392.f: New test. As can be seen there is a sequence of question marks in the description of the changes made. I don't know how to describe the inserted code, Tobias Burnus: you may be able to help as it is your code. Tested on x86_64 using make check-fortran for master, gcc-8, ggc-9 and gcc-10. Once the addition to the description to the code changes is complete will it be OK to commit to master and backport to gcc-8, 9 and 10. -- https://www.codethink.co.uk/privacy.html
Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392
Messed up the e-mail addressed, gcc-patches now added. Also, I note that I missed the PR fortran/50392 which should be inserted at the start of the change log entries. On 19/05/2020 08:49, Mark Eggleston wrote: Please find attached patch for PR50392. This patch was extracted from the comments in the PR and was written back in 2011! I have verified that it fixes the PR on master, gcc-8, gcc-9 and gcc-10. Commit message: Fortran : ICE in gfc_trans_label_assign PR50392 A function may contain an assigned goto. If the the return variable is an integer a statement can be assigned to it. Prior to this fix this resulted in an ICE. 2020-05-19 Tobias Burnus gcc/fortran/ * trans-decl.c (gfc_get_symbol_decl): Remove unnecessary block delimiters. Add auxiliary variables if a label is assigned to a return variable. (gfc_gat_fake_result): ??? 2020-05-19 Mark Eggleston gcc/testsuite/ * gfortran.dg/pr50392.f: New test. As can be seen there is a sequence of question marks in the description of the changes made. I don't know how to describe the inserted code, Tobias Burnus: you may be able to help as it is your code. Tested on x86_64 using make check-fortran for master, gcc-8, ggc-9 and gcc-10. Once the addition to the description to the code changes is complete will it be OK to commit to master and backport to gcc-8, 9 and 10. -- https://www.codethink.co.uk/privacy.html
