RE: [PATCH] RISC-V: Update RVV integer compare simplification comments

2023-05-10 Thread Li, Pan2 via Gcc-patches
Hi Jeff,

Thanks a lot. If no more comments, I can commit it to trunk later, 😊.

Pan

-Original Message-
From: Jeff Law  
Sent: Tuesday, May 9, 2023 6:06 AM
To: Li, Pan2 ; gcc-patches@gcc.gnu.org
Cc: juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang 

Subject: Re: [PATCH] RISC-V: Update RVV integer compare simplification comments



On 5/8/23 02:54, Pan Li via Gcc-patches wrote:
> From: Pan Li 
> 
> The VMSET simplification RVV integer comparision has merged already.
> This patch would like to update the comments for the cases that the 
> define_split will act on.
> 
> Signed-off-by: Pan Li 
> 
> gcc/ChangeLog:
> 
>   * config/riscv/vector.md: Add comments for simplifying to vmset.
OK.  Thanks.
jeff


Re: [PATCH] RISC-V: Update RVV integer compare simplification comments

2023-05-08 Thread Jeff Law via Gcc-patches




On 5/8/23 02:54, Pan Li via Gcc-patches wrote:

From: Pan Li 

The VMSET simplification RVV integer comparision has merged already.
This patch would like to update the comments for the cases that the
define_split will act on.

Signed-off-by: Pan Li 

gcc/ChangeLog:

* config/riscv/vector.md: Add comments for simplifying to vmset.

OK.  Thanks.
jeff


[PATCH] RISC-V: Update RVV integer compare simplification comments

2023-05-08 Thread Pan Li via Gcc-patches
From: Pan Li 

The VMSET simplification RVV integer comparision has merged already.
This patch would like to update the comments for the cases that the
define_split will act on.

Signed-off-by: Pan Li 

gcc/ChangeLog:

* config/riscv/vector.md: Add comments for simplifying to vmset.

Signed-off-by: Pan Li 
---
 gcc/config/riscv/vector.md | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md
index 9ccc0d6a513..9904d4ca5e2 100644
--- a/gcc/config/riscv/vector.md
+++ b/gcc/config/riscv/vector.md
@@ -8159,13 +8159,20 @@ (define_insn 
"@pred_indexed_store"
 ;; 
-
 ;;  Integer Compare Instructions Simplification
 ;; 
-
-;; Simplify to VMCLR.m Includes:
+;; Simplify OP(V, V) Instructions to VMCLR.m Includes:
 ;; - 1.  VMSNE
 ;; - 2.  VMSLT
 ;; - 3.  VMSLTU
 ;; - 4.  VMSGT
 ;; - 5.  VMSGTU
 ;; 
-
+;; Simplify OP(V, V) Instructions to VMSET.m Includes:
+;; - 1.  VMSEQ
+;; - 2.  VMSLE
+;; - 3.  VMSLEU
+;; - 4.  VMSGE
+;; - 5.  VMSGEU
+;; 
-
 (define_split
   [(set (match_operand:VB  0 "register_operand")
(if_then_else:VB
-- 
2.34.1