Re: [PATCH] Remove non needed check in bmp_iter_set_init (PR tree-optimization/82669).

2017-11-08 Thread Jeff Law
On 11/08/2017 12:13 AM, Martin Liška wrote:
> Hello.
> 
> Assert removal is logical as it's used in iteration and if sbitmap is empty, 
> iteration
> macro will not touch any element of a bitmap.
> 
> Ready after it survives regression tests?
> 
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
> 2017-11-08  Martin Liska  
> 
>   PR tree-optimization/82669
>   * sbitmap.h (bmp_iter_set_init): Remove non needed check.
OK.
jeff


[PATCH] Remove non needed check in bmp_iter_set_init (PR tree-optimization/82669).

2017-11-07 Thread Martin Liška
Hello.

Assert removal is logical as it's used in iteration and if sbitmap is empty, 
iteration
macro will not touch any element of a bitmap.

Ready after it survives regression tests?

Thanks,
Martin

gcc/ChangeLog:

2017-11-08  Martin Liska  

PR tree-optimization/82669
* sbitmap.h (bmp_iter_set_init): Remove non needed check.
---
 gcc/sbitmap.h | 2 --
 1 file changed, 2 deletions(-)


diff --git a/gcc/sbitmap.h b/gcc/sbitmap.h
index a5ff0685e43..3c58bf01fdc 100644
--- a/gcc/sbitmap.h
+++ b/gcc/sbitmap.h
@@ -171,8 +171,6 @@ static inline void
 bmp_iter_set_init (sbitmap_iterator *i, const_sbitmap bmp,
 		   unsigned int min, unsigned *bit_no ATTRIBUTE_UNUSED)
 {
-  bitmap_check_index (bmp, min);
-
   i->word_num = min / (unsigned int) SBITMAP_ELT_BITS;
   i->bit_num = min;
   i->size = bmp->size;