Re: [PATCH] Testsuite, i386: Fix test by passing -march

[FX Coudert]

> Well It can fail on x86_64-linux-gnu too if GCC was configured with
> --with-arch=core2 for an example.
> So having it, in this case, not being darwin specific would be
> beneficial for all x86_64/i?86 targets.

I pushed it as-is, meaning it will indeed apply to all x86_64/i?86 targets.

FX

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Andrew Pinski]

On Mon, Oct 30, 2023 at 5:05 AM Iain Sandoe  wrote:
>
>
>
> > On 30 Oct 2023, at 11:53, FX Coudert  wrote:
>
> > The newly introduced test gcc.target/i386/pr111698.c currently fails on 
> > Darwin, where the default arch is core2.
> > Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to 
> > pass a recent value to -march, and I can confirm that it fixes the 
> > testsuite failure on x86_64-apple-darwin21.
> >
> > OK to push?
>
> Fine from a Darwin perspective,
> we could also make it ...
> dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
> … if that is deemed less invasive.

Well It can fail on x86_64-linux-gnu too if GCC was configured with
--with-arch=core2 for an example.
So having it, in this case, not being darwin specific would be
beneficial for all x86_64/i?86 targets.

Thanks,
Andrew

>
> Iain
>
>

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Iain Sandoe]

> On 30 Oct 2023, at 11:53, FX Coudert  wrote:

> The newly introduced test gcc.target/i386/pr111698.c currently fails on 
> Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to 
> pass a recent value to -march, and I can confirm that it fixes the testsuite 
> failure on x86_64-apple-darwin21.
> 
> OK to push?

Fine from a Darwin perspective, 
we could also make it ...
dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
… if that is deemed less invasive.

Iain

Re: [PATCH] Testsuite, i386: Fix test by passing -march

[Uros Bizjak]

On Mon, Oct 30, 2023 at 12:53 PM FX Coudert  wrote:
>
> Hi,
>
> The newly introduced test gcc.target/i386/pr111698.c currently fails on 
> Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to 
> pass a recent value to -march, and I can confirm that it fixes the testsuite 
> failure on x86_64-apple-darwin21.
>
> OK to push?

OK.

Thanks,
Uros.

[PATCH] Testsuite, i386: Fix test by passing -march

[FX Coudert]

Hi,

The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, 
where the default arch is core2.
Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass 
a recent value to -march, and I can confirm that it fixes the testsuite failure 
on x86_64-apple-darwin21.

OK to push?

FX



0001-Testsuite-i386-Fix-test-by-passing-march.patch
Description: Binary data