Re: [PATCH] Unify emit_{pre,post}_atomic_barrier across Alpha, ARM, MIPS and TileGX

2012-06-19 Thread Maxim Kuvyrkov 
On 15/06/2012, at 11:16 AM, Richard Henderson wrote:

 On 2012-06-14 16:06, Maxim Kuvyrkov wrote:
 2012-06-15  Maxim Kuvyrkov  ma...@codesourcery.com
 
  * emit-rtl.c (need_atomic_barrier_p): New function.
  * emit-rtl.h (need_atomic_barrier_p): Declare it.
  * config/alpha/alpha.c (alpha_{pre,post}_atomic_barrier): Remove, use
  generic version instead.
  * config/arm/arm.c (arm_{pre,post}_atomic_barrier): Remove, use
  generic version instead.
  * config/mips/mips.c (mips_{pre,post}_atomic_barrier_p): Remove, use
  generic version instead.
  * config/tilegx/tilegx.c, config/tilegx/tilegx-protos.h,
  * config/tilegx/sync.md (tilegx_{pre,post}_atomic_barrier): Remove, use
  generic version instead.
 
 
 Ok.

Since I didn't hear any objections from target maintainers I've checked in this 
patch.

Thank you,

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics

[PATCH] Unify emit_{pre,post}_atomic_barrier across Alpha, ARM, MIPS and TileGX

2012-06-14 Thread Maxim Kuvyrkov 
As suggested by Hans-Peter this patch unifies logic for emitting pre- and 
post-barriers for atomic operations across Alpha, ARM, MIPS and TileGX.  
Currently these targets use copy-pasted switch statements and this patch cleans 
that up.

I'm going to test this patch on MIPS, and I would appreciate target maintainers 
to cast a close look at the changes for their targets.  The changes are simple, 
but you can never eliminate typo mistakes.

Thank you,

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics




0001-Unify-emit_-pre-post-_atomic_barrier-across-Alpha-AR.patch
Description: Binary data

Re: [PATCH] Unify emit_{pre,post}_atomic_barrier across Alpha, ARM, MIPS and TileGX

2012-06-14 Thread Richard Henderson 
On 2012-06-14 16:06, Maxim Kuvyrkov wrote:
 2012-06-15  Maxim Kuvyrkov  ma...@codesourcery.com
 
   * emit-rtl.c (need_atomic_barrier_p): New function.
   * emit-rtl.h (need_atomic_barrier_p): Declare it.
   * config/alpha/alpha.c (alpha_{pre,post}_atomic_barrier): Remove, use
   generic version instead.
   * config/arm/arm.c (arm_{pre,post}_atomic_barrier): Remove, use
   generic version instead.
   * config/mips/mips.c (mips_{pre,post}_atomic_barrier_p): Remove, use
   generic version instead.
   * config/tilegx/tilegx.c, config/tilegx/tilegx-protos.h,
   * config/tilegx/sync.md (tilegx_{pre,post}_atomic_barrier): Remove, use
   generic version instead.


Ok.


r~