Re: [PATCH] Use cgraph_node::dump_{asm_},name where possible.
On 1/9/20 2:25 AM, luoxhu wrote:
On 2020/1/8 22:54, Martin Liška wrote:
diff --git a/gcc/cgraphclones.c b/gcc/cgraphclones.c
index bd44063a1ac..789564ba335 100644
--- a/gcc/cgraphclones.c
+++ b/gcc/cgraphclones.c
@@ -1148,8 +1148,7 @@ symbol_table::materialize_all_clones (void)
if (symtab->dump_file)
{
fprintf (symtab->dump_file, "cloning %s to %s\n",
- xstrdup_for_dump (node->clone_of->name ()),
- xstrdup_for_dump (node->name ()));
+ node->clone_of->dump_name (), node->name ());
Also node->dump_name () here?
Yep, thank you for the note.
I'm going to install the obvious patch.
Martin
>From 16ba88890581aa4398789b8670eb39792c8b107f Mon Sep 17 00:00:00 2001
From: Martin Liska
Date: Thu, 9 Jan 2020 09:21:37 +0100
Subject: [PATCH] One more usage of cgraph_node::dump_name.
gcc/ChangeLog:
2020-01-09 Martin Liska
* cgraphclones.c (symbol_table::materialize_all_clones):
Use cgraph_node::dump_name.
---
gcc/cgraphclones.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/cgraphclones.c b/gcc/cgraphclones.c
index 789564ba335..9b1cc3e3930 100644
--- a/gcc/cgraphclones.c
+++ b/gcc/cgraphclones.c
@@ -1148,7 +1148,8 @@ symbol_table::materialize_all_clones (void)
if (symtab->dump_file)
{
fprintf (symtab->dump_file, "cloning %s to %s\n",
- node->clone_of->dump_name (), node->name ());
+ node->clone_of->dump_name (),
+ node->dump_name ());
if (node->clone.tree_map)
{
unsigned int i;
--
2.24.1
Re: [PATCH] Use cgraph_node::dump_{asm_},name where possible.
On 2020/1/8 22:54, Martin Liška wrote:
diff --git a/gcc/cgraphclones.c b/gcc/cgraphclones.c
index bd44063a1ac..789564ba335 100644
--- a/gcc/cgraphclones.c
+++ b/gcc/cgraphclones.c
@@ -1148,8 +1148,7 @@ symbol_table::materialize_all_clones (void)
if (symtab->dump_file)
{
fprintf (symtab->dump_file, "cloning %s to %s\n",
- xstrdup_for_dump (node->clone_of->name ()),
- xstrdup_for_dump (node->name ()));
+ node->clone_of->dump_name (), node->name ());
Also node->dump_name () here?
Re: [PATCH] Use cgraph_node::dump_{asm_},name where possible.
> Hi.
>
> The patch consistent usage of cgraph_node::dump_{asm_,}name where possible.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
OK, thanks!
Not all dump_name/dump_asm_name choices are fully logical, but I see it
is comming form name/asm_name use. I suppose we could fix that case by
case eventually.
Honza
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2020-01-08 Martin Liska
>
> * cgraph.c (cgraph_node::dump): Use ::dump_name or
> ::dump_asm_name instead of (::name or ::asm_name).
> * cgraphclones.c (symbol_table::materialize_all_clones): Likewise.
> * cgraphunit.c (walk_polymorphic_call_targets): Likewise.
> (analyze_functions): Likewise.
> (expand_all_functions): Likewise.
> * ipa-cp.c (ipcp_cloning_candidate_p): Likewise.
> (propagate_bits_across_jump_function): Likewise.
> (dump_profile_updates): Likewise.
> (ipcp_store_bits_results): Likewise.
> (ipcp_store_vr_results): Likewise.
> * ipa-devirt.c (dump_targets): Likewise.
> * ipa-fnsummary.c (analyze_function_body): Likewise.
> * ipa-hsa.c (check_warn_node_versionable): Likewise.
> (process_hsa_functions): Likewise.
> * ipa-icf.c (sem_item_optimizer::merge_classes): Likewise.
> (set_alias_uids): Likewise.
> * ipa-inline-transform.c (save_inline_function_body): Likewise.
> * ipa-inline.c (recursive_inlining): Likewise.
> (inline_to_all_callers_1): Likewise.
> (ipa_inline): Likewise.
> * ipa-profile.c (ipa_propagate_frequency_1): Likewise.
> (ipa_propagate_frequency): Likewise.
> * ipa-prop.c (ipa_make_edge_direct_to_target): Likewise.
> (remove_described_reference): Likewise.
> * ipa-pure-const.c (worse_state): Likewise.
> (check_retval_uses): Likewise.
> (analyze_function): Likewise.
> (propagate_pure_const): Likewise.
> (propagate_nothrow): Likewise.
> (dump_malloc_lattice): Likewise.
> (propagate_malloc): Likewise.
> (pass_local_pure_const::execute): Likewise.
> * ipa-visibility.c (optimize_weakref): Likewise.
> (function_and_variable_visibility): Likewise.
> * ipa.c (symbol_table::remove_unreachable_nodes): Likewise.
> (ipa_discover_variable_flags): Likewise.
> * lto-streamer-out.c (output_function): Likewise.
> (output_constructor): Likewise.
> * tree-inline.c (copy_bb): Likewise.
> * tree-ssa-structalias.c (ipa_pta_execute): Likewise.
> * varpool.c (symbol_table::remove_unreferenced_decls): Likewise.
>
> gcc/lto/ChangeLog:
>
> 2020-01-08 Martin Liska
>
> * lto-partition.c (add_symbol_to_partition_1): Use ::dump_name or
> ::dump_asm_name instead of (::name or ::asm_name).
> (lto_balanced_map): Likewise.
> (promote_symbol): Likewise.
> (rename_statics): Likewise.
> * lto.c (lto_wpa_write_files): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2020-01-08 Martin Liska
>
> * gcc.dg/ipa/ipa-icf-1.c: Update expected scanned output.
> * gcc.dg/ipa/ipa-icf-10.c: Likewise.
> * gcc.dg/ipa/ipa-icf-11.c: Likewise.
> * gcc.dg/ipa/ipa-icf-12.c: Likewise.
> * gcc.dg/ipa/ipa-icf-13.c: Likewise.
> * gcc.dg/ipa/ipa-icf-16.c: Likewise.
> * gcc.dg/ipa/ipa-icf-18.c: Likewise.
> * gcc.dg/ipa/ipa-icf-2.c: Likewise.
> * gcc.dg/ipa/ipa-icf-20.c: Likewise.
> * gcc.dg/ipa/ipa-icf-21.c: Likewise.
> * gcc.dg/ipa/ipa-icf-23.c: Likewise.
> * gcc.dg/ipa/ipa-icf-25.c: Likewise.
> * gcc.dg/ipa/ipa-icf-26.c: Likewise.
> * gcc.dg/ipa/ipa-icf-27.c: Likewise.
> * gcc.dg/ipa/ipa-icf-3.c: Likewise.
> * gcc.dg/ipa/ipa-icf-35.c: Likewise.
> * gcc.dg/ipa/ipa-icf-36.c: Likewise.
> * gcc.dg/ipa/ipa-icf-37.c: Likewise.
> * gcc.dg/ipa/ipa-icf-38.c: Likewise.
> * gcc.dg/ipa/ipa-icf-5.c: Likewise.
> * gcc.dg/ipa/ipa-icf-7.c: Likewise.
> * gcc.dg/ipa/ipa-icf-8.c: Likewise.
> * gcc.dg/ipa/ipa-icf-merge-1.c: Likewise.
> * gcc.dg/ipa/pr64307.c: Likewise.
> * gcc.dg/ipa/pr90555.c: Likewise.
> * gcc.dg/ipa/propmalloc-1.c: Likewise.
> * gcc.dg/ipa/propmalloc-2.c: Likewise.
> * gcc.dg/ipa/propmalloc-3.c: Likewise.
> ---
> gcc/cgraph.c | 2 +-
> gcc/cgraphclones.c | 3 +--
> gcc/cgraphunit.c | 9
> gcc/ipa-cp.c | 22 ++--
> gcc/ipa-devirt.c | 3 +--
> gcc/ipa-fnsummary.c| 2 +-
> gcc/ipa-hsa.c | 10 -
> gcc/ipa-icf.c | 10 -
> gcc/ipa-inline-transform.c | 2 +-
> gcc/ipa-inline.c | 11 +-
> gcc/ipa-profile.c | 18
> gcc/ipa-prop.c
[PATCH] Use cgraph_node::dump_{asm_},name where possible.
Hi.
The patch consistent usage of cgraph_node::dump_{asm_,}name where possible.
Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
Ready to be installed?
Thanks,
Martin
gcc/ChangeLog:
2020-01-08 Martin Liska
* cgraph.c (cgraph_node::dump): Use ::dump_name or
::dump_asm_name instead of (::name or ::asm_name).
* cgraphclones.c (symbol_table::materialize_all_clones): Likewise.
* cgraphunit.c (walk_polymorphic_call_targets): Likewise.
(analyze_functions): Likewise.
(expand_all_functions): Likewise.
* ipa-cp.c (ipcp_cloning_candidate_p): Likewise.
(propagate_bits_across_jump_function): Likewise.
(dump_profile_updates): Likewise.
(ipcp_store_bits_results): Likewise.
(ipcp_store_vr_results): Likewise.
* ipa-devirt.c (dump_targets): Likewise.
* ipa-fnsummary.c (analyze_function_body): Likewise.
* ipa-hsa.c (check_warn_node_versionable): Likewise.
(process_hsa_functions): Likewise.
* ipa-icf.c (sem_item_optimizer::merge_classes): Likewise.
(set_alias_uids): Likewise.
* ipa-inline-transform.c (save_inline_function_body): Likewise.
* ipa-inline.c (recursive_inlining): Likewise.
(inline_to_all_callers_1): Likewise.
(ipa_inline): Likewise.
* ipa-profile.c (ipa_propagate_frequency_1): Likewise.
(ipa_propagate_frequency): Likewise.
* ipa-prop.c (ipa_make_edge_direct_to_target): Likewise.
(remove_described_reference): Likewise.
* ipa-pure-const.c (worse_state): Likewise.
(check_retval_uses): Likewise.
(analyze_function): Likewise.
(propagate_pure_const): Likewise.
(propagate_nothrow): Likewise.
(dump_malloc_lattice): Likewise.
(propagate_malloc): Likewise.
(pass_local_pure_const::execute): Likewise.
* ipa-visibility.c (optimize_weakref): Likewise.
(function_and_variable_visibility): Likewise.
* ipa.c (symbol_table::remove_unreachable_nodes): Likewise.
(ipa_discover_variable_flags): Likewise.
* lto-streamer-out.c (output_function): Likewise.
(output_constructor): Likewise.
* tree-inline.c (copy_bb): Likewise.
* tree-ssa-structalias.c (ipa_pta_execute): Likewise.
* varpool.c (symbol_table::remove_unreferenced_decls): Likewise.
gcc/lto/ChangeLog:
2020-01-08 Martin Liska
* lto-partition.c (add_symbol_to_partition_1): Use ::dump_name or
::dump_asm_name instead of (::name or ::asm_name).
(lto_balanced_map): Likewise.
(promote_symbol): Likewise.
(rename_statics): Likewise.
* lto.c (lto_wpa_write_files): Likewise.
gcc/testsuite/ChangeLog:
2020-01-08 Martin Liska
* gcc.dg/ipa/ipa-icf-1.c: Update expected scanned output.
* gcc.dg/ipa/ipa-icf-10.c: Likewise.
* gcc.dg/ipa/ipa-icf-11.c: Likewise.
* gcc.dg/ipa/ipa-icf-12.c: Likewise.
* gcc.dg/ipa/ipa-icf-13.c: Likewise.
* gcc.dg/ipa/ipa-icf-16.c: Likewise.
* gcc.dg/ipa/ipa-icf-18.c: Likewise.
* gcc.dg/ipa/ipa-icf-2.c: Likewise.
* gcc.dg/ipa/ipa-icf-20.c: Likewise.
* gcc.dg/ipa/ipa-icf-21.c: Likewise.
* gcc.dg/ipa/ipa-icf-23.c: Likewise.
* gcc.dg/ipa/ipa-icf-25.c: Likewise.
* gcc.dg/ipa/ipa-icf-26.c: Likewise.
* gcc.dg/ipa/ipa-icf-27.c: Likewise.
* gcc.dg/ipa/ipa-icf-3.c: Likewise.
* gcc.dg/ipa/ipa-icf-35.c: Likewise.
* gcc.dg/ipa/ipa-icf-36.c: Likewise.
* gcc.dg/ipa/ipa-icf-37.c: Likewise.
* gcc.dg/ipa/ipa-icf-38.c: Likewise.
* gcc.dg/ipa/ipa-icf-5.c: Likewise.
* gcc.dg/ipa/ipa-icf-7.c: Likewise.
* gcc.dg/ipa/ipa-icf-8.c: Likewise.
* gcc.dg/ipa/ipa-icf-merge-1.c: Likewise.
* gcc.dg/ipa/pr64307.c: Likewise.
* gcc.dg/ipa/pr90555.c: Likewise.
* gcc.dg/ipa/propmalloc-1.c: Likewise.
* gcc.dg/ipa/propmalloc-2.c: Likewise.
* gcc.dg/ipa/propmalloc-3.c: Likewise.
---
gcc/cgraph.c | 2 +-
gcc/cgraphclones.c | 3 +--
gcc/cgraphunit.c | 9
gcc/ipa-cp.c | 22 ++--
gcc/ipa-devirt.c | 3 +--
gcc/ipa-fnsummary.c| 2 +-
gcc/ipa-hsa.c | 10 -
gcc/ipa-icf.c | 10 -
gcc/ipa-inline-transform.c | 2 +-
gcc/ipa-inline.c | 11 +-
gcc/ipa-profile.c | 18
gcc/ipa-prop.c | 4 ++--
gcc/ipa-pure-const.c | 24 +++---
gcc/ipa-visibility.c | 8
gcc/ipa.c | 11 +-
gcc/lto-streamer-out.c
