Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
Ping: this a P3 regression targeted at 7.0.1. It was found on x86_64-apple-darwin10.8.0 but affects all targets (even if it doesn't happen to manifest on them): https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html On 03/07/2017 06:03 PM, Martin Sebor wrote: In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source file that implements the warning accessing a global tree without having included the file in GTFILES make variable. (Thanks again to David Malcolm who helped me root cause this bug.) The attached patch fixes this by adding calls.c to the variable and by including the requisite generated header, gt-calls.h, at the end of the source. Martin
Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor wrote: > Ping: this a P3 regression targeted at 7.0.1. It was found > on x86_64-apple-darwin10.8.0 but affects all targets (even > if it doesn't happen to manifest on them): > > https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html I think you need to include gt-calls.h at the bottom of the file. See other GTFILES > On 03/07/2017 06:03 PM, Martin Sebor wrote: >> >> In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter >> encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source >> file that implements the warning accessing a global tree without >> having included the file in GTFILES make variable. (Thanks again >> to David Malcolm who helped me root cause this bug.) >> >> The attached patch fixes this by adding calls.c to the variable and >> by including the requisite generated header, gt-calls.h, at the end >> of the source. >> >> Martin > >
Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
On 03/14/2017 03:01 AM, Richard Biener wrote: On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor wrote: Ping: this a P3 regression targeted at 7.0.1. It was found on x86_64-apple-darwin10.8.0 but affects all targets (even if it doesn't happen to manifest on them): https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html I think you need to include gt-calls.h at the bottom of the file. See other GTFILES But the patch does include gt-calls.h at the end of calls.c, which is consistent with other uses. Or did you have something else in mind? jeff
Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
On Tue, Mar 14, 2017 at 4:52 PM, Jeff Law wrote: > On 03/14/2017 03:01 AM, Richard Biener wrote: >> >> On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor wrote: >>> >>> Ping: this a P3 regression targeted at 7.0.1. It was found >>> on x86_64-apple-darwin10.8.0 but affects all targets (even >>> if it doesn't happen to manifest on them): >>> >>> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html >> >> >> I think you need to include gt-calls.h at the bottom of the file. See >> other >> GTFILES > > But the patch does include gt-calls.h at the end of calls.c, which is > consistent with other uses. > > Or did you have something else in mind? Eh, no. Just didn't spot that part... Patch is ok. Richard. > jeff >
