Re: [PATCH] aix: Add FAT library support for libffi
On Wed, Sep 15, 2021 at 6:18 AM David Edelsohn via Gcc-patches wrote: > > Clement, > > GCC libffi cherry-picks / backports patches from upstream, but it does > not maintain local patches, so we need to find another solution. > Please take a look at my libffi patches: https://gcc.gnu.org/pipermail/gcc-patches/2021-September/578702.html I provided a way to maintain local patches, similar to libsanitizer. > Thanks, David > > On Wed, Sep 15, 2021 at 9:14 AM CHIGOT, CLEMENT > wrote: > > > > Hi David, > > > > The problem is that it has no meaning in libffi itself... > > This patch is specific to gcc because the multilib part is specific > > to gcc. > > I'll ask the community but the patch cannot be merged inside > > libffi. > > > > Thanks, > > Clément > > > > From: David Edelsohn > > Sent: Wednesday, September 15, 2021 2:52 PM > > To: CHIGOT, CLEMENT > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] aix: Add FAT library support for libffi > > > > Caution! External email. Do not open attachments or click links, unless > > this email comes from a known sender and you know the content is safe. > > > > Clement, > > > > GCC is not the primary repository for libffi. This patch must be > > submitted to the libffi project first, not GCC. If it is accepted in > > libffi, then you can ask for a backport to GCC. > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flibffi%2Flibffidata=04%7C01%7Cclement.chigot%40atos.net%7C58a9dee835dd4d5ca10308d97847ec9c%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637673072579890230%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=6%2B%2Bxl4K30%2B%2FvitHcOZwwyq1B6CwAEtHmr3LXgUIp9uQ%3Dreserved=0 > > > > Thanks, David > > > > On Wed, Sep 15, 2021 at 7:20 AM CHIGOT, CLEMENT > > wrote: > > > > > > Even if GCC64 is able to bootstrap without libffi being a > > > FAT library on AIX, the tests for "-maix32" are not working > > > without it. > > > > > > libffi/ChangeLog: > > > 2021-09-10 Clément Chigot > > > > > > * Makefile.am (tmake_file): Build and install AIX-style FAT > > > libraries. > > > * Makefile.in: Regenerate. > > > * include/Makefile.in: Regenerate. > > > * man/Makefile.in: Regenerate. > > > * testsuite/Makefile.in: Regenerate. > > > * configure (tmake_file): Substitute. > > > * configure.ac: Regenerate. > > > * configure.host (powerpc-*-aix*): Define tmake_file. > > > * src/powerpc/t-aix: New file. > > > > > > > > > > > > > > > Clément Chigot > > > ATOS Bull SAS > > > 1 rue de Provence - 38432 Échirolles - France > > > -- H.J.
Re: [PATCH] aix: Add FAT library support for libffi
Clement, GCC libffi cherry-picks / backports patches from upstream, but it does not maintain local patches, so we need to find another solution. Thanks, David On Wed, Sep 15, 2021 at 9:14 AM CHIGOT, CLEMENT wrote: > > Hi David, > > The problem is that it has no meaning in libffi itself... > This patch is specific to gcc because the multilib part is specific > to gcc. > I'll ask the community but the patch cannot be merged inside > libffi. > > Thanks, > Clément > > From: David Edelsohn > Sent: Wednesday, September 15, 2021 2:52 PM > To: CHIGOT, CLEMENT > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] aix: Add FAT library support for libffi > > Caution! External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > Clement, > > GCC is not the primary repository for libffi. This patch must be > submitted to the libffi project first, not GCC. If it is accepted in > libffi, then you can ask for a backport to GCC. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flibffi%2Flibffidata=04%7C01%7Cclement.chigot%40atos.net%7C58a9dee835dd4d5ca10308d97847ec9c%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637673072579890230%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=6%2B%2Bxl4K30%2B%2FvitHcOZwwyq1B6CwAEtHmr3LXgUIp9uQ%3Dreserved=0 > > Thanks, David > > On Wed, Sep 15, 2021 at 7:20 AM CHIGOT, CLEMENT > wrote: > > > > Even if GCC64 is able to bootstrap without libffi being a > > FAT library on AIX, the tests for "-maix32" are not working > > without it. > > > > libffi/ChangeLog: > > 2021-09-10 Clément Chigot > > > > * Makefile.am (tmake_file): Build and install AIX-style FAT > > libraries. > > * Makefile.in: Regenerate. > > * include/Makefile.in: Regenerate. > > * man/Makefile.in: Regenerate. > > * testsuite/Makefile.in: Regenerate. > > * configure (tmake_file): Substitute. > > * configure.ac: Regenerate. > > * configure.host (powerpc-*-aix*): Define tmake_file. > > * src/powerpc/t-aix: New file. > > > > > > > > > > Clément Chigot > > ATOS Bull SAS > > 1 rue de Provence - 38432 Échirolles - France > >
Re: [PATCH] aix: Add FAT library support for libffi
Hi David, The problem is that it has no meaning in libffi itself... This patch is specific to gcc because the multilib part is specific to gcc. I'll ask the community but the patch cannot be merged inside libffi. Thanks, Clément From: David Edelsohn Sent: Wednesday, September 15, 2021 2:52 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] aix: Add FAT library support for libffi Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. Clement, GCC is not the primary repository for libffi. This patch must be submitted to the libffi project first, not GCC. If it is accepted in libffi, then you can ask for a backport to GCC. https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flibffi%2Flibffidata=04%7C01%7Cclement.chigot%40atos.net%7C58a9dee835dd4d5ca10308d97847ec9c%7C33440fc6b7c7412cbb730e70b0198d5a%7C0%7C0%7C637673072579890230%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=6%2B%2Bxl4K30%2B%2FvitHcOZwwyq1B6CwAEtHmr3LXgUIp9uQ%3Dreserved=0 Thanks, David On Wed, Sep 15, 2021 at 7:20 AM CHIGOT, CLEMENT wrote: > > Even if GCC64 is able to bootstrap without libffi being a > FAT library on AIX, the tests for "-maix32" are not working > without it. > > libffi/ChangeLog: > 2021-09-10 Clément Chigot > > * Makefile.am (tmake_file): Build and install AIX-style FAT > libraries. > * Makefile.in: Regenerate. > * include/Makefile.in: Regenerate. > * man/Makefile.in: Regenerate. > * testsuite/Makefile.in: Regenerate. > * configure (tmake_file): Substitute. > * configure.ac: Regenerate. > * configure.host (powerpc-*-aix*): Define tmake_file. > * src/powerpc/t-aix: New file. > > > > > Clément Chigot > ATOS Bull SAS > 1 rue de Provence - 38432 Échirolles - France >
Re: [PATCH] aix: Add FAT library support for libffi
Clement, GCC is not the primary repository for libffi. This patch must be submitted to the libffi project first, not GCC. If it is accepted in libffi, then you can ask for a backport to GCC. https://github.com/libffi/libffi Thanks, David On Wed, Sep 15, 2021 at 7:20 AM CHIGOT, CLEMENT wrote: > > Even if GCC64 is able to bootstrap without libffi being a > FAT library on AIX, the tests for "-maix32" are not working > without it. > > libffi/ChangeLog: > 2021-09-10 Clément Chigot > > * Makefile.am (tmake_file): Build and install AIX-style FAT > libraries. > * Makefile.in: Regenerate. > * include/Makefile.in: Regenerate. > * man/Makefile.in: Regenerate. > * testsuite/Makefile.in: Regenerate. > * configure (tmake_file): Substitute. > * configure.ac: Regenerate. > * configure.host (powerpc-*-aix*): Define tmake_file. > * src/powerpc/t-aix: New file. > > > > > Clément Chigot > ATOS Bull SAS > 1 rue de Provence - 38432 Échirolles - France >
[PATCH] aix: Add FAT library support for libffi
Even if GCC64 is able to bootstrap without libffi being a FAT library on AIX, the tests for "-maix32" are not working without it. libffi/ChangeLog: 2021-09-10 Clément Chigot * Makefile.am (tmake_file): Build and install AIX-style FAT libraries. * Makefile.in: Regenerate. * include/Makefile.in: Regenerate. * man/Makefile.in: Regenerate. * testsuite/Makefile.in: Regenerate. * configure (tmake_file): Substitute. * configure.ac: Regenerate. * configure.host (powerpc-*-aix*): Define tmake_file. * src/powerpc/t-aix: New file. Clément Chigot ATOS Bull SAS 1 rue de Provence - 38432 Échirolles - France 0001-aix-Add-FAT-library-support-for-libffi.patch Description: 0001-aix-Add-FAT-library-support-for-libffi.patch
