Re: [PATCH] cr16: remove obsoleted port
On 8/25/22 19:06, Andrew Pinski wrote:
> You missed the following one:
> gcc/testsuite/lib/target-supports.exp:if { [istarget msp430-*-*]
> || [istarget cr16-*-*] } {
Thanks, included and installed as r13-2209-geb6358247a9386.
Martin
Re: [PATCH] cr16: remove obsoleted port
On 8/25/22 18:54, Joseph Myers wrote: > On Thu, 25 Aug 2022, Martin Liška wrote: > >> * config.sub: Remove cr16. > > config.sub and config.guess are imported verbatim from config.git; any > changes should go upstream first. Removal from config.sub would only be > appropriate if *no* GNU package wants to support cr16 any more. > Ah, thanks for the heads up! Martin
Re: [PATCH] cr16: remove obsoleted port
On Thu, 25 Aug 2022, Martin Liška wrote: > * config.sub: Remove cr16. config.sub and config.guess are imported verbatim from config.git; any changes should go upstream first. Removal from config.sub would only be appropriate if *no* GNU package wants to support cr16 any more. -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH] cr16: remove obsoleted port
On 8/25/2022 2:38 AM, Martin Liška wrote: Remove the port that has been marked obsolete in GCC 12 change notes. Ready to be installed? Thanks, Martin ChangeLog: * config.sub: Remove cr16. contrib/ChangeLog: * config-list.mk: Remove cr16. gcc/ChangeLog: * config.gcc: Remove cr16 related stuff. * doc/extend.texi: Likewise. * doc/install.texi: Likewise. * doc/invoke.texi: Likewise. * doc/md.texi: Likewise. * function-tests.cc (test_expansion_to_rtl): Likewise. * common/config/cr16/cr16-common.cc: Removed. * config/cr16/constraints.md: Removed. * config/cr16/cr16-protos.h: Removed. * config/cr16/cr16.cc: Removed. * config/cr16/cr16.h: Removed. * config/cr16/cr16.md: Removed. * config/cr16/cr16.opt: Removed. * config/cr16/predicates.md: Removed. * config/cr16/t-cr16: Removed. libgcc/ChangeLog: * config.host: Remove cr16 related stuff. * config/cr16/crti.S: Removed. * config/cr16/crtlibid.S: Removed. * config/cr16/crtn.S: Removed. * config/cr16/divmodhi3.c: Removed. * config/cr16/lib1funcs.S: Removed. * config/cr16/t-cr16: Removed. * config/cr16/t-crtlibid: Removed. * config/cr16/unwind-cr16.c: Removed. * config/cr16/unwind-dw2.h: Removed. LGTM. If any additional cr16 bits are found, feel free to remove them too. jeff
Re: [PATCH] cr16: remove obsoleted port
On Thu, 2022-08-25 14:50:12 +0200, Martin Liška wrote: > On 8/25/22 14:48, Jan-Benedict Glaw wrote: > > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > >> Remove the port that has been marked obsolete in GCC 12 change notes. > > > >> contrib/ChangeLog: > >> > >>* config-list.mk: Remove cr16. > > > > Thanks for not forgetting this part! I hope the scripts will properly > > pick up the cr16 removal. We'll find out! :) > > Which scripts do you mean? My laminar job scripts, they directly use `make -f contrib/config-list.mk show` output. > May I install the patch? LGTM, but I'm a write-after-approval committer and no reviewer or global maintainer. MfG, JBG -- signature.asc Description: PGP signature
Re: [PATCH] cr16: remove obsoleted port
On 8/25/22 14:48, Jan-Benedict Glaw wrote: > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: >> Remove the port that has been marked obsolete in GCC 12 change notes. > >> contrib/ChangeLog: >> >> * config-list.mk: Remove cr16. > > Thanks for not forgetting this part! I hope the scripts will properly > pick up the cr16 removal. We'll find out! :) Which scripts do you mean? May I install the patch? Thanks, Martin > > MfG, JBG >
Re: [PATCH] cr16: remove obsoleted port
On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > Remove the port that has been marked obsolete in GCC 12 change notes. > contrib/ChangeLog: > > * config-list.mk: Remove cr16. Thanks for not forgetting this part! I hope the scripts will properly pick up the cr16 removal. We'll find out! :) MfG, JBG -- signature.asc Description: PGP signature
