Re: [PATCH] d: Add darwin support for D language front-end
Hi, Sorry it's been delayed by a bit. Currently Iain (not that Iain) is running tests on a wide net of versions and architectures, with mixed success rates that seem to boil down to some C binding issue. Most of the published effort on my side is currently sitting in users/ibuclaw/darwin. Iain. Excerpts from ciel's message of December 7, 2020 3:43 am: > Iain-san, > > Thank you for finally working on GDC Darwin support. > > T. Yamada > > 2020年11月30日(月) 7:28 : >> >> Send Gcc-patches mailing list submissions to >> gcc-patches@gcc.gnu.org >> >> To subscribe or unsubscribe via the World Wide Web, visit >> https://gcc.gnu.org/mailman/listinfo/gcc-patches >> or, via email, send a message with subject or body 'help' to >> gcc-patches-requ...@gcc.gnu.org >> >> You can reach the person managing the list at >> gcc-patches-ow...@gcc.gnu.org >> >> When replying, please edit your Subject line so it is more specific >> than "Re: Contents of Gcc-patches digest..." >> Today's Topics: >> >>1. Re: [PATCH] configure: Support building D front-end on >> *-*-darwin* (Iain Buclaw) >>2. Re: [PATCH] d: Add darwin support for D language front-end >> (Iain Buclaw) >>3. Fix freeing of thunk_info (Jan Hubicka) >>4. Re: [PATCH] handle conditionals in -Wstringop-overflow et al. >> (PR 92936) (Martin Sebor) >> >> >> >> -- Forwarded message -- >> From: Iain Buclaw >> To: Iain Sandoe >> Cc: gcc-patches@gcc.gnu.org >> Bcc: >> Date: Sun, 29 Nov 2020 22:13:58 +0100 >> Subject: Re: [PATCH] configure: Support building D front-end on *-*-darwin* >> Excerpts from Iain Sandoe's message of November 29, 2020 10:35 am: >> > Hi Iain >> > >> > Iain Buclaw wrote: >> > >> >> The bootstrap has been succeeding for some time now, there's no need to >> >> set it as an unsupported language. >> >> >> >> OK for mainline? >> > >> > At present, this breaks bootstrap on 32 bit Darwin hosts. >> > >> > Once that’s resolved, then it seems a reasonable to make sure that the D >> > FE is built and tested (even though there is still work to do on the >> > library >> > support). >> > >> > So, OK once all the currently tested Darwin hosts bootstrap with D enabled. >> > >> >> As confirmed off list, powerpc and i686 darwin9 bootstrapped OK, so I've >> committed it as r11-5521. >> >> Iain. >> >> >> >> >> -- Forwarded message -- >> From: Iain Buclaw >> To: Iain Sandoe >> Cc: gcc-patches@gcc.gnu.org >> Bcc: >> Date: Sun, 29 Nov 2020 22:21:26 +0100 >> Subject: Re: [PATCH] d: Add darwin support for D language front-end >> Excerpts from Iain Sandoe's message of November 29, 2020 1:49 pm: >> > Hi Iain >> > >> > Iain Buclaw wrote: >> > >> >> This patch adds necessary predefined version symbols and support for >> >> moduleinfo sections for darwin to allow testing libphobos support. >> >> >> >> OK for mainline? >> > >> > As we discussed off-list, this sets ABI (the section names are visible and >> > part >> > of the contract with the runtime). >> > >> > It’s highly desirable that we can interoperate with D objects built by >> > other impls. >> > so the section naming convention should be agreed. >> > >> > As far as I understand things, the names you have here agree with those >> > used >> > by “upstream” (but current the LLVM D variant uses something different). >> > >> > The Darwin parts are OK, with a note to (re-)check on the section names >> > before >> > the first release*. >> > >> > thanks >> > Iain >> > >> > * perhaps it might be worth pinging the relevant upstream and LLV folks >> > long >> > before that - since the release cycles there mean that there will likely be >> > another >> > one before GCC11 ships. >> > >> >> I've sent Martin a message, so hoping for a response within the week >> which name he'd prefer I go. I suspect it'd be better to align with >> LLVM instead of the reference DMD compiler. As the compiler/run-time >> integration of modules uses the same machinery, and we both want to >> support loading shared DSOs (DMD is static only on OSX). >> >> Adjusted the patch with some copy
Re: [PATCH] d: Add darwin support for D language front-end
Iain-san, Thank you for finally working on GDC Darwin support. T. Yamada 2020年11月30日(月) 7:28 : > > Send Gcc-patches mailing list submissions to > gcc-patches@gcc.gnu.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://gcc.gnu.org/mailman/listinfo/gcc-patches > or, via email, send a message with subject or body 'help' to > gcc-patches-requ...@gcc.gnu.org > > You can reach the person managing the list at > gcc-patches-ow...@gcc.gnu.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Gcc-patches digest..." > Today's Topics: > >1. Re: [PATCH] configure: Support building D front-end on > *-*-darwin* (Iain Buclaw) >2. Re: [PATCH] d: Add darwin support for D language front-end > (Iain Buclaw) >3. Fix freeing of thunk_info (Jan Hubicka) >4. Re: [PATCH] handle conditionals in -Wstringop-overflow et al. > (PR 92936) (Martin Sebor) > > > > -- Forwarded message -- > From: Iain Buclaw > To: Iain Sandoe > Cc: gcc-patches@gcc.gnu.org > Bcc: > Date: Sun, 29 Nov 2020 22:13:58 +0100 > Subject: Re: [PATCH] configure: Support building D front-end on *-*-darwin* > Excerpts from Iain Sandoe's message of November 29, 2020 10:35 am: > > Hi Iain > > > > Iain Buclaw wrote: > > > >> The bootstrap has been succeeding for some time now, there's no need to > >> set it as an unsupported language. > >> > >> OK for mainline? > > > > At present, this breaks bootstrap on 32 bit Darwin hosts. > > > > Once that’s resolved, then it seems a reasonable to make sure that the D > > FE is built and tested (even though there is still work to do on the library > > support). > > > > So, OK once all the currently tested Darwin hosts bootstrap with D enabled. > > > > As confirmed off list, powerpc and i686 darwin9 bootstrapped OK, so I've > committed it as r11-5521. > > Iain. > > > > > -- Forwarded message -- > From: Iain Buclaw > To: Iain Sandoe > Cc: gcc-patches@gcc.gnu.org > Bcc: > Date: Sun, 29 Nov 2020 22:21:26 +0100 > Subject: Re: [PATCH] d: Add darwin support for D language front-end > Excerpts from Iain Sandoe's message of November 29, 2020 1:49 pm: > > Hi Iain > > > > Iain Buclaw wrote: > > > >> This patch adds necessary predefined version symbols and support for > >> moduleinfo sections for darwin to allow testing libphobos support. > >> > >> OK for mainline? > > > > As we discussed off-list, this sets ABI (the section names are visible and > > part > > of the contract with the runtime). > > > > It’s highly desirable that we can interoperate with D objects built by > > other impls. > > so the section naming convention should be agreed. > > > > As far as I understand things, the names you have here agree with those used > > by “upstream” (but current the LLVM D variant uses something different). > > > > The Darwin parts are OK, with a note to (re-)check on the section names > > before > > the first release*. > > > > thanks > > Iain > > > > * perhaps it might be worth pinging the relevant upstream and LLV folks long > > before that - since the release cycles there mean that there will likely be > > another > > one before GCC11 ships. > > > > I've sent Martin a message, so hoping for a response within the week > which name he'd prefer I go. I suspect it'd be better to align with > LLVM instead of the reference DMD compiler. As the compiler/run-time > integration of modules uses the same machinery, and we both want to > support loading shared DSOs (DMD is static only on OSX). > > Adjusted the patch with some copy/paste fixes (missing tabs, Glibc gets > a mention). Committed the following as r11-5522. > > Regards, > Iain > > --- > gcc/ChangeLog: > > * config.gcc (*-*-darwin*): Set d_target_objs and target_has_targetdm. > * config/elfos.h (TARGET_D_MINFO_SECTION): New macro. > (TARGET_D_MINFO_START_NAME): New macro. > (TARGET_D_MINFO_END_NAME): New macro. > * config/t-darwin: Add darwin-d.o. > * doc/tm.texi: Regenerate. > * doc/tm.texi.in (D language and ABI): Add @hook for > TARGET_D_MINFO_SECTION, TARGET_D_MINFO_START_NAME, and > TARGET_D_MINFO_END_NAME. > * config/darwin-d.c: New file. > > gcc/d/ChangeLog: > > * d-target.def (d_minfo_section): New hook. > (d_minfo_start_name): New hook. > (d_minfo_e
Re: [PATCH] d: Add darwin support for D language front-end
Excerpts from Iain Sandoe's message of November 29, 2020 1:49 pm:
> Hi Iain
>
> Iain Buclaw wrote:
>
>> This patch adds necessary predefined version symbols and support for
>> moduleinfo sections for darwin to allow testing libphobos support.
>>
>> OK for mainline?
>
> As we discussed off-list, this sets ABI (the section names are visible and
> part
> of the contract with the runtime).
>
> It’s highly desirable that we can interoperate with D objects built by
> other impls.
> so the section naming convention should be agreed.
>
> As far as I understand things, the names you have here agree with those used
> by “upstream” (but current the LLVM D variant uses something different).
>
> The Darwin parts are OK, with a note to (re-)check on the section names
> before
> the first release*.
>
> thanks
> Iain
>
> * perhaps it might be worth pinging the relevant upstream and LLV folks long
> before that - since the release cycles there mean that there will likely be
> another
> one before GCC11 ships.
>
I've sent Martin a message, so hoping for a response within the week
which name he'd prefer I go. I suspect it'd be better to align with
LLVM instead of the reference DMD compiler. As the compiler/run-time
integration of modules uses the same machinery, and we both want to
support loading shared DSOs (DMD is static only on OSX).
Adjusted the patch with some copy/paste fixes (missing tabs, Glibc gets
a mention). Committed the following as r11-5522.
Regards,
Iain
---
gcc/ChangeLog:
* config.gcc (*-*-darwin*): Set d_target_objs and target_has_targetdm.
* config/elfos.h (TARGET_D_MINFO_SECTION): New macro.
(TARGET_D_MINFO_START_NAME): New macro.
(TARGET_D_MINFO_END_NAME): New macro.
* config/t-darwin: Add darwin-d.o.
* doc/tm.texi: Regenerate.
* doc/tm.texi.in (D language and ABI): Add @hook for
TARGET_D_MINFO_SECTION, TARGET_D_MINFO_START_NAME, and
TARGET_D_MINFO_END_NAME.
* config/darwin-d.c: New file.
gcc/d/ChangeLog:
* d-target.def (d_minfo_section): New hook.
(d_minfo_start_name): New hook.
(d_minfo_end_name): New hook.
* modules.cc: Include d-target.h.
(register_moduleinfo): Update to use new targetdm hooks.
---
gcc/config.gcc| 2 ++
gcc/config/darwin-d.c | 49 +++
gcc/config/elfos.h| 6 ++
gcc/config/t-darwin | 3 +++
gcc/d/d-target.def| 25 ++
gcc/d/modules.cc | 14 ++---
gcc/doc/tm.texi | 20 ++
gcc/doc/tm.texi.in| 6 ++
8 files changed, 122 insertions(+), 3 deletions(-)
create mode 100644 gcc/config/darwin-d.c
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 0ae58482657..aacab0d9133 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -702,8 +702,10 @@ case ${target} in
extra_options="${extra_options} darwin.opt"
c_target_objs="${c_target_objs} darwin-c.o"
cxx_target_objs="${cxx_target_objs} darwin-c.o"
+ d_target_objs="${d_target_objs} darwin-d.o"
fortran_target_objs="darwin-f.o"
target_has_targetcm=yes
+ target_has_targetdm=yes
extra_objs="${extra_objs} darwin.o"
extra_gcc_objs="darwin-driver.o"
default_use_cxa_atexit=yes
diff --git a/gcc/config/darwin-d.c b/gcc/config/darwin-d.c
new file mode 100644
index 000..ced07ce006a
--- /dev/null
+++ b/gcc/config/darwin-d.c
@@ -0,0 +1,49 @@
+/* Darwin support needed only by D front-end.
+ Copyright (C) 2020 Free Software Foundation, Inc.
+
+GCC is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License as published by the Free
+Software Foundation; either version 3, or (at your option) any later
+version.
+
+GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3. If not see
+
Re: [PATCH] d: Add darwin support for D language front-end
Hi Iain
Iain Buclaw wrote:
This patch adds necessary predefined version symbols and support for
moduleinfo sections for darwin to allow testing libphobos support.
OK for mainline?
As we discussed off-list, this sets ABI (the section names are visible and
part
of the contract with the runtime).
It’s highly desirable that we can interoperate with D objects built by
other impls.
so the section naming convention should be agreed.
As far as I understand things, the names you have here agree with those used
by “upstream” (but current the LLVM D variant uses something different).
The Darwin parts are OK, with a note to (re-)check on the section names
before
the first release*.
thanks
Iain
* perhaps it might be worth pinging the relevant upstream and LLV folks long
before that - since the release cycles there mean that there will likely be
another
one before GCC11 ships.
Regards
Iain.
---
gcc/ChangeLog:
* config.gcc (*-*-darwin*): Set d_target_objs and target_has_targetdm.
* config/elfos.h (TARGET_D_MINFO_SECTION): New macro.
(TARGET_D_MINFO_START_NAME): New macro.
(TARGET_D_MINFO_END_NAME): New macro.
* config/t-darwin: Add darwin-d.o.
* doc/tm.texi: Regenerate.
* doc/tm.texi.in (D language and ABI): Add @hook for
TARGET_D_MINFO_SECTION, TARGET_D_MINFO_START_NAME, and
TARGET_D_MINFO_END_NAME.
* config/darwin-d.c: New file.
gcc/d/ChangeLog:
* d-target.def (d_minfo_section): New hook.
(d_minfo_start_name): New hook.
(d_minfo_end_name): New hook.
* modules.cc: Include d-target.h.
(register_moduleinfo): Update to use new targetdm hooks.
---
gcc/config.gcc| 2 ++
gcc/config/darwin-d.c | 49 +++
gcc/config/elfos.h| 6 ++
gcc/config/t-darwin | 3 +++
gcc/d/d-target.def| 25 ++
gcc/d/modules.cc | 14 ++---
gcc/doc/tm.texi | 20 ++
gcc/doc/tm.texi.in| 6 ++
8 files changed, 122 insertions(+), 3 deletions(-)
create mode 100644 gcc/config/darwin-d.c
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 0ae58482657..aacab0d9133 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -702,8 +702,10 @@ case ${target} in
extra_options="${extra_options} darwin.opt"
c_target_objs="${c_target_objs} darwin-c.o"
cxx_target_objs="${cxx_target_objs} darwin-c.o"
+ d_target_objs="${d_target_objs} darwin-d.o"
fortran_target_objs="darwin-f.o"
target_has_targetcm=yes
+ target_has_targetdm=yes
extra_objs="${extra_objs} darwin.o"
extra_gcc_objs="darwin-driver.o"
default_use_cxa_atexit=yes
diff --git a/gcc/config/darwin-d.c b/gcc/config/darwin-d.c
new file mode 100644
index 000..90a9a4a0613
--- /dev/null
+++ b/gcc/config/darwin-d.c
@@ -0,0 +1,49 @@
+/* Darwin support needed only by D front-end.
+ Copyright (C) 2020 Free Software Foundation, Inc.
+
+GCC is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License as published by the Free
+Software Foundation; either version 3, or (at your option) any later
+version.
+
+GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3. If not see
+
[PATCH] d: Add darwin support for D language front-end
Hi,
This patch adds necessary predefined version symbols and support for
moduleinfo sections for darwin to allow testing libphobos support.
OK for mainline?
Regards
Iain.
---
gcc/ChangeLog:
* config.gcc (*-*-darwin*): Set d_target_objs and target_has_targetdm.
* config/elfos.h (TARGET_D_MINFO_SECTION): New macro.
(TARGET_D_MINFO_START_NAME): New macro.
(TARGET_D_MINFO_END_NAME): New macro.
* config/t-darwin: Add darwin-d.o.
* doc/tm.texi: Regenerate.
* doc/tm.texi.in (D language and ABI): Add @hook for
TARGET_D_MINFO_SECTION, TARGET_D_MINFO_START_NAME, and
TARGET_D_MINFO_END_NAME.
* config/darwin-d.c: New file.
gcc/d/ChangeLog:
* d-target.def (d_minfo_section): New hook.
(d_minfo_start_name): New hook.
(d_minfo_end_name): New hook.
* modules.cc: Include d-target.h.
(register_moduleinfo): Update to use new targetdm hooks.
---
gcc/config.gcc| 2 ++
gcc/config/darwin-d.c | 49 +++
gcc/config/elfos.h| 6 ++
gcc/config/t-darwin | 3 +++
gcc/d/d-target.def| 25 ++
gcc/d/modules.cc | 14 ++---
gcc/doc/tm.texi | 20 ++
gcc/doc/tm.texi.in| 6 ++
8 files changed, 122 insertions(+), 3 deletions(-)
create mode 100644 gcc/config/darwin-d.c
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 0ae58482657..aacab0d9133 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -702,8 +702,10 @@ case ${target} in
extra_options="${extra_options} darwin.opt"
c_target_objs="${c_target_objs} darwin-c.o"
cxx_target_objs="${cxx_target_objs} darwin-c.o"
+ d_target_objs="${d_target_objs} darwin-d.o"
fortran_target_objs="darwin-f.o"
target_has_targetcm=yes
+ target_has_targetdm=yes
extra_objs="${extra_objs} darwin.o"
extra_gcc_objs="darwin-driver.o"
default_use_cxa_atexit=yes
diff --git a/gcc/config/darwin-d.c b/gcc/config/darwin-d.c
new file mode 100644
index 000..90a9a4a0613
--- /dev/null
+++ b/gcc/config/darwin-d.c
@@ -0,0 +1,49 @@
+/* Darwin support needed only by D front-end.
+ Copyright (C) 2020 Free Software Foundation, Inc.
+
+GCC is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License as published by the Free
+Software Foundation; either version 3, or (at your option) any later
+version.
+
+GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3. If not see
+
