Re: [PATCH] fixed testcase riscv/pr103302.c

[Kito Cheng via Gcc-patches]

Hi ShiHua:

Thanks for the fix, committed with Andrew's comment and minor fix for
commit comment.

On Thu, Dec 23, 2021 at 3:41 PM Andrew Pinski via Gcc-patches
 wrote:
>
> On Wed, Dec 22, 2021 at 11:37 PM  wrote:
> >
> > From: LiaoShihua 
> >
> > because riscv32 not support __int128, so skip if -march=rv32*.
> >
> > gcc/testsuite\ChangeLog:
> > * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> > ---
> >  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c 
> > b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > index 822c4087416..2cfb12498a2 100644
> > --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> > +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> > @@ -1,4 +1,5 @@
> >  /* { dg-do run } */
> > +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } 
> > */
>
> Better fix:
> /* { dg-do run { target int128 } } */
>
> Thanks,
> Andrew Pinski
>
> >  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
> >
> >  typedef unsigned char u8;
> > --
> > 2.31.1.windows.1
> >

Re: [PATCH] fixed testcase riscv/pr103302.c

[Andrew Pinski via Gcc-patches]

On Wed, Dec 22, 2021 at 11:37 PM  wrote:
>
> From: LiaoShihua 
>
> because riscv32 not support __int128, so skip if -march=rv32*.
>
> gcc/testsuite\ChangeLog:
> * gcc.target/riscv/pr103302.c: skip if -march=rv32*
> ---
>  gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c 
> b/gcc/testsuite/gcc.target/riscv/pr103302.c
> index 822c4087416..2cfb12498a2 100644
> --- a/gcc/testsuite/gcc.target/riscv/pr103302.c
> +++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */

Better fix:
/* { dg-do run { target int128 } } */

Thanks,
Andrew Pinski

>  /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
>
>  typedef unsigned char u8;
> --
> 2.31.1.windows.1
>

[PATCH] fixed testcase riscv/pr103302.c

[shihua]

From: LiaoShihua 

because riscv32 not support __int128, so skip if -march=rv32*.

gcc/testsuite\ChangeLog:
* gcc.target/riscv/pr103302.c: skip if -march=rv32*
---
 gcc/testsuite/gcc.target/riscv/pr103302.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.target/riscv/pr103302.c 
b/gcc/testsuite/gcc.target/riscv/pr103302.c
index 822c4087416..2cfb12498a2 100644
--- a/gcc/testsuite/gcc.target/riscv/pr103302.c
+++ b/gcc/testsuite/gcc.target/riscv/pr103302.c
@@ -1,4 +1,5 @@
 /* { dg-do run } */
+/* { dg-skip-if "rv32 not support _int128" { *-*-* } { "-march=rv32*" } } */
 /* { dg-options "-Og -fharden-compares -fno-tree-dce -fno-tree-fre " } */
 
 typedef unsigned char u8;
-- 
2.31.1.windows.1