Re: [PATCH] libstdc++ Add cstdarg to freestanding
On Sun, 22 Oct 2023 at 21:06, Arsen Arsenović wrote: > > "Paul M. Bendixen" writes: > > > Updated patch, added the requested files, hopefully wrote the commit > better. > > LGTM. Jonathan? > Yup, looks good. I've pushed it to trunk with a tweaked changelog entry. I'll backport it to gcc-13 soon too. Thanks, Paul!
Re: [PATCH] libstdc++ Add cstdarg to freestanding
"Paul M. Bendixen" writes: > Updated patch, added the requested files, hopefully wrote the commit better. LGTM. Jonathan? -- Arsen Arsenović signature.asc Description: PGP signature
Re: [PATCH] libstdc++ Add cstdarg to freestanding
Updated patch, added the requested files, hopefully wrote the commit better.
Den tors. 7. sep. 2023 kl. 18.28 skrev Jonathan Wakely :
> On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen
> wrote:
> >
> > Hi
> > Jonathan, I just went over the proposal again as well as [compliance],
> which Arsen mentioned ( https://wg21.link/compliance ) don't seem to
> mention either or .
>
> Those headers were freestanding in C++17. They're not present in C++20
> and C++23, but we support C++17 and earlier standards.
>
> In GCC 12 and were both installed when you
> built the library with --disable-hosted-libstdcxx, so the fact they're
> no longer installed for a freestanding build in GC 13 is a regression.
> Please do include them.
>
>
> >
> > Shouldn't I just stick to the ones we know are in?
> >
> > (Still working on figuring out how to do the change log thing)
> >
> > Best regards
> > Paul
> >
> > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen <
> paulbendi...@gmail.com>:
> >>
> >> Yes, the other files are in another committee proposal, and I'm working
> my way through the proposals one by one.
> >> Thank you for the feedback, I'll update and resend
> >> /Paul
> >>
> >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović >:
> >>>
> >>>
> >>> Jonathan Wakely writes:
> >>>
> >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++
> >>> > wrote:
> >>> >>
> >>> >> P1642 includes the header cstdarg to the freestanding
> implementation.
> >>> >> This was probably left out by accident, this patch puts it in.
> >>> >> Since this is one of the headers that go in whole cloth, there
> should be no
> >>> >> further actions needed.
> >>> >
> >>> > Thanks for the patch. I agree that should be freestanding,
> >>> > but I think and were also missed from the
> >>> > change. Arsen?
> >>>
> >>> Indeed, we should include all three, and according to [compliance],
> >>> there's a couple more headers that we should provide (cwchar, cstring,
> >>> cerrno, and cmath, but these are probably significantly more involved,
> >>> so we can handle them separately).
> >>>
> >>> As guessed, the omission was not intentional.
> >>>
> >>> If you could, add those two to the patch as well, edit Makefile.am and
> >>> regenerate using automake 1.15.1, and see
> >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit
> messages.
> >>>
> >>> Thank you! Have a lovely day :-)
> >>>
> >>> [compliance]: https://eel.is/c++draft/compliance
> >>>
> >>> > Also, the patch should change include/Makefile.am as well (the .in
> >>> > file is autogenerated from that one).
> >>> >
> >>> >
> >>> >> This might be related to PR106953, but since that one touches the
> partial
> >>> >> headers I'm not sure
> >>>
> >>> The headers mentioned in this PR are provided in freestanding,
> >>> partially, in 13 already, indeed.
> >>>
> >>> >> /Paul M. Bendixen
> >>> >>
> >>> >> --
> >>> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• −
> − •−
> >>> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
> >>>
> >>>
> >>> --
> >>> Arsen Arsenović
> >>
> >>
> >>
> >> --
> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − −
> •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
> >
> >
> >
> > --
> > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •−
> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
>
>
--
• − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •−
•/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
From db59c3e2e54744a490e146c208dd4013c5c581f5 Mon Sep 17 00:00:00 2001
From: "Paul M. Bendixen"
Date: Fri, 21 Jul 2023 23:35:25 +0200
Subject: [PATCH] libstdc++: Include cstdarg in freestanding
P1642 includes cstdarg in the full headers to include.
This commit includes it along with cstdaling andcstdbool that were
left out when updating in an earlier commit.
Signed-off-by: Paul M. Bendixen
libstdc++/Changelog
* include/Makefile.(in|am): move cstdarg, cstdalign and cstdbool
to freestanding
---
libstdc++-v3/include/Makefile.am | 6 +++---
libstdc++-v3/include/Makefile.in | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
index a880e8ee227..2a42ac04436 100644
--- a/libstdc++-v3/include/Makefile.am
+++ b/libstdc++-v3/include/Makefile.am
@@ -849,6 +849,9 @@ c_base_builddir = .
c_base_freestanding = \
${c_base_srcdir}/cfloat \
${c_base_srcdir}/climits \
+ ${c_base_srcdir}/cstdalign \
+ ${c_base_srcdir}/cstdarg \
+ ${c_base_srcdir}/cstdbool \
${c_base_srcdir}/cstddef \
${c_base_srcdir}/cstdint \
${c_base_srcdir}/cstdlib
@@ -869,9 +872,6 @@ c_base_headers = \
${c_base_srcdir}/cmath \
${c_base_srcdir}/csetjmp \
${c_base_srcdir}/csignal \
- ${c_base_srcdir}/cstdalign \
- ${c_base_srcdir}/cstdarg \
- ${c_base_srcdir}/cstdbool \
${c_base_srcdir}/cstdio \
${c_base_srcdir}/cstring \
${c_base_srcdir}/ctgmath \
diff
Re: [PATCH] libstdc++ Add cstdarg to freestanding
On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen wrote: > > Hi > Jonathan, I just went over the proposal again as well as [compliance], which > Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention either > or . Those headers were freestanding in C++17. They're not present in C++20 and C++23, but we support C++17 and earlier standards. In GCC 12 and were both installed when you built the library with --disable-hosted-libstdcxx, so the fact they're no longer installed for a freestanding build in GC 13 is a regression. Please do include them. > > Shouldn't I just stick to the ones we know are in? > > (Still working on figuring out how to do the change log thing) > > Best regards > Paul > > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen > : >> >> Yes, the other files are in another committee proposal, and I'm working my >> way through the proposals one by one. >> Thank you for the feedback, I'll update and resend >> /Paul >> >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović : >>> >>> >>> Jonathan Wakely writes: >>> >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >>> > wrote: >>> >> >>> >> P1642 includes the header cstdarg to the freestanding implementation. >>> >> This was probably left out by accident, this patch puts it in. >>> >> Since this is one of the headers that go in whole cloth, there should be >>> >> no >>> >> further actions needed. >>> > >>> > Thanks for the patch. I agree that should be freestanding, >>> > but I think and were also missed from the >>> > change. Arsen? >>> >>> Indeed, we should include all three, and according to [compliance], >>> there's a couple more headers that we should provide (cwchar, cstring, >>> cerrno, and cmath, but these are probably significantly more involved, >>> so we can handle them separately). >>> >>> As guessed, the omission was not intentional. >>> >>> If you could, add those two to the patch as well, edit Makefile.am and >>> regenerate using automake 1.15.1, and see >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >>> >>> Thank you! Have a lovely day :-) >>> >>> [compliance]: https://eel.is/c++draft/compliance >>> >>> > Also, the patch should change include/Makefile.am as well (the .in >>> > file is autogenerated from that one). >>> > >>> > >>> >> This might be related to PR106953, but since that one touches the partial >>> >> headers I'm not sure >>> >>> The headers mentioned in this PR are provided in freestanding, >>> partially, in 13 already, indeed. >>> >>> >> /Paul M. Bendixen >>> >> >>> >> -- >>> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− >>> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// >>> >>> >>> -- >>> Arsen Arsenović >> >> >> >> -- >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− >> − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− > − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
Re: [PATCH] libstdc++ Add cstdarg to freestanding
Hi Jonathan, I just went over the proposal again as well as [compliance], which Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention either or . Shouldn't I just stick to the ones we know are in? (Still working on figuring out how to do the change log thing) Best regards Paul Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen < paulbendi...@gmail.com>: > Yes, the other files are in another committee proposal, and I'm working my > way through the proposals one by one. > Thank you for the feedback, I'll update and resend > /Paul > > Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović : > >> >> Jonathan Wakely writes: >> >> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >> > wrote: >> >> >> >> P1642 includes the header cstdarg to the freestanding implementation. >> >> This was probably left out by accident, this patch puts it in. >> >> Since this is one of the headers that go in whole cloth, there should >> be no >> >> further actions needed. >> > >> > Thanks for the patch. I agree that should be freestanding, >> > but I think and were also missed from the >> > change. Arsen? >> >> Indeed, we should include all three, and according to [compliance], >> there's a couple more headers that we should provide (cwchar, cstring, >> cerrno, and cmath, but these are probably significantly more involved, >> so we can handle them separately). >> >> As guessed, the omission was not intentional. >> >> If you could, add those two to the patch as well, edit Makefile.am and >> regenerate using automake 1.15.1, and see >> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >> >> Thank you! Have a lovely day :-) >> >> [compliance]: https://eel.is/c++draft/compliance >> >> > Also, the patch should change include/Makefile.am as well (the .in >> > file is autogenerated from that one). >> > >> > >> >> This might be related to PR106953, but since that one touches the >> partial >> >> headers I'm not sure >> >> The headers mentioned in this PR are provided in freestanding, >> partially, in 13 already, indeed. >> >> >> /Paul M. Bendixen >> >> >> >> -- >> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − >> •− >> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// >> >> >> -- >> Arsen Arsenović >> > > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
Re: [PATCH] libstdc++ Add cstdarg to freestanding
Yes, the other files are in another committee proposal, and I'm working my way through the proposals one by one. Thank you for the feedback, I'll update and resend /Paul Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović : > > Jonathan Wakely writes: > > > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > > wrote: > >> > >> P1642 includes the header cstdarg to the freestanding implementation. > >> This was probably left out by accident, this patch puts it in. > >> Since this is one of the headers that go in whole cloth, there should > be no > >> further actions needed. > > > > Thanks for the patch. I agree that should be freestanding, > > but I think and were also missed from the > > change. Arsen? > > Indeed, we should include all three, and according to [compliance], > there's a couple more headers that we should provide (cwchar, cstring, > cerrno, and cmath, but these are probably significantly more involved, > so we can handle them separately). > > As guessed, the omission was not intentional. > > If you could, add those two to the patch as well, edit Makefile.am and > regenerate using automake 1.15.1, and see > https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. > > Thank you! Have a lovely day :-) > > [compliance]: https://eel.is/c++draft/compliance > > > Also, the patch should change include/Makefile.am as well (the .in > > file is autogenerated from that one). > > > > > >> This might be related to PR106953, but since that one touches the > partial > >> headers I'm not sure > > The headers mentioned in this PR are provided in freestanding, > partially, in 13 already, indeed. > > >> /Paul M. Bendixen > >> > >> -- > >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > -- > Arsen Arsenović > -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
Re: [PATCH] libstdc++ Add cstdarg to freestanding
Jonathan Wakely writes: > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > wrote: >> >> P1642 includes the header cstdarg to the freestanding implementation. >> This was probably left out by accident, this patch puts it in. >> Since this is one of the headers that go in whole cloth, there should be no >> further actions needed. > > Thanks for the patch. I agree that should be freestanding, > but I think and were also missed from the > change. Arsen? Indeed, we should include all three, and according to [compliance], there's a couple more headers that we should provide (cwchar, cstring, cerrno, and cmath, but these are probably significantly more involved, so we can handle them separately). As guessed, the omission was not intentional. If you could, add those two to the patch as well, edit Makefile.am and regenerate using automake 1.15.1, and see https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. Thank you! Have a lovely day :-) [compliance]: https://eel.is/c++draft/compliance > Also, the patch should change include/Makefile.am as well (the .in > file is autogenerated from that one). > > >> This might be related to PR106953, but since that one touches the partial >> headers I'm not sure The headers mentioned in this PR are provided in freestanding, partially, in 13 already, indeed. >> /Paul M. Bendixen >> >> -- >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// -- Arsen Arsenović signature.asc Description: PGP signature
Re: [PATCH] libstdc++ Add cstdarg to freestanding
On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ wrote: > > P1642 includes the header cstdarg to the freestanding implementation. > This was probably left out by accident, this patch puts it in. > Since this is one of the headers that go in whole cloth, there should be no > further actions needed. Thanks for the patch. I agree that should be freestanding, but I think and were also missed from the change. Arsen? Also, the patch should change include/Makefile.am as well (the .in file is autogenerated from that one). > This might be related to PR106953, but since that one touches the partial > headers I'm not sure > > /Paul M. Bendixen > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
[PATCH] libstdc++ Add cstdarg to freestanding
P1642 includes the header cstdarg to the freestanding implementation.
This was probably left out by accident, this patch puts it in.
Since this is one of the headers that go in whole cloth, there should be no
further actions needed.
This might be related to PR106953, but since that one touches the partial
headers I'm not sure
/Paul M. Bendixen
--
• − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •−
•/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
From 5584c194927678067e412aeb19f10b9662e398a6 Mon Sep 17 00:00:00 2001
From: "Paul M. Bendixen"
Date: Fri, 21 Jul 2023 22:04:23 +0200
Subject: [PATCH] libstdc++: Include cstdarg in freestanding
P1642 includes cstdarg in the full headers to include. Include it.
Signed-off-by: Paul M. Bendixen
---
libstdc++-v3/include/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in
index 0ff875b280b..f09f97e2f6b 100644
--- a/libstdc++-v3/include/Makefile.in
+++ b/libstdc++-v3/include/Makefile.in
@@ -1194,6 +1194,7 @@ c_base_builddir = .
c_base_freestanding = \
${c_base_srcdir}/cfloat \
${c_base_srcdir}/climits \
+ ${c_base_srcdir}/cstdarg \
${c_base_srcdir}/cstddef \
${c_base_srcdir}/cstdint \
${c_base_srcdir}/cstdlib
@@ -1213,7 +1214,6 @@ c_base_freestanding = \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csetjmp \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csignal \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdalign \
-@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdarg \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdbool \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdio \
@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstring \
--
2.34.1
