Re: [PATCH] rs6000: Remove useless code related to -mno-power10

[Kewen.Lin via Gcc-patches]

on 2022/1/11 上午8:26, David Edelsohn wrote:
> On Wed, Dec 29, 2021 at 4:37 AM Kewen.Lin  wrote:
>>
>> Hi,
>>
>> Option -mpower10 was made as "WarnRemoved" since commit r11-2318,
>> so -mno-power10 doesn't take effect any more.  This patch is to
>> remove one line useless code which still respects it.
>>
>> Bootstrapped and regtested on powerpc64le-linux-gnu P9 and
>> powerpc64-linux-gnu P8.
>>
>> Is it ok for trunk?
>>
>> BR,
>> Kewen
>> -
>> gcc/ChangeLog:
>>
>> * config/rs6000/rs6000.c (rs6000_disable_incompatible_switches): 
>> Remove
>> useless related to option -mno-power10.
>> ---
>>  gcc/config/rs6000/rs6000.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
>> index e82a47f4c0e..66b01e589b0 100644
>> --- a/gcc/config/rs6000/rs6000.c
>> +++ b/gcc/config/rs6000/rs6000.c
>> @@ -24825,7 +24825,6 @@ rs6000_disable_incompatible_switches (void)
>>  const HOST_WIDE_INT dep_flags; /* flags that depend on this option. 
>>  */
>>  const char *const name;/* name of the switch.  */
>>} flags[] = {
>> -{ OPTION_MASK_POWER10, OTHER_POWER10_MASKS,"power10"   },
>>  { OPTION_MASK_P9_VECTOR,   OTHER_P9_VECTOR_MASKS,  "power9-vector" },
>>  { OPTION_MASK_P8_VECTOR,   OTHER_P8_VECTOR_MASKS,  "power8-vector" },
>>  { OPTION_MASK_VSX, OTHER_VSX_VECTOR_MASKS, "vsx"   },
> 
> Okay.
> 
> Thanks, David
> 

Thanks!  Pushed via r12-6429.

BR,
Kewen

Re: [PATCH] rs6000: Remove useless code related to -mno-power10

[David Edelsohn via Gcc-patches]

On Wed, Dec 29, 2021 at 4:37 AM Kewen.Lin  wrote:
>
> Hi,
>
> Option -mpower10 was made as "WarnRemoved" since commit r11-2318,
> so -mno-power10 doesn't take effect any more.  This patch is to
> remove one line useless code which still respects it.
>
> Bootstrapped and regtested on powerpc64le-linux-gnu P9 and
> powerpc64-linux-gnu P8.
>
> Is it ok for trunk?
>
> BR,
> Kewen
> -
> gcc/ChangeLog:
>
> * config/rs6000/rs6000.c (rs6000_disable_incompatible_switches): 
> Remove
> useless related to option -mno-power10.
> ---
>  gcc/config/rs6000/rs6000.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
> index e82a47f4c0e..66b01e589b0 100644
> --- a/gcc/config/rs6000/rs6000.c
> +++ b/gcc/config/rs6000/rs6000.c
> @@ -24825,7 +24825,6 @@ rs6000_disable_incompatible_switches (void)
>  const HOST_WIDE_INT dep_flags; /* flags that depend on this option.  
> */
>  const char *const name;/* name of the switch.  */
>} flags[] = {
> -{ OPTION_MASK_POWER10, OTHER_POWER10_MASKS,"power10"   },
>  { OPTION_MASK_P9_VECTOR,   OTHER_P9_VECTOR_MASKS,  "power9-vector" },
>  { OPTION_MASK_P8_VECTOR,   OTHER_P8_VECTOR_MASKS,  "power8-vector" },
>  { OPTION_MASK_VSX, OTHER_VSX_VECTOR_MASKS, "vsx"   },

Okay.

Thanks, David

[PATCH] rs6000: Remove useless code related to -mno-power10

[Kewen.Lin via Gcc-patches]

Hi,

Option -mpower10 was made as "WarnRemoved" since commit r11-2318,
so -mno-power10 doesn't take effect any more.  This patch is to
remove one line useless code which still respects it.

Bootstrapped and regtested on powerpc64le-linux-gnu P9 and
powerpc64-linux-gnu P8.

Is it ok for trunk?

BR,
Kewen
-
gcc/ChangeLog:

* config/rs6000/rs6000.c (rs6000_disable_incompatible_switches): Remove
useless related to option -mno-power10.
---
 gcc/config/rs6000/rs6000.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index e82a47f4c0e..66b01e589b0 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -24825,7 +24825,6 @@ rs6000_disable_incompatible_switches (void)
 const HOST_WIDE_INT dep_flags; /* flags that depend on this option.  */
 const char *const name;/* name of the switch.  */
   } flags[] = {
-{ OPTION_MASK_POWER10, OTHER_POWER10_MASKS,"power10"   },
 { OPTION_MASK_P9_VECTOR,   OTHER_P9_VECTOR_MASKS,  "power9-vector" },
 { OPTION_MASK_P8_VECTOR,   OTHER_P8_VECTOR_MASKS,  "power8-vector" },
 { OPTION_MASK_VSX, OTHER_VSX_VECTOR_MASKS, "vsx"   },
--
2.27.0