Re: [PATCH] testsuite: Remove unwanted 'dg-do run' from gcc.dg/vect tests
Christophe Lyon via Gcc-patches writes:
> Tests under gcc.dg/vect use check_vect_support_and_set_flags to set
> compilation flags as appropriate for the target, but they also set
> dg-do-what-default to 'run' or 'compile', depending on the actual
> target hardware (or simulator) capabilities.
>
> For instance on arm, we use options to enable Neon, but set
> dg-do-what-default to 'run' only if we cam actually execute Neon
> instructions.
>
> Therefore, we would always try to link and execute tests containing
> 'dg-do run', although dg-do-what-default says otherwise, leading to
> uninteresting failures.
>
> Therefore, this patch removes all such unconditionnal 'dg-do run',
> thus avoid link errors for instance if GCC has been configured with
> multilibs disabled and some --with-{float|cpu|hard} option
> incompatible with what check_vect_support_and_set_flags selects.
>
> For exmaple, GCC configured with:
> --disable-multilib --with-mode=thumb --with-cpu=cortex-m7 --with-float=hard
> and check_vect_support_and_set_flags uses
> -mfpu=neon -mfloat-abi=softfp -march=armv7-a
> (thus incompatible float-abi options)
>
> Tested on native aarch64-linux-gnu (no change) and several arm-eabi
> cases where the FAIL/UNRESOLVED disappear (and we keep only the
> 'compilation' tests).
>
> 2023-09-04 Christophe Lyon
>
> gcc/testsuite/
> * gcc.dg/vect/bb-slp-44.c: Remove 'dg-do run'.
> * gcc.dg/vect/bb-slp-71.c: Likewise.
> * gcc.dg/vect/bb-slp-72.c: Likewise.
> * gcc.dg/vect/bb-slp-73.c: Likewise.
> * gcc.dg/vect/bb-slp-74.c: Likewise.
> * gcc.dg/vect/bb-slp-pr101207.c: Likewise.
> * gcc.dg/vect/bb-slp-pr101615-1.c: Likewise.
> * gcc.dg/vect/bb-slp-pr101615-2.c: Likewise.
> * gcc.dg/vect/bb-slp-pr101668.c: Likewise.
> * gcc.dg/vect/bb-slp-pr54400.c: Likewise.
> * gcc.dg/vect/bb-slp-pr98516-1.c: Likewise.
> * gcc.dg/vect/bb-slp-pr98516-2.c: Likewise.
> * gcc.dg/vect/bb-slp-pr98544.c: Likewise.
> * gcc.dg/vect/pr101445.c: Likewise.
> * gcc.dg/vect/pr105219.c: Likewise.
> * gcc.dg/vect/pr107160.c: Likewise.
> * gcc.dg/vect/pr107212-1.c: Likewise.
> * gcc.dg/vect/pr107212-2.c: Likewise.
> * gcc.dg/vect/pr109502.c: Likewise.
> * gcc.dg/vect/pr110381.c: Likewise.
> * gcc.dg/vect/pr110838.c: Likewise.
> * gcc.dg/vect/pr88497-1.c: Likewise.
> * gcc.dg/vect/pr88497-7.c: Likewise.
> * gcc.dg/vect/pr96783-1.c: Likewise.
> * gcc.dg/vect/pr96783-2.c: Likewise.
> * gcc.dg/vect/pr97558-2.c: Likewise.
> * gcc.dg/vect/pr99253.c: Likewise.
> * gcc.dg/vect/slp-mask-store-1.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-2.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
> * gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
> * gcc.dg/vect/vect-cond-13.c: Likewise.
> * gcc.dg/vect/vect-recurr-1.c: Likewise.
> * gcc.dg/vect/vect-recurr-2.c: Likewise.
> * gcc.dg/vect/vect-recurr-3.c: Likewise.
> * gcc.dg/vect/vect-recurr-4.c: Likewise.
> * gcc.dg/vect/vect-recurr-5.c: Likewise.
> * gcc.dg/vect/vect-recurr-6.c: Likewise.
OK, thanks.
Richard
> ---
> gcc/testsuite/gcc.dg/vect/bb-slp-44.c | 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-71.c | 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-72.c | 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-73.c | 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-74.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr101207.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr101615-1.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr101615-2.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr101668.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr54400.c | 1 -
> gcc/testsuite/gcc.dg/vect/bb-slp-pr98516-1.c| 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-pr98516-2.c| 2 --
> gcc/testsuite/gcc.dg/vect/bb-slp-pr98544.c | 2 --
> gcc/testsuite/gcc.dg/vect/pr101445.c| 2 --
> gcc/testsuite/gcc.dg/vect/pr105219.c| 1 -
> gcc/testsuite/gcc.dg/vect/pr107160.c| 2 --
> gcc/testsuite/gcc.dg/vect/pr107212-1.c | 2 --
> gcc/testsuite/gcc.dg/vect/pr107212-2.c | 2 --
> gcc/testsuite/gcc.dg/vect/pr109502.c| 1 -
> gcc/testsuite/gcc.dg/vect/pr110381.c| 1 -
> gcc/testsuite/gcc.dg/vect/pr110838.c| 2 --
> gcc/testsuite/gcc.dg/vect/pr88497-1.c | 1 -
> gcc/testsuite/gcc.dg/vect/pr88497-7.c | 1 -
> gcc/testsuite/gcc.dg/vect/pr96783-1.c | 2 --
> gcc/testsuite/gcc.dg/vect/pr96783-2.c | 2 --
> gcc/testsuite/gcc.dg/vect/pr
[PATCH] testsuite: Remove unwanted 'dg-do run' from gcc.dg/vect tests
Tests under gcc.dg/vect use check_vect_support_and_set_flags to set
compilation flags as appropriate for the target, but they also set
dg-do-what-default to 'run' or 'compile', depending on the actual
target hardware (or simulator) capabilities.
For instance on arm, we use options to enable Neon, but set
dg-do-what-default to 'run' only if we cam actually execute Neon
instructions.
Therefore, we would always try to link and execute tests containing
'dg-do run', although dg-do-what-default says otherwise, leading to
uninteresting failures.
Therefore, this patch removes all such unconditionnal 'dg-do run',
thus avoid link errors for instance if GCC has been configured with
multilibs disabled and some --with-{float|cpu|hard} option
incompatible with what check_vect_support_and_set_flags selects.
For exmaple, GCC configured with:
--disable-multilib --with-mode=thumb --with-cpu=cortex-m7 --with-float=hard
and check_vect_support_and_set_flags uses
-mfpu=neon -mfloat-abi=softfp -march=armv7-a
(thus incompatible float-abi options)
Tested on native aarch64-linux-gnu (no change) and several arm-eabi
cases where the FAIL/UNRESOLVED disappear (and we keep only the
'compilation' tests).
2023-09-04 Christophe Lyon
gcc/testsuite/
* gcc.dg/vect/bb-slp-44.c: Remove 'dg-do run'.
* gcc.dg/vect/bb-slp-71.c: Likewise.
* gcc.dg/vect/bb-slp-72.c: Likewise.
* gcc.dg/vect/bb-slp-73.c: Likewise.
* gcc.dg/vect/bb-slp-74.c: Likewise.
* gcc.dg/vect/bb-slp-pr101207.c: Likewise.
* gcc.dg/vect/bb-slp-pr101615-1.c: Likewise.
* gcc.dg/vect/bb-slp-pr101615-2.c: Likewise.
* gcc.dg/vect/bb-slp-pr101668.c: Likewise.
* gcc.dg/vect/bb-slp-pr54400.c: Likewise.
* gcc.dg/vect/bb-slp-pr98516-1.c: Likewise.
* gcc.dg/vect/bb-slp-pr98516-2.c: Likewise.
* gcc.dg/vect/bb-slp-pr98544.c: Likewise.
* gcc.dg/vect/pr101445.c: Likewise.
* gcc.dg/vect/pr105219.c: Likewise.
* gcc.dg/vect/pr107160.c: Likewise.
* gcc.dg/vect/pr107212-1.c: Likewise.
* gcc.dg/vect/pr107212-2.c: Likewise.
* gcc.dg/vect/pr109502.c: Likewise.
* gcc.dg/vect/pr110381.c: Likewise.
* gcc.dg/vect/pr110838.c: Likewise.
* gcc.dg/vect/pr88497-1.c: Likewise.
* gcc.dg/vect/pr88497-7.c: Likewise.
* gcc.dg/vect/pr96783-1.c: Likewise.
* gcc.dg/vect/pr96783-2.c: Likewise.
* gcc.dg/vect/pr97558-2.c: Likewise.
* gcc.dg/vect/pr99253.c: Likewise.
* gcc.dg/vect/slp-mask-store-1.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-10.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-11.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-2.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-3.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-4.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-5.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-6.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-8.c: Likewise.
* gcc.dg/vect/vect-bic-bitmask-9.c: Likewise.
* gcc.dg/vect/vect-cond-13.c: Likewise.
* gcc.dg/vect/vect-recurr-1.c: Likewise.
* gcc.dg/vect/vect-recurr-2.c: Likewise.
* gcc.dg/vect/vect-recurr-3.c: Likewise.
* gcc.dg/vect/vect-recurr-4.c: Likewise.
* gcc.dg/vect/vect-recurr-5.c: Likewise.
* gcc.dg/vect/vect-recurr-6.c: Likewise.
---
gcc/testsuite/gcc.dg/vect/bb-slp-44.c | 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-71.c | 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-72.c | 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-73.c | 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-74.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr101207.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr101615-1.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr101615-2.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr101668.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr54400.c | 1 -
gcc/testsuite/gcc.dg/vect/bb-slp-pr98516-1.c| 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-pr98516-2.c| 2 --
gcc/testsuite/gcc.dg/vect/bb-slp-pr98544.c | 2 --
gcc/testsuite/gcc.dg/vect/pr101445.c| 2 --
gcc/testsuite/gcc.dg/vect/pr105219.c| 1 -
gcc/testsuite/gcc.dg/vect/pr107160.c| 2 --
gcc/testsuite/gcc.dg/vect/pr107212-1.c | 2 --
gcc/testsuite/gcc.dg/vect/pr107212-2.c | 2 --
gcc/testsuite/gcc.dg/vect/pr109502.c| 1 -
gcc/testsuite/gcc.dg/vect/pr110381.c| 1 -
gcc/testsuite/gcc.dg/vect/pr110838.c| 2 --
gcc/testsuite/gcc.dg/vect/pr88497-1.c | 1 -
gcc/testsuite/gcc.dg/vect/pr88497-7.c | 1 -
gcc/testsuite/gcc.dg/vect/pr96783-1.c | 2 --
gcc/testsuite/gcc.dg/vect/pr96783-2.c | 2 --
gcc/testsuite/gcc.dg/vect/pr97558-2.c | 1 -
gcc/testsuite/gcc.dg/vect/pr99253.c | 2 --
gcc/testsuite/gcc.dg/vect/slp-mask-store-1.c| 1 -
gcc/testsuite/gcc.dg/vect/vect-bi
