Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
On 22/10/2023 13:24, Gerald Pfeifer wrote: Hi Andrew, On Fri, 20 Oct 2023, Andrew Stubbs wrote: Additionally, I wonder whether "Fiji" should be changed to "Fiji (gfx803)" in the first line and whether the "," should be removed in "The ... configuration ... , and no longer includes". Fair enough, how's this version? (I like the comma, even if it is optional.) it's definitely fine. I do have a recommendation and a question, though feel free to go about them as you prefer. + The default device architecture is now gfx900 (Vega). How about starting with this as the first sub-item, as a "positive", then follow with the deprecation? + + +The Fiji (gfx803) device support is now deprecated and will be removed from Could this be "Fiji (gfx803) device support" without the article? Thank you for your suggestions; I have committed the attached. Andrewgcc-14: mark amdgcn fiji deprecated diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index c817dde4..a20499e9 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -178,6 +178,21 @@ a work-in-progress. +AMD Radeon (GCN) + + + The default device architecture is now gfx900 (Vega). + +Fiji (gfx803) device support is now deprecated and will be removed from +a future release. The default compiler configuration no longer uses Fiji +as the default device, and no longer includes the Fiji libraries. Both can +be restored by configuring with +https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa;> + --with-arch=fiji +. + + +
Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
Hi Andrew, On Fri, 20 Oct 2023, Andrew Stubbs wrote: >> Additionally, I wonder whether "Fiji" should be changed to "Fiji >> (gfx803)" in the first line and whether the "," should be removed in >> "The ... configuration ... , and no longer includes". > Fair enough, how's this version? (I like the comma, even if it is optional.) it's definitely fine. I do have a recommendation and a question, though feel free to go about them as you prefer. + The default device architecture is now gfx900 (Vega). How about starting with this as the first sub-item, as a "positive", then follow with the deprecation? + + +The Fiji (gfx803) device support is now deprecated and will be removed from Could this be "Fiji (gfx803) device support" without the article? Gerald
Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
On 20.10.23 14:58, Andrew Stubbs wrote: Fair enough, how's this version? (I like the comma, even if it is optional.) LGTM – for what it is worth. Thanks! Tobias - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
On 19/10/2023 11:07, Tobias Burnus wrote: On 19.10.23 11:49, Andrew Stubbs wrote: OK to commit? (I think as maintainer you don't need approval - but of course comments by others can be helpful; I hope mine are. Additionally, Gerald (CCed) helps with keeping the webpages in good shape (thanks!).) gcc-14: mark amdgcn fiji deprecated diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index c817dde4..91ab8132 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -178,6 +178,16 @@ a work-in-progress. +AMD Radeon (GCN) + + + The Fiji device support is now deprecated and will be removed from a + future release. The default compiler configuration no longer uses Fiji + as the default device, and no longer includes the Fiji libraries. Both + can be restored by configuring with --with-arch=fiji. + The default device architecture is now gfx900 (Vega). + Can you add ... around the "--with-arch=fiji"? Linking to https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa I think that page is helpful (once the cron job has updated that page). Additionally, I wonder whether "Fiji" should be changed to "Fiji (gfx803)" in the first line and whether the "," should be removed in "The ... configuration ... , and no longer includes". Fair enough, how's this version? (I like the comma, even if it is optional.) Andrewgcc-14: mark amdgcn fiji deprecated diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index c817dde4..23694310 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -178,6 +178,21 @@ a work-in-progress. +AMD Radeon (GCN) + + + +The Fiji (gfx803) device support is now deprecated and will be removed from +a future release. The default compiler configuration no longer uses Fiji +as the default device, and no longer includes the Fiji libraries. Both can +be restored by configuring with +https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa;> + --with-arch=fiji +. + + The default device architecture is now gfx900 (Vega). + +
Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
On 19.10.23 11:49, Andrew Stubbs wrote: OK to commit? (I think as maintainer you don't need approval - but of course comments by others can be helpful; I hope mine are. Additionally, Gerald (CCed) helps with keeping the webpages in good shape (thanks!).) gcc-14: mark amdgcn fiji deprecated diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index c817dde4..91ab8132 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -178,6 +178,16 @@ a work-in-progress. +AMD Radeon (GCN) + + + The Fiji device support is now deprecated and will be removed from a + future release. The default compiler configuration no longer uses Fiji + as the default device, and no longer includes the Fiji libraries. Both + can be restored by configuring with --with-arch=fiji. + The default device architecture is now gfx900 (Vega). + Can you add ... around the "--with-arch=fiji"? Linking to https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa I think that page is helpful (once the cron job has updated that page). Additionally, I wonder whether "Fiji" should be changed to "Fiji (gfx803)" in the first line and whether the "," should be removed in "The ... configuration ... , and no longer includes". Thanks, Tobias + - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
[PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
OK to commit? Andrewgcc-14: mark amdgcn fiji deprecated diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index c817dde4..91ab8132 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -178,6 +178,16 @@ a work-in-progress. +AMD Radeon (GCN) + + + The Fiji device support is now deprecated and will be removed from a + future release. The default compiler configuration no longer uses Fiji + as the default device, and no longer includes the Fiji libraries. Both + can be restored by configuring with --with-arch=fiji. + The default device architecture is now gfx900 (Vega). + +
