Re: [PATCH 14/14] gcc: use _P() defines from tree.h

[Richard Biener via Gcc-patches]

On Sun, May 14, 2023 at 1:32 AM Bernhard Reutner-Fischer via
Gcc-patches  wrote:
>
> From: Bernhard Reutner-Fischer 
>
> gcc/ChangeLog:

This piece looks OK to me.

> * alias.cc (ref_all_alias_ptr_type_p): Use _P() defines from tree.h.
> * attribs.cc (diag_attr_exclusions): Ditto.
> (decl_attributes): Ditto.
> (build_type_attribute_qual_variant): Ditto.
> * builtins.cc (fold_builtin_carg): Ditto.
> (fold_builtin_next_arg): Ditto.
> (do_mpc_arg2): Ditto.
> * cfgexpand.cc (expand_return): Ditto.
> * cgraph.h (decl_in_symtab_p): Ditto.
> (symtab_node::get_create): Ditto.
> * dwarf2out.cc (base_type_die): Ditto.
> (implicit_ptr_descriptor): Ditto.
> (gen_array_type_die): Ditto.
> (gen_type_die_with_usage): Ditto.
> (optimize_location_into_implicit_ptr): Ditto.
> * expr.cc (do_store_flag): Ditto.
> * fold-const.cc (negate_expr_p): Ditto.
> (fold_negate_expr_1): Ditto.
> (fold_convert_const): Ditto.
> (fold_convert_loc): Ditto.
> (constant_boolean_node): Ditto.
> (fold_binary_op_with_conditional_arg): Ditto.
> (build_fold_addr_expr_with_type_loc): Ditto.
> (fold_comparison): Ditto.
> (fold_checksum_tree): Ditto.
> (tree_unary_nonnegative_warnv_p): Ditto.
> (integer_valued_real_unary_p): Ditto.
> (fold_read_from_constant_string): Ditto.
> * gcc-rich-location.cc 
> (maybe_range_label_for_tree_type_mismatch::get_text): Ditto.
> * gimple-expr.cc (useless_type_conversion_p): Ditto.
> (is_gimple_reg): Ditto.
> (is_gimple_asm_val): Ditto.
> (mark_addressable): Ditto.
> * gimple-expr.h (is_gimple_variable): Ditto.
> (virtual_operand_p): Ditto.
> * gimple-ssa-warn-access.cc (pass_waccess::check_dangling_stores): 
> Ditto.
> * gimplify.cc (gimplify_bind_expr): Ditto.
> (gimplify_return_expr): Ditto.
> (gimple_add_padding_init_for_auto_var): Ditto.
> (gimplify_addr_expr): Ditto.
> (omp_add_variable): Ditto.
> (omp_notice_variable): Ditto.
> (omp_get_base_pointer): Ditto.
> (omp_strip_components_and_deref): Ditto.
> (omp_strip_indirections): Ditto.
> (omp_accumulate_sibling_list): Ditto.
> (omp_build_struct_sibling_lists): Ditto.
> (gimplify_adjust_omp_clauses_1): Ditto.
> (gimplify_adjust_omp_clauses): Ditto.
> (gimplify_omp_for): Ditto.
> (goa_lhs_expr_p): Ditto.
> (gimplify_one_sizepos): Ditto.
> * graphite-scop-detection.cc 
> (scop_detection::graphite_can_represent_scev): Ditto.
> * ipa-devirt.cc (odr_types_equivalent_p): Ditto.
> * ipa-prop.cc (ipa_set_jf_constant): Ditto.
> (propagate_controlled_uses): Ditto.
> * ipa-sra.cc (type_prevails_p): Ditto.
> (scan_expr_access): Ditto.
> * optabs-tree.cc (optab_for_tree_code): Ditto.
> * toplev.cc (wrapup_global_declaration_1): Ditto.
> * trans-mem.cc (transaction_invariant_address_p): Ditto.
> * tree-cfg.cc (verify_types_in_gimple_reference): Ditto.
> (verify_gimple_comparison): Ditto.
> (verify_gimple_assign_binary): Ditto.
> (verify_gimple_assign_single): Ditto.
> * tree-complex.cc (get_component_ssa_name): Ditto.
> * tree-emutls.cc (lower_emutls_2): Ditto.
> * tree-inline.cc (copy_tree_body_r): Ditto.
> (estimate_move_cost): Ditto.
> (copy_decl_for_dup_finish): Ditto.
> * tree-nested.cc (convert_nonlocal_omp_clauses): Ditto.
> (note_nonlocal_vla_type): Ditto.
> (convert_local_omp_clauses): Ditto.
> (remap_vla_decls): Ditto.
> (fixup_vla_decls): Ditto.
> * tree-parloops.cc (loop_has_vector_phi_nodes): Ditto.
> * tree-pretty-print.cc (print_declaration): Ditto.
> (print_call_name): Ditto.
> * tree-sra.cc (compare_access_positions): Ditto.
> * tree-ssa-alias.cc (compare_type_sizes): Ditto.
> * tree-ssa-ccp.cc (get_default_value): Ditto.
> * tree-ssa-coalesce.cc (populate_coalesce_list_for_outofssa): Ditto.
> * tree-ssa-dom.cc (reduce_vector_comparison_to_scalar_comparison): 
> Ditto.
> * tree-ssa-forwprop.cc (can_propagate_from): Ditto.
> * tree-ssa-propagate.cc (may_propagate_copy): Ditto.
> * tree-ssa-sccvn.cc (fully_constant_vn_reference_p): Ditto.
> * tree-ssa-sink.cc (statement_sink_location): Ditto.
> * tree-ssa-structalias.cc (type_must_have_pointers): Ditto.
> * tree-ssa-ter.cc (find_replaceable_in_bb): Ditto.
> * tree-ssa-uninit.cc (warn_uninit): Ditto.
> * tree-ssa.cc (maybe_rewrite_mem_ref_base): Ditto.
> (non_rewritable_mem_ref_base): Ditto.
> * tree-streamer-in.cc (lto_input_ts_type_non_common_tree_pointers): 
> Ditto.
> * 

[PATCH 14/14] gcc: use _P() defines from tree.h

[Bernhard Reutner-Fischer via Gcc-patches]

From: Bernhard Reutner-Fischer 

gcc/ChangeLog:

* alias.cc (ref_all_alias_ptr_type_p): Use _P() defines from tree.h.
* attribs.cc (diag_attr_exclusions): Ditto.
(decl_attributes): Ditto.
(build_type_attribute_qual_variant): Ditto.
* builtins.cc (fold_builtin_carg): Ditto.
(fold_builtin_next_arg): Ditto.
(do_mpc_arg2): Ditto.
* cfgexpand.cc (expand_return): Ditto.
* cgraph.h (decl_in_symtab_p): Ditto.
(symtab_node::get_create): Ditto.
* dwarf2out.cc (base_type_die): Ditto.
(implicit_ptr_descriptor): Ditto.
(gen_array_type_die): Ditto.
(gen_type_die_with_usage): Ditto.
(optimize_location_into_implicit_ptr): Ditto.
* expr.cc (do_store_flag): Ditto.
* fold-const.cc (negate_expr_p): Ditto.
(fold_negate_expr_1): Ditto.
(fold_convert_const): Ditto.
(fold_convert_loc): Ditto.
(constant_boolean_node): Ditto.
(fold_binary_op_with_conditional_arg): Ditto.
(build_fold_addr_expr_with_type_loc): Ditto.
(fold_comparison): Ditto.
(fold_checksum_tree): Ditto.
(tree_unary_nonnegative_warnv_p): Ditto.
(integer_valued_real_unary_p): Ditto.
(fold_read_from_constant_string): Ditto.
* gcc-rich-location.cc 
(maybe_range_label_for_tree_type_mismatch::get_text): Ditto.
* gimple-expr.cc (useless_type_conversion_p): Ditto.
(is_gimple_reg): Ditto.
(is_gimple_asm_val): Ditto.
(mark_addressable): Ditto.
* gimple-expr.h (is_gimple_variable): Ditto.
(virtual_operand_p): Ditto.
* gimple-ssa-warn-access.cc (pass_waccess::check_dangling_stores): 
Ditto.
* gimplify.cc (gimplify_bind_expr): Ditto.
(gimplify_return_expr): Ditto.
(gimple_add_padding_init_for_auto_var): Ditto.
(gimplify_addr_expr): Ditto.
(omp_add_variable): Ditto.
(omp_notice_variable): Ditto.
(omp_get_base_pointer): Ditto.
(omp_strip_components_and_deref): Ditto.
(omp_strip_indirections): Ditto.
(omp_accumulate_sibling_list): Ditto.
(omp_build_struct_sibling_lists): Ditto.
(gimplify_adjust_omp_clauses_1): Ditto.
(gimplify_adjust_omp_clauses): Ditto.
(gimplify_omp_for): Ditto.
(goa_lhs_expr_p): Ditto.
(gimplify_one_sizepos): Ditto.
* graphite-scop-detection.cc 
(scop_detection::graphite_can_represent_scev): Ditto.
* ipa-devirt.cc (odr_types_equivalent_p): Ditto.
* ipa-prop.cc (ipa_set_jf_constant): Ditto.
(propagate_controlled_uses): Ditto.
* ipa-sra.cc (type_prevails_p): Ditto.
(scan_expr_access): Ditto.
* optabs-tree.cc (optab_for_tree_code): Ditto.
* toplev.cc (wrapup_global_declaration_1): Ditto.
* trans-mem.cc (transaction_invariant_address_p): Ditto.
* tree-cfg.cc (verify_types_in_gimple_reference): Ditto.
(verify_gimple_comparison): Ditto.
(verify_gimple_assign_binary): Ditto.
(verify_gimple_assign_single): Ditto.
* tree-complex.cc (get_component_ssa_name): Ditto.
* tree-emutls.cc (lower_emutls_2): Ditto.
* tree-inline.cc (copy_tree_body_r): Ditto.
(estimate_move_cost): Ditto.
(copy_decl_for_dup_finish): Ditto.
* tree-nested.cc (convert_nonlocal_omp_clauses): Ditto.
(note_nonlocal_vla_type): Ditto.
(convert_local_omp_clauses): Ditto.
(remap_vla_decls): Ditto.
(fixup_vla_decls): Ditto.
* tree-parloops.cc (loop_has_vector_phi_nodes): Ditto.
* tree-pretty-print.cc (print_declaration): Ditto.
(print_call_name): Ditto.
* tree-sra.cc (compare_access_positions): Ditto.
* tree-ssa-alias.cc (compare_type_sizes): Ditto.
* tree-ssa-ccp.cc (get_default_value): Ditto.
* tree-ssa-coalesce.cc (populate_coalesce_list_for_outofssa): Ditto.
* tree-ssa-dom.cc (reduce_vector_comparison_to_scalar_comparison): 
Ditto.
* tree-ssa-forwprop.cc (can_propagate_from): Ditto.
* tree-ssa-propagate.cc (may_propagate_copy): Ditto.
* tree-ssa-sccvn.cc (fully_constant_vn_reference_p): Ditto.
* tree-ssa-sink.cc (statement_sink_location): Ditto.
* tree-ssa-structalias.cc (type_must_have_pointers): Ditto.
* tree-ssa-ter.cc (find_replaceable_in_bb): Ditto.
* tree-ssa-uninit.cc (warn_uninit): Ditto.
* tree-ssa.cc (maybe_rewrite_mem_ref_base): Ditto.
(non_rewritable_mem_ref_base): Ditto.
* tree-streamer-in.cc (lto_input_ts_type_non_common_tree_pointers): 
Ditto.
* tree-streamer-out.cc (write_ts_type_non_common_tree_pointers): Ditto.
* tree-vect-generic.cc (do_binop): Ditto.
(do_cond): Ditto.
* tree-vect-stmts.cc (vect_init_vector): Ditto.
* tree-vector-builder.h (tree_vector_builder::note_representative): 
Ditto.
* tree.cc (sign_mask