Re: [PATCH 2/2] Add test cases for noreorder
From: Andi Kleen a...@linux.intel.com
Add some simple test cases for noreorder behaving like
-fno-toplevel-reorder and -fno-toplevel-reorder still working.
Unfortunately there's no easy way to check for output order in DG,
so we just check for existence.
OK, thanks!
Honza
gcc/testsuite/:
2014-09-15 Andi Kleen a...@linux.intel.com
* gcc.dg/noreorder.c: New test.
* gcc.dg/noreorder2.c: New test.
* gcc.dg/noreorder3.c: New test.
* gcc.dg/noreorder4.c: New test.
---
gcc/testsuite/gcc.dg/noreorder.c | 38 ++
gcc/testsuite/gcc.dg/noreorder2.c | 11 +++
gcc/testsuite/gcc.dg/noreorder3.c | 10 ++
gcc/testsuite/gcc.dg/noreorder4.c | 5 +
4 files changed, 64 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/noreorder.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder2.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder3.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder4.c
diff --git a/gcc/testsuite/gcc.dg/noreorder.c
b/gcc/testsuite/gcc.dg/noreorder.c
new file mode 100644
index 000..7d40a29
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder.c
@@ -0,0 +1,38 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+/* The function order in this file is opposite from what the cgraph
+ topological sort would output. So we can check the order is preserved. */
+
+extern void f2(int);
+static int func2(void);
+
+#ifndef NOREORDER
+#define NOREORDER __attribute__((no_reorder))
+#endif
+
+asm(firstasm);
+
+NOREORDER __attribute__((noinline)) int bozo(void)
+{
+ f2(3);
+ func2();
+}
+
+asm(jukjuk);
+
+NOREORDER __attribute__((noinline)) static int func1(void)
+{
+ f2(1);
+}
+
+asm(barbar);
+
+NOREORDER __attribute__((noinline)) static int func2(void)
+{
+ func1();
+}
+
+asm(lastasm);
+
+/* { dg-final { scan-assembler
firstasm.*bozo.*jukjuk.*func1.*barbar.*func2.*lastasm } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder2.c
b/gcc/testsuite/gcc.dg/noreorder2.c
new file mode 100644
index 000..558361b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder2.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options -O2 -fno-toplevel-reorder } */
+
+__attribute__((no_reorder)) int foobar;
+
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder3.c
b/gcc/testsuite/gcc.dg/noreorder3.c
new file mode 100644
index 000..a0b637f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder3.c
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+__attribute__((no_reorder)) int foobar;
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler-not barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder4.c
b/gcc/testsuite/gcc.dg/noreorder4.c
new file mode 100644
index 000..632fc33
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder4.c
@@ -0,0 +1,5 @@
+/* { dg-do compile } */
+/* { dg-options -O2 -fno-toplevel-reorder } */
+#define NOREORDER
+#include noreorder.c
+/* { dg-final { scan-assembler bozo.*jukjuk.*func1.*barbar.*func2 } } */
--
2.1.0
[PATCH 2/2] Add test cases for noreorder
From: Andi Kleen a...@linux.intel.com
Add some simple test cases for noreorder behaving like
-fno-toplevel-reorder and -fno-toplevel-reorder still working.
Unfortunately there's no easy way to check for output order in DG,
so we just check for existence.
gcc/testsuite/:
2014-09-15 Andi Kleen a...@linux.intel.com
* gcc.dg/noreorder.c: New test.
* gcc.dg/noreorder2.c: New test.
* gcc.dg/noreorder3.c: New test.
* gcc.dg/noreorder4.c: New test.
---
gcc/testsuite/gcc.dg/noreorder.c | 38 ++
gcc/testsuite/gcc.dg/noreorder2.c | 11 +++
gcc/testsuite/gcc.dg/noreorder3.c | 10 ++
gcc/testsuite/gcc.dg/noreorder4.c | 5 +
4 files changed, 64 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/noreorder.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder2.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder3.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder4.c
diff --git a/gcc/testsuite/gcc.dg/noreorder.c b/gcc/testsuite/gcc.dg/noreorder.c
new file mode 100644
index 000..7d40a29
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder.c
@@ -0,0 +1,38 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+/* The function order in this file is opposite from what the cgraph
+ topological sort would output. So we can check the order is preserved. */
+
+extern void f2(int);
+static int func2(void);
+
+#ifndef NOREORDER
+#define NOREORDER __attribute__((no_reorder))
+#endif
+
+asm(firstasm);
+
+NOREORDER __attribute__((noinline)) int bozo(void)
+{
+ f2(3);
+ func2();
+}
+
+asm(jukjuk);
+
+NOREORDER __attribute__((noinline)) static int func1(void)
+{
+ f2(1);
+}
+
+asm(barbar);
+
+NOREORDER __attribute__((noinline)) static int func2(void)
+{
+ func1();
+}
+
+asm(lastasm);
+
+/* { dg-final { scan-assembler
firstasm.*bozo.*jukjuk.*func1.*barbar.*func2.*lastasm } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder2.c
b/gcc/testsuite/gcc.dg/noreorder2.c
new file mode 100644
index 000..558361b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder2.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options -O2 -fno-toplevel-reorder } */
+
+__attribute__((no_reorder)) int foobar;
+
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder3.c
b/gcc/testsuite/gcc.dg/noreorder3.c
new file mode 100644
index 000..a0b637f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder3.c
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+__attribute__((no_reorder)) int foobar;
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler-not barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder4.c
b/gcc/testsuite/gcc.dg/noreorder4.c
new file mode 100644
index 000..632fc33
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder4.c
@@ -0,0 +1,5 @@
+/* { dg-do compile } */
+/* { dg-options -O2 -fno-toplevel-reorder } */
+#define NOREORDER
+#include noreorder.c
+/* { dg-final { scan-assembler bozo.*jukjuk.*func1.*barbar.*func2 } } */
--
2.1.0
[PATCH 2/2] Add test cases for noreorder
From: Andi Kleen a...@linux.intel.com
Add some simple test cases for noreorder behaving like
-fno-toplevel-reorder and -fno-toplevel-reorder still working.
Unfortunately there's no easy way to check for output order in DG,
so we just check for existence.
gcc/testsuite/:
2014-09-14 Andi Kleen a...@linux.intel.com
* gcc.dg/noreorder.c: New test.
* gcc.dg/noreorder2.c: New test.
* gcc.dg/noreorder3.c: New test.
---
gcc/testsuite/gcc.dg/noreorder.c | 24
gcc/testsuite/gcc.dg/noreorder2.c | 11 +++
gcc/testsuite/gcc.dg/noreorder3.c | 10 ++
3 files changed, 45 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/noreorder.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder2.c
create mode 100644 gcc/testsuite/gcc.dg/noreorder3.c
diff --git a/gcc/testsuite/gcc.dg/noreorder.c b/gcc/testsuite/gcc.dg/noreorder.c
new file mode 100644
index 000..1559465
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder.c
@@ -0,0 +1,24 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+extern void f2(int);
+
+__attribute__((no_reorder, noinline)) static int foobar(void)
+{
+ f2(1);
+}
+
+static int barbar(void)
+{
+ f2(2);
+}
+
+int bozo(void)
+{
+ f2(3);
+ foobar();
+}
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler-not barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder2.c
b/gcc/testsuite/gcc.dg/noreorder2.c
new file mode 100644
index 000..558361b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder2.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options -O2 -fno-toplevel-reorder } */
+
+__attribute__((no_reorder)) int foobar;
+
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler barbar } } */
diff --git a/gcc/testsuite/gcc.dg/noreorder3.c
b/gcc/testsuite/gcc.dg/noreorder3.c
new file mode 100644
index 000..a0b637f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/noreorder3.c
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+/* { dg-options -O2 } */
+
+__attribute__((no_reorder)) int foobar;
+static int barbar;
+int bozo;
+
+/* { dg-final { scan-assembler foobar } } */
+/* { dg-final { scan-assembler bozo } } */
+/* { dg-final { scan-assembler-not barbar } } */
--
2.1.0
Re: [PATCH 2/2] Add test cases for noreorder
On Sep 14, 2014, at 10:51 AM, Andi Kleen a...@firstfloor.org wrote:
From: Andi Kleen a...@linux.intel.com
Add some simple test cases for noreorder behaving like
-fno-toplevel-reorder and -fno-toplevel-reorder still working.
Unfortunately there's no easy way to check for output order in DG,
so we just check for existence.
I thought some of these would span lines…. foo.*bar could check foo on a line
before bar?
/* { dg-final { scan-assembler section.*foo } } */
int foo (int a)
{
static const int ar[] = { l1 - l1, l2 - l1 };
void *p = l1 + ar[a];
goto *p;
l1:
return 1;
l2:
return 2;
}
Yup, works just fine. Some might say it isn’t a feature, but we have no plans
to fix it.
