[PATCH 3/13] aarch64 musl support
Set up dynamic linker name for aarch64. gcc/Changelog: 2015-04-16 Gregor Richards Szabolcs Nagy * config/aarch64/aarch64-linux.h (MUSL_DYNAMIC_LINKER): Define. diff --git a/gcc/config/aarch64/aarch64-linux.h b/gcc/config/aarch64/aarch64-linux.h index 9abb252..5ff83dd 100644 --- a/gcc/config/aarch64/aarch64-linux.h +++ b/gcc/config/aarch64/aarch64-linux.h @@ -23,6 +23,14 @@ #define GLIBC_DYNAMIC_LINKER "/lib/ld-linux-aarch64%{mbig-endian:_be}%{mabi=ilp32:_ilp32}.so.1" +#if TARGET_BIG_ENDIAN_DEFAULT +#define MUSL_DYNAMIC_LINKER_E "%{mlittle-endian:;:_be}" +#else +#define MUSL_DYNAMIC_LINKER_E "%{mbig-endian:_be}" +#endif +#define MUSL_DYNAMIC_LINKER \ + "/lib/ld-musl-aarch64" MUSL_DYNAMIC_LINKER_E ".so.1" + #undef ASAN_CC1_SPEC #define ASAN_CC1_SPEC "%{%:sanitize(address):-funwind-tables}"
Re: [PATCH 3/13] aarch64 musl support
> On Apr 20, 2015, at 11:52 AM, Szabolcs Nagy wrote: > > Set up dynamic linker name for aarch64. > > gcc/Changelog: > > 2015-04-16 Gregor Richards >Szabolcs Nagy > >* config/aarch64/aarch64-linux.h (MUSL_DYNAMIC_LINKER): Define. I don't think you need to check if defaulting to little or big-endian here are the specs always have one or the other passing through. Also if musl does not support ilp32, you might want to error out. Or even define the dynamic linker name even before support goes into musl. Thanks, Andrew > <03-aarch64.patch>
Re: [PATCH 3/13] aarch64 musl support
On 21/04/15 15:16, pins...@gmail.com wrote: > > I don't think you need to check if defaulting to little or big-endian here > are the specs always have one or the other passing through. > i was not aware of this may be the ifdef is not necessary for other archs either i will check > Also if musl does not support ilp32, you might want to error out. Or even > define the dynamic linker name even before support goes into musl. > ok, i guess adding %{mabi=ilp32:_ilp32} won't hurt us
Re: [PATCH 3/13] aarch64 musl support
On 21/04/15 15:16, pins...@gmail.com wrote: > > I don't think you need to check if defaulting to little or big-endian here > are the specs always have one or the other passing through. > > Also if musl does not support ilp32, you might want to error out. Or even > define the dynamic linker name even before support goes into musl. > Patch v2. (now _ilp32 abi variant is included too) gcc/Changelog: 2015-04-27 Gregor Richards Szabolcs Nagy * config/aarch64/aarch64-linux.h (MUSL_DYNAMIC_LINKER): Define. diff --git a/gcc/config/aarch64/aarch64-linux.h b/gcc/config/aarch64/aarch64-linux.h index 9abb252..2d647c3 100644 --- a/gcc/config/aarch64/aarch64-linux.h +++ b/gcc/config/aarch64/aarch64-linux.h @@ -23,6 +23,9 @@ #define GLIBC_DYNAMIC_LINKER "/lib/ld-linux-aarch64%{mbig-endian:_be}%{mabi=ilp32:_ilp32}.so.1" +#undef MUSL_DYNAMIC_LINKER +#define MUSL_DYNAMIC_LINKER "/lib/ld-musl-aarch64%{mbig-endian:_be}%{mabi=ilp32:_ilp32}.so.1" + #undef ASAN_CC1_SPEC #define ASAN_CC1_SPEC "%{%:sanitize(address):-funwind-tables}"
Re: [PATCH 3/13] aarch64 musl support
On 27/04/15 15:33, Szabolcs Nagy wrote: > > On 21/04/15 15:16, pins...@gmail.com wrote: >> >> I don't think you need to check if defaulting to little or big-endian here >> are the specs always have one or the other passing through. >> >> Also if musl does not support ilp32, you might want to error out. Or even >> define the dynamic linker name even before support goes into musl. >> > > Patch v2. > > (now _ilp32 abi variant is included too) > ping (now with maintainer in cc) > gcc/Changelog: > > 2015-04-27 Gregor Richards > Szabolcs Nagy > > * config/aarch64/aarch64-linux.h (MUSL_DYNAMIC_LINKER): Define. >
Re: [PATCH 3/13] aarch64 musl support
On Mon, Apr 27, 2015 at 03:33:05PM +0100, Szabolcs Nagy wrote: > > On 21/04/15 15:16, pins...@gmail.com wrote: > > > > I don't think you need to check if defaulting to little or big-endian here > > are the specs always have one or the other passing through. > > > > Also if musl does not support ilp32, you might want to error out. Or even > > define the dynamic linker name even before support goes into musl. > > > > Patch v2. > > (now _ilp32 abi variant is included too) > > gcc/Changelog: > > 2015-04-27 Gregor Richards > Szabolcs Nagy > > * config/aarch64/aarch64-linux.h (MUSL_DYNAMIC_LINKER): Define. OK, I've committed this on your behalf as revision 223766. Thanks, James > diff --git a/gcc/config/aarch64/aarch64-linux.h > b/gcc/config/aarch64/aarch64-linux.h > index 9abb252..2d647c3 100644 > --- a/gcc/config/aarch64/aarch64-linux.h > +++ b/gcc/config/aarch64/aarch64-linux.h > @@ -23,6 +23,9 @@ > > #define GLIBC_DYNAMIC_LINKER > "/lib/ld-linux-aarch64%{mbig-endian:_be}%{mabi=ilp32:_ilp32}.so.1" > > +#undef MUSL_DYNAMIC_LINKER > +#define MUSL_DYNAMIC_LINKER > "/lib/ld-musl-aarch64%{mbig-endian:_be}%{mabi=ilp32:_ilp32}.so.1" > + > #undef ASAN_CC1_SPEC > #define ASAN_CC1_SPEC "%{%:sanitize(address):-funwind-tables}" >