Re: [PATCH 3/4] testsuite: Relax pattern to include "packed" targets

2020-07-20 Thread Richard Sandiford
Dimitar Dimitrov  writes:
> The actual warning message depends on the default alignment of the
> target. With this update the test correctly passes on AVR and PRU
> targets.
>
> gcc/testsuite/ChangeLog:
>
>   * gcc.dg/pr53037-1.c: Relax warning pattern.
>
> Signed-off-by: Dimitar Dimitrov 
> ---
>  gcc/testsuite/gcc.dg/pr53037-1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.dg/pr53037-1.c 
> b/gcc/testsuite/gcc.dg/pr53037-1.c
> index 3ea5ae6a34e..b4e9049c746 100644
> --- a/gcc/testsuite/gcc.dg/pr53037-1.c
> +++ b/gcc/testsuite/gcc.dg/pr53037-1.c
> @@ -40,7 +40,7 @@ struct foo5
>  {
>int i1;
>int x __attribute__((warn_if_not_aligned(16))); /* { dg-warning "'x' 
> offset 4 in 'struct foo5' isn't aligned to 16" } */
> -}; /* { dg-warning "alignment 4 of 'struct foo5' is less than 16" } */
> +}; /* { dg-warning "alignment .* of 'struct foo5' is less than 16" } */
>  
>  struct foo6
>  {
> @@ -73,7 +73,7 @@ union bar3
>  {
>int i1;
>int x __attribute__((warn_if_not_aligned(16))); 
> -}; /* { dg-warning "alignment 4 of 'union bar3' is less than 16" } */
> +}; /* { dg-warning "alignment .* of 'union bar3' is less than 16" } */

Better to use [0-9]+, and change the quoting to {…} rather than "…"
so that there's no need to add backslashes for the [ and ].

OK with that change, thanks.

Richard


[PATCH 3/4] testsuite: Relax pattern to include "packed" targets

2020-07-20 Thread Dimitar Dimitrov
The actual warning message depends on the default alignment of the
target. With this update the test correctly passes on AVR and PRU
targets.

gcc/testsuite/ChangeLog:

* gcc.dg/pr53037-1.c: Relax warning pattern.

Signed-off-by: Dimitar Dimitrov 
---
 gcc/testsuite/gcc.dg/pr53037-1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/pr53037-1.c b/gcc/testsuite/gcc.dg/pr53037-1.c
index 3ea5ae6a34e..b4e9049c746 100644
--- a/gcc/testsuite/gcc.dg/pr53037-1.c
+++ b/gcc/testsuite/gcc.dg/pr53037-1.c
@@ -40,7 +40,7 @@ struct foo5
 {
   int i1;
   int x __attribute__((warn_if_not_aligned(16))); /* { dg-warning "'x' offset 
4 in 'struct foo5' isn't aligned to 16" } */
-}; /* { dg-warning "alignment 4 of 'struct foo5' is less than 16" } */
+}; /* { dg-warning "alignment .* of 'struct foo5' is less than 16" } */
 
 struct foo6
 {
@@ -73,7 +73,7 @@ union bar3
 {
   int i1;
   int x __attribute__((warn_if_not_aligned(16))); 
-}; /* { dg-warning "alignment 4 of 'union bar3' is less than 16" } */
+}; /* { dg-warning "alignment .* of 'union bar3' is less than 16" } */
 
 union bar4
 {
-- 
2.20.1