Re: closing PR's (was Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support)
Hi Hans-Peter, Sorry if I misinterpret, but it seems a reminder is in order: magic powers are attached to whome...@gcc.gnu.org accounts in bugzilla, so when people use them instead of their whome...@employer.example.com, they are able to close PR's they haven't created. Ah - thank you, I did not know that. I have now logged in using that address and closed the requested PR. Cheers Nick
closing PR's (was Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support)
On Mon, 28 Jan 2013, nick clifton wrote: Also, could you close its duplicates, bugs 36798 and 36966? Sorry no. I do not actually own these PRs, so I cannot close them. :-( Sorry if I misinterpret, but it seems a reminder is in order: magic powers are attached to whome...@gcc.gnu.org accounts in bugzilla, so when people use them instead of their whome...@employer.example.com, they are able to close PR's they haven't created. brgds, H-P
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
Hi Matt, Could this patch, or perhaps the much smaller one I attached to bug 35294 be committed to the 4.7 branch? Yes. Done. Also, could you close its duplicates, bugs 36798 and 36966? Sorry no. I do not actually own these PRs, so I cannot close them. :-( Cheers Nick
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
On Tue, Jun 26, 2012 at 7:56 AM, nick clifton ni...@redhat.com wrote: Hi Matt, There's also a trivial documentation fix: [PATCH 1/2] doc: Correct __builtin_arm_tinsr prototype documentation and a test to exercise the intrinsics: [PATCH 2/2] arm: add iwMMXt mmx-2.c test These have both been checked in. It turns out that both needed minor updates as some of the builtins have changed since these patches were written. I have taken care of this however. Cheers Nick Hi Nick, Could this patch, or perhaps the much smaller one I attached to bug 35294 be committed to the 4.7 branch? Also, could you close its duplicates, bugs 36798 and 36966? Thanks, Matt
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
On Tue, Jun 26, 2012 at 10:56 AM, nick clifton ni...@redhat.com wrote: Hi Matt, There's also a trivial documentation fix: [PATCH 1/2] doc: Correct __builtin_arm_tinsr prototype documentation and a test to exercise the intrinsics: [PATCH 2/2] arm: add iwMMXt mmx-2.c test These have both been checked in. It turns out that both needed minor updates as some of the builtins have changed since these patches were written. I have taken care of this however. Cheers Nick Thanks a lot, Nick!
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
Hi Matt, There's also a trivial documentation fix: [PATCH 1/2] doc: Correct __builtin_arm_tinsr prototype documentation and a test to exercise the intrinsics: [PATCH 2/2] arm: add iwMMXt mmx-2.c test These have both been checked in. It turns out that both needed minor updates as some of the builtins have changed since these patches were written. I have taken care of this however. Cheers Nick
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
Hi Matt, Hi Xinyu, This series was written by Marvell and sent by Xinyu Qix...@marvell.com a number of times in the last year. Sorry for the long delay in reviewing these patches. Overall they were fine, with only a few, very minor, formatting issues. I have committed the entire series of patches to the mainline. For 4.7 and 4.6 please consider committing my patch [PATCH] arm: Fix iwmmxt shift and logical intrinsics (PR 35294). which only fixes the logical and shift intrinsics. I will look at this and post separately about it. Cheers Nick
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
On Wed, Jun 13, 2012 at 3:26 AM, nick clifton ni...@redhat.com wrote: Hi Matt, Hi Xinyu, This series was written by Marvell and sent by Xinyu Qix...@marvell.com a number of times in the last year. Sorry for the long delay in reviewing these patches. Overall they were fine, with only a few, very minor, formatting issues. I have committed the entire series of patches to the mainline. Great! Thank you so much! Thanks to Ramana for the reviews! For 4.7 and 4.6 please consider committing my patch [PATCH] arm: Fix iwmmxt shift and logical intrinsics (PR 35294). which only fixes the logical and shift intrinsics. Sounds good. There's also a trivial documentation fix: [PATCH 1/2] doc: Correct __builtin_arm_tinsr prototype documentation and a test to exercise the intrinsics: [PATCH 2/2] arm: add iwMMXt mmx-2.c test Thanks a lot! Matt
Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support
On 29 May 2012 05:13, Matt Turner matts...@gmail.com wrote: This series was written by Marvell and sent by Xinyu Qi x...@marvell.com a number of times in the last year. We (One Laptop per Child) need these patches for reasonable iWMMXt support and performance. Without them, logical and shift intrinsics cause ICEs, see PR 35294 and its duplicates 36798 and 36966. The software compositing library pixman uses MMX intrinsics to optimize various compositing routines. The following are the minimum execution times of cairo-perf-trace graphics work loads without and with iWMMXt-optimized pixman for the image and image16 backends (32-bpp and 16-bpp respectively). image image16 evolution 33.492 - 29.590 30.334 - 24.751 firefox-planet-gnome 191.465 - 173.835 211.297 - 187.570 gnome-system-monitor 51.956 - 44.549 52.272 - 40.525 gnome-terminal-vim 53.625 - 54.554 47.593 - 47.341 grads-heat-map 4.439 - 4.165 4.548 - 4.624 midori-zoomed 38.033 - 28.500 38.576 - 26.937 poppler 41.096 - 31.949 41.230 - 31.749 swfdec-giant-steps 20.062 - 16.912 28.294 - 17.286 swfdec-youtube 42.281 - 37.335 52.848 - 47.053 xfce4-terminal-a1 64.311 - 51.011 62.592 - 51.191 We have cleaned up some white-space issues with the patches and fixed a small bug in patch 4/5 since the last time they were posted in December (added tandc,textrc,torc,torvsc to the wtype attribute) Please commit them for 4.8. You do not mention how these patches have been tested with trunk after you've rebased them - I understand that you are using them in your port but can you specify how these were tested and what the results looked like ? Ramana
[PATCH ARM iWMMXt 0/5] Improve iWMMXt support
This series was written by Marvell and sent by Xinyu Qi x...@marvell.com a number of times in the last year. We (One Laptop per Child) need these patches for reasonable iWMMXt support and performance. Without them, logical and shift intrinsics cause ICEs, see PR 35294 and its duplicates 36798 and 36966. The software compositing library pixman uses MMX intrinsics to optimize various compositing routines. The following are the minimum execution times of cairo-perf-trace graphics work loads without and with iWMMXt-optimized pixman for the image and image16 backends (32-bpp and 16-bpp respectively). image image16 evolution 33.492 - 29.59030.334 - 24.751 firefox-planet-gnome 191.465 - 173.835 211.297 - 187.570 gnome-system-monitor 51.956 - 44.54952.272 - 40.525 gnome-terminal-vim 53.625 - 54.55447.593 - 47.341 grads-heat-map4.439 - 4.165 4.548 - 4.624 midori-zoomed 38.033 - 28.50038.576 - 26.937 poppler 41.096 - 31.94941.230 - 31.749 swfdec-giant-steps 20.062 - 16.91228.294 - 17.286 swfdec-youtube 42.281 - 37.33552.848 - 47.053 xfce4-terminal-a1 64.311 - 51.01162.592 - 51.191 We have cleaned up some white-space issues with the patches and fixed a small bug in patch 4/5 since the last time they were posted in December (added tandc,textrc,torc,torvsc to the wtype attribute) Please commit them for 4.8. For 4.7 and 4.6 please consider committing my patch [PATCH] arm: Fix iwmmxt shift and logical intrinsics (PR 35294). which only fixes the logical and shift intrinsics. Thanks, Matt Turner
