RE: [PATCH v1] RISC-V: Fix one build error for template default arg
Committed, thanks Kito. Pan -Original Message- From: Kito Cheng Sent: Wednesday, August 16, 2023 5:49 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang Subject: Re: [PATCH v1] RISC-V: Fix one build error for template default arg ok On Wed, Aug 16, 2023 at 5:44 PM Pan Li via Gcc-patches wrote: > > From: Pan Li > > In some build option combination, the default value may result in > below error. This patch would like to fix it by passing a explict > argument. > > riscv-vector-builtins-bases.cc:2495:24: error: invalid use of template-name \ > ‘riscv_vector::vfcvt_f’ without an argument list > > Signed-off-by: Pan Li > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-bases.cc: Use explicit argument. > --- > gcc/config/riscv/riscv-vector-builtins-bases.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc > b/gcc/config/riscv/riscv-vector-builtins-bases.cc > index 22640745398..18453e54b51 100644 > --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc > +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc > @@ -2492,7 +2492,7 @@ static CONSTEXPR const vfcvt_x > vfcvt_xu_obj; > static CONSTEXPR const vfcvt_x > vfcvt_xu_frm_obj; > static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_x_obj; > static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_xu_obj; > -static CONSTEXPR const vfcvt_f vfcvt_f_obj; > +static CONSTEXPR const vfcvt_f vfcvt_f_obj; > static CONSTEXPR const vfcvt_f vfcvt_f_frm_obj; > static CONSTEXPR const vfwcvt_x vfwcvt_x_obj; > static CONSTEXPR const vfwcvt_x vfwcvt_x_frm_obj; > -- > 2.34.1 >
Re: [PATCH v1] RISC-V: Fix one build error for template default arg
ok On Wed, Aug 16, 2023 at 5:44 PM Pan Li via Gcc-patches wrote: > > From: Pan Li > > In some build option combination, the default value may result in > below error. This patch would like to fix it by passing a explict > argument. > > riscv-vector-builtins-bases.cc:2495:24: error: invalid use of template-name \ > ‘riscv_vector::vfcvt_f’ without an argument list > > Signed-off-by: Pan Li > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-bases.cc: Use explicit argument. > --- > gcc/config/riscv/riscv-vector-builtins-bases.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc > b/gcc/config/riscv/riscv-vector-builtins-bases.cc > index 22640745398..18453e54b51 100644 > --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc > +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc > @@ -2492,7 +2492,7 @@ static CONSTEXPR const vfcvt_x > vfcvt_xu_obj; > static CONSTEXPR const vfcvt_x > vfcvt_xu_frm_obj; > static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_x_obj; > static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_xu_obj; > -static CONSTEXPR const vfcvt_f vfcvt_f_obj; > +static CONSTEXPR const vfcvt_f vfcvt_f_obj; > static CONSTEXPR const vfcvt_f vfcvt_f_frm_obj; > static CONSTEXPR const vfwcvt_x vfwcvt_x_obj; > static CONSTEXPR const vfwcvt_x vfwcvt_x_frm_obj; > -- > 2.34.1 >
[PATCH v1] RISC-V: Fix one build error for template default arg
From: Pan Li In some build option combination, the default value may result in below error. This patch would like to fix it by passing a explict argument. riscv-vector-builtins-bases.cc:2495:24: error: invalid use of template-name \ ‘riscv_vector::vfcvt_f’ without an argument list Signed-off-by: Pan Li gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Use explicit argument. --- gcc/config/riscv/riscv-vector-builtins-bases.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc index 22640745398..18453e54b51 100644 --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc @@ -2492,7 +2492,7 @@ static CONSTEXPR const vfcvt_x vfcvt_xu_obj; static CONSTEXPR const vfcvt_x vfcvt_xu_frm_obj; static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_x_obj; static CONSTEXPR const vfcvt_rtz_x vfcvt_rtz_xu_obj; -static CONSTEXPR const vfcvt_f vfcvt_f_obj; +static CONSTEXPR const vfcvt_f vfcvt_f_obj; static CONSTEXPR const vfcvt_f vfcvt_f_frm_obj; static CONSTEXPR const vfwcvt_x vfwcvt_x_obj; static CONSTEXPR const vfwcvt_x vfwcvt_x_frm_obj; -- 2.34.1