Re: [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target

2014-09-09 Thread Ramana Radhakrishnan 
On Thu, Sep 4, 2014 at 3:21 AM, Tony Wang tony.w...@arm.com wrote:
 Hi there,

 This is a test case clean up patch, because orr/eor instruction for thumb1 
 has only two variant:

 ORRS Rdn, Rm
 ORRc Rdn, Rm
 No shift is available for thumb1 encoding, so test case 
 xordi3-opt.c/iordi3-opt.c is invalid for thumb1
 target. This patch just disabled them for thumb1 target.

 Ok for the trunk?

Ok (assuming you've tested this on suitable multilib variants :))

Ramana


 gcc/gcc/testsuite/ChangeLog:
 2014-09-04  Tony Wang  tony.w...@arm.com

  * gcc.target/arm/xordi3-opt.c: Disable this
  test case for thumb1 target.
  * gcc.target/arm/iordi3-opt.c: Ditto.

 diff --git a/gcc/testsuite/gcc.target/arm/iordi3-opt.c 
 b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
 index b3f465b..63fbe0b 100644
 --- a/gcc/testsuite/gcc.target/arm/iordi3-opt.c
 +++ b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
 @@ -1,4 +1,4 @@
 -/* { dg-do compile } */
 +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
  /* { dg-options -O1 } */

  unsigned long long or64 (unsigned long long input)
 diff --git a/gcc/testsuite/gcc.target/arm/xordi3-opt.c 
 b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
 index 7e031c3..53b2bab 100644
 --- a/gcc/testsuite/gcc.target/arm/xordi3-opt.c
 +++ b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
 @@ -1,4 +1,4 @@
 -/* { dg-do compile } */
 +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
  /* { dg-options -O1 } */

  unsigned long long xor64 (unsigned long long input)

[Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target

2014-09-03 Thread Tony Wang 
Hi there,

This is a test case clean up patch, because orr/eor instruction for thumb1 has 
only two variant:

ORRS Rdn, Rm
ORRc Rdn, Rm
No shift is available for thumb1 encoding, so test case 
xordi3-opt.c/iordi3-opt.c is invalid for thumb1
target. This patch just disabled them for thumb1 target.

Ok for the trunk?

gcc/gcc/testsuite/ChangeLog:
2014-09-04  Tony Wang  tony.w...@arm.com

 * gcc.target/arm/xordi3-opt.c: Disable this
 test case for thumb1 target.
 * gcc.target/arm/iordi3-opt.c: Ditto.

diff --git a/gcc/testsuite/gcc.target/arm/iordi3-opt.c 
b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
index b3f465b..63fbe0b 100644
--- a/gcc/testsuite/gcc.target/arm/iordi3-opt.c
+++ b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
 /* { dg-options -O1 } */
 
 unsigned long long or64 (unsigned long long input)
diff --git a/gcc/testsuite/gcc.target/arm/xordi3-opt.c 
b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
index 7e031c3..53b2bab 100644
--- a/gcc/testsuite/gcc.target/arm/xordi3-opt.c
+++ b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
 /* { dg-options -O1 } */
 
 unsigned long long xor64 (unsigned long long input)