[avr,committed] Fix fixed-point conversion

[Georg-Johann Lay]

Committed the following change:

http://gcc.gnu.org/r195424

* config/avr/avr.c (avr_out_fract): Make register numbers that
might be outside of source operand signed.


The problem occurs with fixed-point conversions to a wider mode and where the
input operand is in a small regno like r2:

src:  QQmode in r2
dest: DAmode in r2

avr.c:avr_out_fract loops over the registers and clears dest registers at the
low end that have no associated src register (zero-extension at the low end).

In the sample case the register numbers (variables s0, s1) drop below 0 and
must be signed for that reason.  Otherwise, some dest registers, starting at
2^{-16}, will not be cleared.


Johann

Re: [avr,committed] Fix fixed-point conversion

[Gerald Pfeifer]

On Thu, 24 Jan 2013, Georg-Johann Lay wrote:
> Committed the following change:
> 
> http://gcc.gnu.org/r195424
> 
>   * config/avr/avr.c (avr_out_fract): Make register numbers that
>   might be outside of source operand signed.

Can you still post patches to the list, and not just the reference?

Thanks,
Gerald

Re: [avr,committed] Fix fixed-point conversion

[Georg-Johann Lay]

Gerald Pfeifer wrote:
> On Thu, 24 Jan 2013, Georg-Johann Lay wrote:
>> Committed the following change:
>>
>> http://gcc.gnu.org/r195424
>>
>>  * config/avr/avr.c (avr_out_fract): Make register numbers that
>>  might be outside of source operand signed.
> 
> Can you still post patches to the list, and not just the reference?
> 
> Thanks,
> Gerald


Thinks for pointing this out.  I will follow the guideline in the future.

Here is the change:

Index: config/avr/avr.c
===
--- config/avr/avr.c(revision 195423)
+++ config/avr/avr.c(revision 195424)
@@ -7114,13 +7114,13 @@ avr_out_fract (rtx insn, rtx operands[],
   unsigned d1 = d0 + step;

   // Current and next regno of source
-  unsigned s0 = d0 - offset;
-  unsigned s1 = s0 + step;
+  signed s0 = d0 - offset;
+  signed s1 = s0 + step;

   // Must current resp. next regno be CLRed?  This applies to the low
   // bytes of the destination that have no associated source bytes.
-  bool clr0 = s0 < src.regno;
-  bool clr1 = s1 < src.regno && d1 >= dest.regno;
+  bool clr0 = s0 < (signed) src.regno;
+  bool clr1 = s1 < (signed) src.regno && d1 >= dest.regno;

   // First gather what code to emit (if any) and additional step to
   // apply if a MOVW is in use.  xop[2] is destination rtx and xop[3]
@@ -7150,12 +7150,12 @@ avr_out_fract (rtx insn, rtx operands[],
 }
 }
 }
-  else if (offset && s0 <= src.regno_msb)
+  else if (offset && s0 <= (signed) src.regno_msb)
 {
   int movw = AVR_HAVE_MOVW && offset % 2 == 0
 && d0 % 2 == (offset > 0)
 && d1 <= dest.regno_msb && d1 >= dest.regno
-&& s1 <= src.regno_msb  && s1 >= src.regno;
+&& s1 <= (signed) src.regno_msb  && s1 >= (signed) src.regno;

   xop[2] = all_regs_rtx[d0 & ~movw];
   xop[3] = all_regs_rtx[s0 & ~movw];