Re: [committed] add test for PR 86058
On Wed, Apr 14, 2021 at 10:49:42AM -0600, Martin Sebor via Gcc-patches wrote: > Apparently the IL GCC emits on some targets (arm and aarach64 with > mabi=ilp32, and powerpc64 to name the three where the failures have > been pointed out) isn't handled by the uninit pass and so it doesn't > issue the expected warning. That might be a new (as in previously > unknown) limitation in the warning or one I don't remember coming > across. > > I don't see excess warnings with my arm-eabi cross-compiler. What > are they in your environment? > > I have limited the test to just x86_64 for now and repurposed pr100073 > where the same failure was reported on powerpc64 to track the missing > warning on these targets. + The test fails on a number of non-x86_64 targets due to pr100073. + { dg-do compile { target x86_64-*-* } } change is incorrect. Either you mean x86_64 -m64 code only, then it should be { i?86-*-* x86_64-*-* } && lp64 or you mean x86_64 -m64/-mx32, then it should be { i?86-*-* x86_64-*-* } && { ! ia32 } or you mean x86_64 -m64/-mx32/-m32, then it should be { i?86-*-* x86_64-*-* } E.g. on Solaris target triplet is i?86-*-* but it supports -m64 also, on the other side, x86_64-*-* triplet covers all supported multilibs (so both -m64 and -m32 and sometimes -mx32), but will not cover i686-*-* etc. even when it is the same thing as x86_64-*-* with -m32. Jakub
Re: [committed] add test for PR 86058
On 4/14/21 2:11 AM, Christophe Lyon wrote: On Tue, 13 Apr 2021 at 21:50, Martin Sebor via Gcc-patches wrote: The issue has been fixed so r11-8161 just adds the test case: https://gcc.gnu.org/g:8084ab15a3e300e3b2c537e56e0f3a1b00778aec Hi, This new test fails on arm (and aarch64 with -mabi=ilp32): XFAIL: gcc.dg/pr86058.c pr? (test for warnings, line 13) FAIL: gcc.dg/pr86058.c actual (test for warnings, line 13) PASS: gcc.dg/pr86058.c (test for excess errors) Can you check? Apparently the IL GCC emits on some targets (arm and aarach64 with mabi=ilp32, and powerpc64 to name the three where the failures have been pointed out) isn't handled by the uninit pass and so it doesn't issue the expected warning. That might be a new (as in previously unknown) limitation in the warning or one I don't remember coming across. I don't see excess warnings with my arm-eabi cross-compiler. What are they in your environment? I have limited the test to just x86_64 for now and repurposed pr100073 where the same failure was reported on powerpc64 to track the missing warning on these targets. Martin
Re: [committed] add test for PR 86058
On Tue, 13 Apr 2021 at 21:50, Martin Sebor via Gcc-patches wrote: > > The issue has been fixed so r11-8161 just adds the test case: >https://gcc.gnu.org/g:8084ab15a3e300e3b2c537e56e0f3a1b00778aec > Hi, This new test fails on arm (and aarch64 with -mabi=ilp32): XFAIL: gcc.dg/pr86058.c pr? (test for warnings, line 13) FAIL: gcc.dg/pr86058.c actual (test for warnings, line 13) PASS: gcc.dg/pr86058.c (test for excess errors) Can you check? Thanks > Martin
[committed] add test for PR 86058
The issue has been fixed so r11-8161 just adds the test case: https://gcc.gnu.org/g:8084ab15a3e300e3b2c537e56e0f3a1b00778aec Martin