[google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Doug Kwan 
Hi Diego,

This patch fixes a problem of the validate_failures.py script that
it rejects cross compilers.  I have tested it by running the script
in the build directory of gcc configure for arm-unknown-linux-gnueabi.
I also tested it on a native compiler for x86.  This should go to both
google/main and trunk.

-Doug

2012-02-17   Doug Kwan  dougk...@google.com

* contrib/testsuite-management/validate_failures.py
(def GetMakefileValue): Check for cross compilers.

Index: contrib/testsuite-management/validate_failures.py
===
--- contrib/testsuite-management/validate_failures.py   (revision 184327)
+++ contrib/testsuite-management/validate_failures.py   (working copy)
@@ -146,7 +146,8 @@ def GetMakefileValue(makefile_name, value_name):
 def ValidBuildDirectory(builddir, target):
   if (not os.path.exists(builddir) or
   not os.path.exists('%s/Makefile' % builddir) or
-  not os.path.exists('%s/build-%s' % (builddir, target))):
+  (not os.path.exists('%s/build-%s' % (builddir, target)) and
+   not os.path.exists('%s/%s' % (builddir, target:
 return False
   return True
 

--
This patch is available for review at http://codereview.appspot.com/5674087

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Diego Novillo 

On 17/02/12 05:49 , Doug Kwan wrote:


2012-02-17   Doug Kwandougk...@google.com

* contrib/testsuite-management/validate_failures.py
(def GetMakefileValue): Check for cross compilers.


OK.  Thanks.


Diego.

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread 關振德 
Should I submit toe trunk also, now that it is closed?

On Fri, Feb 17, 2012 at 4:52 AM, Diego Novillo dnovi...@google.com wrote:
 On 17/02/12 05:49 , Doug Kwan wrote:

 2012-02-17   Doug Kwandougk...@google.com

        * contrib/testsuite-management/validate_failures.py
        (def GetMakefileValue): Check for cross compilers.


 OK.  Thanks.


 Diego.

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Diego Novillo 
On Fri, Feb 17, 2012 at 18:17, Doug Kwan (關振德) dougk...@google.com wrote:
 Should I submit toe trunk also, now that it is closed?

Yes, that's fine.  contrib/ is not release-critical.


Diego.