Re: [google]Emit GNU-stack note for arm targets by default (issue5649090)

2012-02-14 Thread Xinliang David Li
ok.

On Tue, Feb 14, 2012 at 11:34 AM, Jing Yu  wrote:
> arm-eabi toolchain needs GNU-stack note for security purpose.
> Will Keep this patch in google branches.
>
> OK for google/main?
> I would like to port this patch to google/gcc-4_6, google/gcc-4_6-mobile,
> google/gcc-4_6_2-moible.
>
> 2012-02-14  Jing Yu  
>        Google ref 42402-p2
>        * config/arm/arm.h: Emit GNU-stack note for all arm targets by
>        default.
>
> Index: gcc/config/arm/arm.h
> ===
> --- gcc/config/arm/arm.h        (revision 184221)
> +++ gcc/config/arm/arm.h        (working copy)
> @@ -2157,9 +2157,9 @@
>    : arm_gen_return_addr_mask ())
>
>
> -/* Do not emit .note.GNU-stack by default.  */
> +/* Do emit .note.GNU-stack by default.  */
>  #ifndef NEED_INDICATE_EXEC_STACK
> -#define NEED_INDICATE_EXEC_STACK       0
> +#define NEED_INDICATE_EXEC_STACK       1
>  #endif
>
>  /* The maximum number of parallel loads or stores we support in an ldm/stm
>
> --
> This patch is available for review at http://codereview.appspot.com/5649090


[google]Emit GNU-stack note for arm targets by default (issue5649090)

2012-02-14 Thread Jing Yu
arm-eabi toolchain needs GNU-stack note for security purpose.
Will Keep this patch in google branches.

OK for google/main?
I would like to port this patch to google/gcc-4_6, google/gcc-4_6-mobile,
google/gcc-4_6_2-moible.

2012-02-14  Jing Yu  
Google ref 42402-p2
* config/arm/arm.h: Emit GNU-stack note for all arm targets by
default.

Index: gcc/config/arm/arm.h
===
--- gcc/config/arm/arm.h(revision 184221)
+++ gcc/config/arm/arm.h(working copy)
@@ -2157,9 +2157,9 @@
: arm_gen_return_addr_mask ())


-/* Do not emit .note.GNU-stack by default.  */
+/* Do emit .note.GNU-stack by default.  */
 #ifndef NEED_INDICATE_EXEC_STACK
-#define NEED_INDICATE_EXEC_STACK   0
+#define NEED_INDICATE_EXEC_STACK   1
 #endif

 /* The maximum number of parallel loads or stores we support in an ldm/stm

--
This patch is available for review at http://codereview.appspot.com/5649090