Re: [google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

[Carrot Wei]

OK.

thanks
Carrot

On Tue, Jun 7, 2011 at 1:09 AM,   wrote:
> The trunk version has been approved and committed as r174710. Backport
> it to google/main. The google/main version has the same logic but is
> slightly different since trunk has a different code structure here. OK
> for google/main?
>
> 2011-06-06  Jing Yu  
>
>        Backport trunk r174710:
>
>        * configure.ac: Skip target-libiberty for arm*-*-linux-androideabi.
>        * configure: Regenerated.
>
> http://codereview.appspot.com/4564050/
>

Re: [google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

[jingyu]

The trunk version has been approved and committed as r174710. Backport
it to google/main. The google/main version has the same logic but is
slightly different since trunk has a different code structure here. OK
for google/main?

2011-06-06  Jing Yu  

Backport trunk r174710:

* configure.ac: Skip target-libiberty for arm*-*-linux-androideabi.
* configure: Regenerated.

http://codereview.appspot.com/4564050/

[google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

[Jing Yu]

Building gcc-4.6 arm android toolchain fails because of conflicting
getpagesize() definition between libiberty and bionic.
Based on discussions on another thread
(http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg06627.html),
reviewer recommended ripping out all support for building libiberty
for the target side as it is not needed. However, I don't know if
someone is working on that. Before the ideal patch is out, we have to
clear the blocking issue and make the toolchain built.

The following patch simply skips building target-libiberty for
arm*-*-linux-androideabi target. I have tested the patch by
building arm-linux-androideabi toolchain.

I sent the similar patch to trunk for review. The patch to trunk
is slightly different because this part of configure.ac has been
modified. The logic is the same though.
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02457.html
The review is on going. I am not sure how long it would be.
I would suggest we first commit this tiny patch in google/main and
make our toolchain built. Then do further update if the trunk version is final.

Thanks,
Jing

2011-05-31  Jing Yu  

* configure.ac: Skip target-libiberty for arm*-*-linux-androideabi
* configure: Regenerate

Index: configure.ac
===
--- configure.ac(revision 174299)
+++ configure.ac(working copy)
@@ -682,6 +682,9 @@
 noconfigdirs="$noconfigdirs target-libffi target-qthreads"
 libgloss_dir=arm
 ;;
+  arm*-*-linux-androideabi)
+noconfigdirs="$noconfigdirs target-libiberty"
+;;
   arm*-*-linux-gnueabi)
 noconfigdirs="$noconfigdirs target-qthreads"
 case ${with_newlib} in
Index: configure
===
--- configure   (revision 174299)
+++ configure   (working copy)
@@ -3236,6 +3236,9 @@
 noconfigdirs="$noconfigdirs target-libffi target-qthreads"
 libgloss_dir=arm
 ;;
+  arm*-*-linux-androideabi)
+noconfigdirs="$noconfigdirs target-libiberty"
+;;
   arm*-*-linux-gnueabi)
 noconfigdirs="$noconfigdirs target-qthreads"
 case ${with_newlib} in

--
This patch is available for review at http://codereview.appspot.com/4564050