Re: [libgfortran,patch] Remove never-used debugging code

2015-08-26 Thread FX 
 OK. Just checking.  Thanks for the code cleanup.

Thanks for the review. Committed as rev. 227208.

FX

Re: [libgfortran,patch] Remove never-used debugging code

2015-08-25 Thread FX 
Turns out I missed some of the dead code. And I now also fixed comments and 
some formatting.
libgfortran/runtime/environ.c is now much more readable than before.
The patch is still a no-op, in terms of user functionality.
OK to commit to trunk?

FX




unusedcode.ChangeLog
Description: Binary data


unusedcode.diff
Description: Binary data

Re: [libgfortran,patch] Remove never-used debugging code

2015-08-25 Thread Steve Kargl 
On Tue, Aug 25, 2015 at 07:10:23PM +0200, FX wrote:
  Certainly, the dead code can go.  But,is this changing the library ABI?
  
  troutmask:fvwm:kargl[764] nm /mnt/sgk/work/6/lib/libgfortran.a | grep show_
   T _gfortrani_show_variables
   t show_boolean
   t show_integer
   t show_sep
   t show_string
   T _gfortrani_show_locus
 
 Nope, none of those functions are actually publicly exported.
 They are not in gfortran.map, being either static, or having
 _gfortrani_ prefix which means internal libgfortran use.
 

OK. Just checking.  Thanks for the code cleanup.

-- 
Steve

Re: [libgfortran,patch] Remove never-used debugging code

2015-08-25 Thread Steve Kargl 
On Tue, Aug 25, 2015 at 06:17:13PM +0200, FX wrote:
 Turns out I missed some of the dead code. And I now also fixed comments and 
 some formatting.
 libgfortran/runtime/environ.c is now much more readable than before.
 The patch is still a no-op, in terms of user functionality.
 OK to commit to trunk?
 

Certainly, the dead code can go.  But,is this changing
the library ABI?

troutmask:fvwm:kargl[764] nm /mnt/sgk/work/6/lib/libgfortran.a | grep show_
 T _gfortrani_show_variables
 t show_boolean
 t show_integer
 t show_sep
 t show_string
 T _gfortrani_show_locus




-- 
Steve

Re: [libgfortran,patch] Remove never-used debugging code

2015-08-25 Thread FX 
 Certainly, the dead code can go.  But,is this changing the library ABI?
 
 troutmask:fvwm:kargl[764] nm /mnt/sgk/work/6/lib/libgfortran.a | grep show_
  T _gfortrani_show_variables
  t show_boolean
  t show_integer
  t show_sep
  t show_string
  T _gfortrani_show_locus

Nope, none of those functions are actually publicly exported. They are not in 
gfortran.map, being either static, or having _gfortrani_ prefix which means 
internal libgfortran use.

FX

[libgfortran,patch] Remove never-used debugging code

2015-08-24 Thread FX 
Continuing the summer clean-ups.

There is in the init() function some dead debugging code, which as far as I 
know is never used: it’s compiled conditionaly on DEBUG being defined, and but 
we don’t have anything that can define DEBUG. The commented-out “resume” 
functionality was never implemented in gfortran. And show_variables() isn’t 
very useful.

OK to commit to trunk?

FX




unusedcode.ChangeLog
Description: Binary data


unusedcode.diff
Description: Binary data