Re: [patch,committed] Move gfortran.dg/dec_math_5.f90 to ./ieee/ (was: Re: PATCH -- Fix degree trignometric functions)

2020-04-08 Thread Fritz Reese via Gcc-patches
Andreas, thank you for the report.

Tobias, thank you for the fix.

---
Fritz Reese

On Wed, Apr 8, 2020 at 12:02 PM Tobias Burnus  wrote:
>
> Hi Andreas,
>
> thanks for the report. In principle, it would be helpful to know on
> which target you are running the test case.
>
> However, I assume that either of the following went wrong:
> * Target does not support IEEE
> * It supports it, but gfortran's intrinsic search path does
>not point to directory in which the ieee modules are
>
> That's solved by moving the test case to the ieee/ subdirectory
> which has a check whether IEEE works and also sets the intrinsic
> module include path (-fintrinsic-modules-path $specpath/libgfortran/).
>
> I have now committed it as obvious – but I would be good when you
> can confirm that it works (PASS if it should support IEEE or, if not,
> UNSUPPORTED).
>
> See r10-7631-gfaa0817311f43e0d4d223d53c816b0c74ec35c4e
> or attachment.
>
> Cheers,
>
> Tobias
>
> On 4/8/20 5:04 PM, Andreas Schwab wrote:
>
> > FAIL: gfortran.dg/dec_math_5.f90   -O0  (test for excess errors)
> > Excess errors:
> > /opt/gcc/gcc-20200408/gcc/testsuite/gfortran.dg/dec_math_5.f90:132:9: Fatal 
> > Error: Cannot open module file 'ieee_arithmetic.mod' for reading at (1): No 
> > such file or directory
> > compilation terminated.
> >
> > Andreas.
> >
> -
> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, 
> Alexander Walter


[patch,committed] Move gfortran.dg/dec_math_5.f90 to ./ieee/ (was: Re: PATCH -- Fix degree trignometric functions)

2020-04-08 Thread Tobias Burnus

Hi Andreas,

thanks for the report. In principle, it would be helpful to know on
which target you are running the test case.

However, I assume that either of the following went wrong:
* Target does not support IEEE
* It supports it, but gfortran's intrinsic search path does
  not point to directory in which the ieee modules are

That's solved by moving the test case to the ieee/ subdirectory
which has a check whether IEEE works and also sets the intrinsic
module include path (-fintrinsic-modules-path $specpath/libgfortran/).

I have now committed it as obvious – but I would be good when you
can confirm that it works (PASS if it should support IEEE or, if not,
UNSUPPORTED).

See r10-7631-gfaa0817311f43e0d4d223d53c816b0c74ec35c4e
or attachment.

Cheers,

Tobias

On 4/8/20 5:04 PM, Andreas Schwab wrote:


FAIL: gfortran.dg/dec_math_5.f90   -O0  (test for excess errors)
Excess errors:
/opt/gcc/gcc-20200408/gcc/testsuite/gfortran.dg/dec_math_5.f90:132:9: Fatal 
Error: Cannot open module file 'ieee_arithmetic.mod' for reading at (1): No 
such file or directory
compilation terminated.

Andreas.


-
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander 
Walter
commit faa0817311f43e0d4d223d53c816b0c74ec35c4e
Author: Tobias Burnus 
Date:   Wed Apr 8 17:54:04 2020 +0200

Move gfortran.dg/dec_math_5.f90 to ./ieee/

PR fortran/93871
* gfortran.dg/dec_math_5.f90: Move to ...
* gfortran.dg/ieee/dec_math_1.f90: ... here; change
dg-options to dg-additional-options.
---
 gcc/testsuite/ChangeLog   | 7 +++
 gcc/testsuite/gfortran.dg/{dec_math_5.f90 => ieee/dec_math_1.f90} | 5 -
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 557c81544e4..347181619a5 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2020-04-08  Tobias Burnus  
+
+	PR fortran/93871
+	* gfortran.dg/dec_math_5.f90: Move to ...
+	* gfortran.dg/ieee/dec_math_1.f90: ... here; change
+	dg-options to dg-additional-options.
+
 2020-04-08  Alexandre Oliva 
 
 	* gcc.dg/tls/pr78796.c: Require tls_runtime.
diff --git a/gcc/testsuite/gfortran.dg/dec_math_5.f90 b/gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90
similarity index 97%
rename from gcc/testsuite/gfortran.dg/dec_math_5.f90
rename to gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90
index d761e039cc8..8587fd66eb1 100644
--- a/gcc/testsuite/gfortran.dg/dec_math_5.f90
+++ b/gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90
@@ -1,8 +1,11 @@
-! { dg-options "-cpp -std=gnu" }
 ! { dg-do run }
+! { dg-additional-options "-cpp -std=gnu" }
 !
 ! Test values for degree-valued trigonometric intrinsics.
 !
+! Run under ieee/ as
+!   use ieee_arithmetic
+! (used for result checking) is not available on all platforms)
 
 module dec_math_5