Re: [patch] Normalize more bitmap function names.

2012-11-01 Thread Diego Novillo 

On 2012-10-31 13:41 , Lawrence Crowl wrote:

This patch normalizes more bitmap function names.

   sbitmap.h

 TEST_BIT - bitmap_bit_p
 SET_BIT - bitmap_set_bit


I wonder if it wouldn't it be more consistent if TEST_BIT became 
bitmap_test_bit() ?  I never particularly liked the lispy *_p 
convention.  But I don't really care much one way or the other.


The patch is OK.


Diego.

Re: [patch] Normalize more bitmap function names.

2012-11-01 Thread Lawrence Crowl 
On 11/1/12, Diego Novillo dnovi...@google.com wrote:
 On 2012-10-31 13:41 , Lawrence Crowl wrote:
 This patch normalizes more bitmap function names.

sbitmap.h

  TEST_BIT - bitmap_bit_p
  SET_BIT - bitmap_set_bit

 I wonder if it wouldn't it be more consistent if TEST_BIT became
 bitmap_test_bit() ?  I never particularly liked the lispy *_p
 convention.  But I don't really care much one way or the other.

The plan was to simply use the bitmap names, and given the
schedule I would prefer to leave it as is.

 The patch is OK.

Okay.  I will merge and commit.

-- 
Lawrence Crowl