Re: [patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
On 7/11/2015 1:45 PM, Jonathan Wakely wrote: > On 11 July 2015 at 06:46, Jeff Law wrote: >> On 07/10/2015 06:34 PM, John Marino wrote: >>> >>> After posting the first testsuite results for DragonFly, it was clear >>> that the -fcilkplus functionality was broken: >>> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01046.html >>> >>> The problem was related to the __cpu_model symbol not getting exported. >>> >>> The solution was to create libgcc/config/i386/t-dragonfly to define an >>> additional symbol map (similar to t-freebsd). Simply creating the file >>> is enough because there's already a placeholder for t-dragonfly at >>> libgcc/config.host. The patch is attached. >>> >>> The improved results of the patch can be seen on the next posted >>> testsuite results: >>> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01081.html >>> >>> An additional ~2600 tests now pass. >>> Please consider this patch for incorporation into trunk. Only DragonFly >>> uses the new t-dragonfly file so there is no impact to other platforms. >>> >>> suggested entry for libgcc/ChangeLog: >>> >>> 2015-07-XX John Marino >>> >>> * config/i386/t-dragonfly: New. >> >> OK. >> jeff >> > > John, If you like I can commit this for you on Monday when I commit > your patch to os_defines.h. > That is very kind, Jonathan! thanks, Monday would be great. John P.S. I have a 3rd simple one that you can commit on Monday as well if it gets approved (no reason it shouldn't): https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00897.html
Re: [patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
On 11 July 2015 at 06:46, Jeff Law wrote: > On 07/10/2015 06:34 PM, John Marino wrote: >> >> After posting the first testsuite results for DragonFly, it was clear >> that the -fcilkplus functionality was broken: >> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01046.html >> >> The problem was related to the __cpu_model symbol not getting exported. >> >> The solution was to create libgcc/config/i386/t-dragonfly to define an >> additional symbol map (similar to t-freebsd). Simply creating the file >> is enough because there's already a placeholder for t-dragonfly at >> libgcc/config.host. The patch is attached. >> >> The improved results of the patch can be seen on the next posted >> testsuite results: >> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01081.html >> >> An additional ~2600 tests now pass. >> Please consider this patch for incorporation into trunk. Only DragonFly >> uses the new t-dragonfly file so there is no impact to other platforms. >> >> suggested entry for libgcc/ChangeLog: >> >> 2015-07-XX John Marino >> >> * config/i386/t-dragonfly: New. > > OK. > jeff > John, If you like I can commit this for you on Monday when I commit your patch to os_defines.h.
Re: [patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
On 07/10/2015 06:34 PM, John Marino wrote: After posting the first testsuite results for DragonFly, it was clear that the -fcilkplus functionality was broken: https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01046.html The problem was related to the __cpu_model symbol not getting exported. The solution was to create libgcc/config/i386/t-dragonfly to define an additional symbol map (similar to t-freebsd). Simply creating the file is enough because there's already a placeholder for t-dragonfly at libgcc/config.host. The patch is attached. The improved results of the patch can be seen on the next posted testsuite results: https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01081.html An additional ~2600 tests now pass. Please consider this patch for incorporation into trunk. Only DragonFly uses the new t-dragonfly file so there is no impact to other platforms. suggested entry for libgcc/ChangeLog: 2015-07-XX John Marino * config/i386/t-dragonfly: New. OK. jeff
[patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
After posting the first testsuite results for DragonFly, it was clear that the -fcilkplus functionality was broken: https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01046.html The problem was related to the __cpu_model symbol not getting exported. The solution was to create libgcc/config/i386/t-dragonfly to define an additional symbol map (similar to t-freebsd). Simply creating the file is enough because there's already a placeholder for t-dragonfly at libgcc/config.host. The patch is attached. The improved results of the patch can be seen on the next posted testsuite results: https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01081.html An additional ~2600 tests now pass. Please consider this patch for incorporation into trunk. Only DragonFly uses the new t-dragonfly file so there is no impact to other platforms. suggested entry for libgcc/ChangeLog: 2015-07-XX John Marino * config/i386/t-dragonfly: New. Thanks, John --- /dev/null 2015-07-10 21:56:18 UTC +++ libgcc/config/i386/t-dragonfly @@ -0,0 +1,2 @@ +# Required for -fcilkplus support +SHLIB_MAPFILES += $(srcdir)/config/i386/libgcc-bsd.ver
