Re: [wwwdocs] Add no_sanitize attribute
On Sun, 7 Oct 2018, Sandra Loosemore wrote:
> This is definitely an improvement. One more tweak I'd make is
>
> s/any of the options specified/the options provided as arguments to the
> attribute/
Thank you, Sandra. I made that additional change.
On Mon, 8 Oct 2018, Martin Liška wrote:
> Yes, it's equivalent, thanks for the improvement.
Thanks for the reviews. I (finally) applied this per the patch below;
sorry for the delay.
Gerald
Index: changes.html
===
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- changes.html30 Sep 2018 14:38:54 - 1.97
+++ changes.html29 Dec 2018 21:08:04 -
@@ -251,11 +251,11 @@
tests for pointer wrapping.
-New no_sanitize attribute has been added. The attribute
-on functions is used to inform the compiler that it should
-not do sanitization of all options mentioned in sanitize option.
-A list of values acceptable by -fsanitize option can be
-provided.
+A new attribute no_sanitize can be applied to functions
+to instruct the compiler not to do sanitization of the options
+provided as arguments to the attribute. Acceptable values for
+no_sanitize match those acceptable by the
+-fsanitize command-line option.
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }
Re: [wwwdocs] Add no_sanitize attribute
On 10/7/18 2:15 PM, Gerald Pfeifer wrote:
> On Wed, 18 Apr 2018, Martin Liška wrote:
>> I would like to mention the attribute in GCC 8 changes.
>
> Index: htdocs/gcc-8/changes.html
> ===
>>
>> New no_sanitize attribute has been added. The attribute
>> on functions is used to inform the compiler that it should
>> not do sanitization of all options mentioned in sanitize option.
>> A list of values acceptable by -fsanitize option can be
>> provided.
>>
>> void __attribute__ ((no_sanitize ("alignment", "object-size")))
>> f () { /* Do something. */; }
>>
>>
>
> I've been struggling with this from a language perspective and
> while not fully happy, believe/hope the below may improve things
> a bit.
>
> Sandra, any recommendations from your end?
>
> Martin, is my update technically acurate?
Hi.
Yes, it's equivalent, thanks for the improvement.
Martin
>
> Index: gcc-8/changes.html
> ===
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
> retrieving revision 1.97
> diff -u -r1.97 changes.html
> --- gcc-8/changes.html30 Sep 2018 14:38:54 - 1.97
> +++ gcc-8/changes.html7 Oct 2018 12:13:03 -
> @@ -251,11 +251,10 @@
> tests for pointer wrapping.
>
>
> -New no_sanitize attribute has been added. The attribute
> -on functions is used to inform the compiler that it should
> -not do sanitization of all options mentioned in sanitize option.
> -A list of values acceptable by -fsanitize option can be
> -provided.
> +A new attribute no_sanitize can be applied to functions
> +to instruct the compiler not to do sanitization of any of the options
> +specified. Acceptable values for no_sanitize match those
> +acceptable by the -fsanitize command-line option.
>
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }
>
> Gerald
>
Re: [wwwdocs] Add no_sanitize attribute
On 10/07/2018 06:15 AM, Gerald Pfeifer wrote:
On Wed, 18 Apr 2018, Martin Liška wrote:
I would like to mention the attribute in GCC 8 changes.
Index: htdocs/gcc-8/changes.html
===
New no_sanitize attribute has been added. The attribute
on functions is used to inform the compiler that it should
not do sanitization of all options mentioned in sanitize option.
A list of values acceptable by -fsanitize option can be
provided.
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }
I've been struggling with this from a language perspective and
while not fully happy, believe/hope the below may improve things
a bit.
Sandra, any recommendations from your end?
Martin, is my update technically acurate?
Index: gcc-8/changes.html
===
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- gcc-8/changes.html 30 Sep 2018 14:38:54 - 1.97
+++ gcc-8/changes.html 7 Oct 2018 12:13:03 -
@@ -251,11 +251,10 @@
tests for pointer wrapping.
-New no_sanitize attribute has been added. The attribute
-on functions is used to inform the compiler that it should
-not do sanitization of all options mentioned in sanitize option.
-A list of values acceptable by -fsanitize option can be
-provided.
+A new attribute no_sanitize can be applied to functions
+to instruct the compiler not to do sanitization of any of the options
+specified. Acceptable values for no_sanitize match those
+acceptable by the -fsanitize command-line option.
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }
This is definitely an improvement. One more tweak I'd make is
s/any of the options specified/the options provided as arguments to the
attribute/
-Sandra
Re: [wwwdocs] Add no_sanitize attribute
On Wed, 18 Apr 2018, Martin Liška wrote:
> I would like to mention the attribute in GCC 8 changes.
Index: htdocs/gcc-8/changes.html
===
>
> New no_sanitize attribute has been added. The attribute
> on functions is used to inform the compiler that it should
> not do sanitization of all options mentioned in sanitize option.
> A list of values acceptable by -fsanitize option can be
> provided.
>
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }
>
>
I've been struggling with this from a language perspective and
while not fully happy, believe/hope the below may improve things
a bit.
Sandra, any recommendations from your end?
Martin, is my update technically acurate?
Index: gcc-8/changes.html
===
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- gcc-8/changes.html 30 Sep 2018 14:38:54 - 1.97
+++ gcc-8/changes.html 7 Oct 2018 12:13:03 -
@@ -251,11 +251,10 @@
tests for pointer wrapping.
-New no_sanitize attribute has been added. The attribute
-on functions is used to inform the compiler that it should
-not do sanitization of all options mentioned in sanitize option.
-A list of values acceptable by -fsanitize option can be
-provided.
+A new attribute no_sanitize can be applied to functions
+to instruct the compiler not to do sanitization of any of the options
+specified. Acceptable values for no_sanitize match those
+acceptable by the -fsanitize command-line option.
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }
Gerald
Re: [wwwdocs] Add no_sanitize attribute
On 04/18/2018 06:22 AM, Martin Liška wrote: > I would like to mention the attribute in GCC 8 changes. OK. jeff
[wwwdocs] Add no_sanitize attribute
I would like to mention the attribute in GCC 8 changes.
Martin
Index: htdocs/gcc-8/changes.html
===
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.67
diff -r1.67 changes.html
255a256,266
>
> New no_sanitize attribute has been added. The attribute
> on functions is used to inform the compiler that it should
> not do sanitization of all options mentioned in sanitize option.
> A list of values acceptable by -fsanitize option can be
> provided.
>
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }
>
>
