Re: Backported r187026 from branches/google/gcc-4_6 (issue 6148044)
LGTM On Wed, May 2, 2012 at 11:24 AM, wrote: > On 2012/05/01 22:51:22, jingyu wrote: >> >> 1) Please add an description entry to libgcc/ChangeLog.google-4_6 > > > Done. > > > >> 2) Your gcc/ChangeLog.google-4_6 change reverts someone else's change. > > Please >> >> update it and also update the time of your entry. > > > Done. > > > >> 3) Please list in the Description field what tests you have done. > > > Done. > > >> Thanks, >> Jing > > >> On 2012/05/01 22:40:12, asharif wrote: >> > +carrot@ > > > > > http://codereview.appspot.com/6148044/
Re: Backported r187026 from branches/google/gcc-4_6 (issue 6148044)
On 2012/05/01 22:51:22, jingyu wrote: 1) Please add an description entry to libgcc/ChangeLog.google-4_6 Done. 2) Your gcc/ChangeLog.google-4_6 change reverts someone else's change. Please update it and also update the time of your entry. Done. 3) Please list in the Description field what tests you have done. Done. Thanks, Jing On 2012/05/01 22:40:12, asharif wrote: > +carrot@ http://codereview.appspot.com/6148044/