Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-23 Thread Tom Tromey
Steven Probably you mean the revised patch here:
Steven http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html

Steven The patch look OK to me but I can't approve it.

I'm sorry about the delay on this.

The libcpp bits are ok.
I can't approve the other parts.

I think new configure options should be documented in install.texi.

Tom


Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-23 Thread Ian Lance Taylor
On Tue, Oct 23, 2012 at 12:38 PM, Tom Tromey tro...@redhat.com wrote:
 Steven Probably you mean the revised patch here:
 Steven http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html

 Steven The patch look OK to me but I can't approve it.

 I'm sorry about the delay on this.

 The libcpp bits are ok.
 I can't approve the other parts.

The rest of the patch is fine.

 I think new configure options should be documented in install.texi.

Looks to me like it is.

Thanks.

Ian


Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-16 Thread Simon Baldwin
Ping, again

http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html

--
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902


Re: Fourth ping: Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-10-16 Thread Steven Bosscher
On Tue, Oct 16, 2012 at 10:50 AM, Simon Baldwin wrote:
 Ping, again

 http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html

Probably you mean the revised patch here:

http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00459.html

The patch look OK to me but I can't approve it.
Technically you're fixing a regression. It'd be helpful if you can
file a PR about it and add the PR number to the ChangeLog entry. That
helps for traceability, and might, eh, motivate release managers to
review your patch :-)

Ciao!
Steven