Re: GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition

2024-01-31 Thread Andrew Stubbs 

On 31/01/2024 17:12, Thomas Schwinge wrote:

Hi!

On 2018-12-12T11:52:52+, Andrew Stubbs  wrote:

This patch contains the major part of the GCN back-end.  [...]



--- /dev/null
+++ b/gcc/config/gcn/gcn.h



+#define FIRST_SGPR_REG 0
+#define SGPR_REGNO(N)  ((N)+FIRST_SGPR_REG)
+#define LAST_SGPR_REG  101



+#define FIRST_VGPR_REG 160
+#define VGPR_REGNO(N)  ((N)+FIRST_VGPR_REG)
+#define LAST_VGPR_REG  415



+#define SGPR_OR_VGPR_REGNO_P(N) ((N)>=FIRST_VGPR_REG && (N) <= LAST_SGPR_REG)


OK to push the attached "GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition"?


Seems like it qualifies as "obvious". :)

Andrew

GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition (was: [PATCH v3 05/10] GCN back-end code)

2024-01-31 Thread Thomas Schwinge 
Hi!

On 2018-12-12T11:52:52+, Andrew Stubbs  wrote:
> This patch contains the major part of the GCN back-end.  [...]

> --- /dev/null
> +++ b/gcc/config/gcn/gcn.h

> +#define FIRST_SGPR_REG   0
> +#define SGPR_REGNO(N)((N)+FIRST_SGPR_REG)
> +#define LAST_SGPR_REG101

> +#define FIRST_VGPR_REG   160
> +#define VGPR_REGNO(N)((N)+FIRST_VGPR_REG)
> +#define LAST_VGPR_REG415

> +#define SGPR_OR_VGPR_REGNO_P(N) ((N)>=FIRST_VGPR_REG && (N) <= LAST_SGPR_REG)

OK to push the attached "GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition"?


Grüße
 Thomas


>From 849a52b3dcfdd840e6d24a1924962bb01762c1b1 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge 
Date: Wed, 31 Jan 2024 12:25:25 +0100
Subject: [PATCH] GCN: Remove 'SGPR_OR_VGPR_REGNO_P' definition

..., which was always (a) unused, and (b) bogus: always-false.

	gcc/
	* config/gcn/gcn.h (SGPR_OR_VGPR_REGNO_P): Remove.
---
 gcc/config/gcn/gcn.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gcc/config/gcn/gcn.h b/gcc/config/gcn/gcn.h
index c2afb5e91403..efe3c91511e5 100644
--- a/gcc/config/gcn/gcn.h
+++ b/gcc/config/gcn/gcn.h
@@ -180,7 +180,6 @@
 #define HARD_FRAME_POINTER_IS_ARG_POINTER   0
 #define HARD_FRAME_POINTER_IS_FRAME_POINTER 0
 
-#define SGPR_OR_VGPR_REGNO_P(N) ((N)>=FIRST_VGPR_REG && (N) <= LAST_SGPR_REG)
 #define SGPR_REGNO_P(N)		((N) <= LAST_SGPR_REG)
 #define VGPR_REGNO_P(N)		((N)>=FIRST_VGPR_REG && (N) <= LAST_VGPR_REG)
 #define AVGPR_REGNO_P(N)((N)>=FIRST_AVGPR_REG && (N) <= LAST_AVGPR_REG)
-- 
2.43.0