Re: Patch ping (Re: [PATCH] Fix -gdwarf-5 -gsplit-dwarf ICEs (PR debug/89498))

2019-03-13 Thread Jason Merrill 

On 3/12/19 7:51 AM, Jakub Jelinek wrote:

On Mon, Mar 04, 2019 at 11:35:50PM +0100, Jakub Jelinek wrote:

2019-03-04  Jakub Jelinek  

PR debug/89498
* dwarf2out.c (size_of_die): For dw_val_class_view_list always use
DWARF_OFFSET_SIZE.
(value_format): For dw_val_class_view_list never use DW_FORM_loclistx.


Given the clarifications Alex has just posted, I believe this patch does
what is documented in there.  Ok for trunk?


OK.

Jason

Patch ping (Re: [PATCH] Fix -gdwarf-5 -gsplit-dwarf ICEs (PR debug/89498))

2019-03-12 Thread Jakub Jelinek 
On Mon, Mar 04, 2019 at 11:35:50PM +0100, Jakub Jelinek wrote:
> 2019-03-04  Jakub Jelinek  
> 
>   PR debug/89498
>   * dwarf2out.c (size_of_die): For dw_val_class_view_list always use
>   DWARF_OFFSET_SIZE.
>   (value_format): For dw_val_class_view_list never use DW_FORM_loclistx.

Given the clarifications Alex has just posted, I believe this patch does
what is documented in there.  Ok for trunk?

Jakub