Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext
Hi Iain,
Iain Sandoe writes:
> Hi Arsen,
>
>> On 28 Oct 2023, at 10:22, Arsen Arsenović wrote:
>
>> Andrew Pinski writes:
>>
>>> One comment from me. It would be nice to update install.texi in
>>> gcc/doc/ to make a mention of this requirement for non-glibc hosts.
>>
>> What do you think of the following:
>
> The hiccup for me is that we need to mention that libintl is provided by a
> package
> with a different name, that might not be obvious to someone unfamiliar with
> this.
I'll throw in "provided by GNU gettext"
>>
>>
>> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
>> index a17016cd8977..e5137f9d7a1b 100644
>> --- a/gcc/doc/install.texi
>> +++ b/gcc/doc/install.texi
>> @@ -2215,6 +2215,11 @@ which lets GCC output diagnostics in languages other
>> than American
>> English. Native Language Support is enabled by default if not doing a
>> canadian cross build. The @option{--disable-nls} option disables NLS@.
>>
>> +Note that this functionality requires either libintl or C standard
>> +library that contains support for gettext (such as the GNU C Library).
> s/gettext/NLS/
Hmm, I was referring to the library function here, which matches the
table this sentence references (which names a column 'gettext present in
libc').
> +If your installation does not provide either, libibtl can be provided by the
> gettext package
>> +@xref{with-included-gettext,,--with-included-gettext} for more
> “see …"
@xref inserts 'See '
>> +information on the conditions required to get gettext support.
>
> information on the options for providing gettext {as part of the
> build?}
The table is more general. It covers what happens with/without gettext
in-tree, with/without libintl on the system, with/without gettext in
libc and when passing --with/out-included-gettext.
Thanks, have a lovely day.
--
Arsen Arsenović
signature.asc
Description: PGP signature
Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext
Hi Arsen,
> On 28 Oct 2023, at 10:22, Arsen Arsenović wrote:
> Andrew Pinski writes:
>
>> One comment from me. It would be nice to update install.texi in
>> gcc/doc/ to make a mention of this requirement for non-glibc hosts.
>
> What do you think of the following:
The hiccup for me is that we need to mention that libintl is provided by a
package
with a different name, that might not be obvious to someone unfamiliar with
this.
>
>
> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index a17016cd8977..e5137f9d7a1b 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -2215,6 +2215,11 @@ which lets GCC output diagnostics in languages other
> than American
> English. Native Language Support is enabled by default if not doing a
> canadian cross build. The @option{--disable-nls} option disables NLS@.
>
> +Note that this functionality requires either libintl or C standard
> +library that contains support for gettext (such as the GNU C Library).
s/gettext/NLS/
+If your installation does not provide either, libibtl can be provided by the
gettext package
> +@xref{with-included-gettext,,--with-included-gettext} for more
“see …"
> +information on the conditions required to get gettext support.
information on the options for providing gettext {as part of the build?}
Iain
> +
> @item --with-libintl-prefix=@var{dir}
> @itemx --without-libintl-prefix
> Searches for libintl in @file{@var{dir}/include} and
> @@ -2225,6 +2230,7 @@ linker handle it.
> Specifies the type of library to search for when looking for libintl.
> @var{type} can be one of @code{auto}, @code{static} or @code{shared}.
>
> +@anchor{with-included-gettext}
> @item --with-included-gettext
> Only available if @file{gettext} is present in the source tree.
>
> Thanks.
> --
> Arsen Arsenović
Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext
Hi Andrew,
Andrew Pinski writes:
> One comment from me. It would be nice to update install.texi in
> gcc/doc/ to make a mention of this requirement for non-glibc hosts.
What do you think of the following:
diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index a17016cd8977..e5137f9d7a1b 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -2215,6 +2215,11 @@ which lets GCC output diagnostics in languages other
than American
English. Native Language Support is enabled by default if not doing a
canadian cross build. The @option{--disable-nls} option disables NLS@.
+Note that this functionality requires either libintl or C standard
+library that contains support for gettext (such as the GNU C Library).
+@xref{with-included-gettext,,--with-included-gettext} for more
+information on the conditions required to get gettext support.
+
@item --with-libintl-prefix=@var{dir}
@itemx --without-libintl-prefix
Searches for libintl in @file{@var{dir}/include} and
@@ -2225,6 +2230,7 @@ linker handle it.
Specifies the type of library to search for when looking for libintl.
@var{type} can be one of @code{auto}, @code{static} or @code{shared}.
+@anchor{with-included-gettext}
@item --with-included-gettext
Only available if @file{gettext} is present in the source tree.
Thanks.
--
Arsen Arsenović
signature.asc
Description: PGP signature
Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext
On Sun, Oct 15, 2023 at 12:40 PM Arsen Arsenović wrote: > > Evening, > > Arsen Arsenović writes: > > > Afternoon, > > > > This patch is a rebase and rewording of > > https://inbox.sourceware.org/20230925150921.894157-1-ar...@aarsen.me/ > > > > Changes since v1: > > - Implement Brunos suggested changes to install.texi. > > - Elaborate commit message in p2 (as requested by the Binutils > > maintainers). > > > > Arsen Arsenović (2): > > intl: remove, in favor of out-of-tree gettext > > *: add modern gettext > > > > Ping on this patch series. One comment from me. It would be nice to update install.texi in gcc/doc/ to make a mention of this requirement for non-glibc hosts. Thanks, Andrew Pinski > > TIA, have a lovely night :-) > -- > Arsen Arsenović
Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext
Evening, Arsen Arsenović writes: > Afternoon, > > This patch is a rebase and rewording of > https://inbox.sourceware.org/20230925150921.894157-1-ar...@aarsen.me/ > > Changes since v1: > - Implement Brunos suggested changes to install.texi. > - Elaborate commit message in p2 (as requested by the Binutils > maintainers). > > Arsen Arsenović (2): > intl: remove, in favor of out-of-tree gettext > *: add modern gettext > Ping on this patch series. TIA, have a lovely night :-) -- Arsen Arsenović signature.asc Description: PGP signature
