Re: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
On Wed, Mar 20, 2013 at 2:43 AM, Xinyu Qi wrote: >>At 2013-01-22 19:58:43,"Ramana Radhakrishnan" wrote:> >> > On 01/22/13 09:21, Xinyu Qi wrote: >> > > Ping, >> > > >> > > Fix ChangeLog >> > >> > The ChangeLog format includes . >> > >> > >> > >> > If you want a patch accepted in the future, please help by creating >> > the Changelog entry in the correct format, i.e. fill in the author's >> > name as well as email address as below. I've created an entry as >> > below. Please remember to do so for every patch you submit - thanks. >> > >> > Xinyu Qi >> > >> > * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. >> > * config/arm/iwmmxt.md (WCGR0): Update. >> > (WCGR1, WCGR2, WCGR3): Likewise. >> > >> > The patch by itself is OK but surprisingly I never saw this earlier. >> > Your ping has removed the date from the original post so I couldn't >> > track it down. >> > >> > Anyway, please apply. >> > >> > >> > regards, >> > Ramana >> > >> > >> > Hi Ramana, > > Since I have no write access, would you mind to help to check in this patch? > The patch is attached. > > ChangeLog > 2013-01-31 Xinyu Qi > > * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. > * config/arm/iwmmxt.md (WCGR0): Update. > (WCGR1, WCGR2, WCGR3): Likewise. > Now applied to trunk .sorry about the delay. Ramana
RE: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
>At 2013-01-22 19:58:43,"Ramana Radhakrishnan" wrote:> > > On 01/22/13 09:21, Xinyu Qi wrote: > > > Ping, > > > > > > Fix ChangeLog > > > > The ChangeLog format includes . > > > > > > > > If you want a patch accepted in the future, please help by creating > > the Changelog entry in the correct format, i.e. fill in the author's > > name as well as email address as below. I've created an entry as > > below. Please remember to do so for every patch you submit - thanks. > > > > Xinyu Qi > > > > * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. > > * config/arm/iwmmxt.md (WCGR0): Update. > > (WCGR1, WCGR2, WCGR3): Likewise. > > > > The patch by itself is OK but surprisingly I never saw this earlier. > > Your ping has removed the date from the original post so I couldn't > > track it down. > > > > Anyway, please apply. > > > > > > regards, > > Ramana > > > > > Hi Ramana, Since I have no write access, would you mind to help to check in this patch? The patch is attached. ChangeLog 2013-01-31 Xinyu Qi * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Thanks, Xinyu WCGR.DIFF Description: WCGR.DIFF
RE: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
At 2013-01-22 19:58:43,"Ramana Radhakrishnan" wrote:> > On 01/22/13 09:21, Xinyu Qi wrote: > > Ping, > > > > Fix ChangeLog > > The ChangeLog format includes . > > > > If you want a patch accepted in the future, please help by creating the > Changelog entry in the correct format, i.e. fill in the author's name as well > as > email address as below. I've created an entry as below. Please remember to do > so for every patch you submit - thanks. > > Xinyu Qi > > * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. > * config/arm/iwmmxt.md (WCGR0): Update. > (WCGR1, WCGR2, WCGR3): Likewise. > > The patch by itself is OK but surprisingly I never saw this earlier. > Your ping has removed the date from the original post so I couldn't track it > down. > > Anyway, please apply. > > > regards, > Ramana > > Hi Nick, Since I have no write access, would you mind to help to check in this patch which has already been approved? The patch is attached. ChangeLog 2013-01-31 Xinyu Qi * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Thanks, Xinyu WCGR.diff Description: WCGR.diff