Re: [PATCH, mips]: Use ROUND_UP and ROUND_DOWN macros

2015-10-14 Thread Uros Bizjak
On Wed, Oct 14, 2015 at 11:38 PM, Matthew Fortune
 wrote:
> Uros Bizjak  writes:
>> Fairly trivial patch that introduces no functional changes.
>>
>> * config/mips/mips.h (MIPS_STACK_ALIGN): Implement using
>> ROUND_UP macro.
>> * config/mips/mips.c (mips_setup_incoming_varargs): Use
>> ROUND_DOWN to calculate off.
>> (mips_gimplify_va_arg_expr): Use ROUND_UP to calculate rsize.
>> (mips_emit_probe_stack_range): Use ROUND_DOWN to calculate
>> rounded_size.
>>
>> Tested by building a crosscompiler to powerpc64-linux-gnu.
>>
>> OK for mainline?
>
> OK assuming you meant mips64-linux-gnu or some MIPS triple?

Ah, yes. FTR, it was mips-linux-gnu.

Thanks,
Uros.


RE: [PATCH, mips]: Use ROUND_UP and ROUND_DOWN macros

2015-10-14 Thread Matthew Fortune
Uros Bizjak  writes:
> Fairly trivial patch that introduces no functional changes.
> 
> * config/mips/mips.h (MIPS_STACK_ALIGN): Implement using
> ROUND_UP macro.
> * config/mips/mips.c (mips_setup_incoming_varargs): Use
> ROUND_DOWN to calculate off.
> (mips_gimplify_va_arg_expr): Use ROUND_UP to calculate rsize.
> (mips_emit_probe_stack_range): Use ROUND_DOWN to calculate
> rounded_size.
> 
> Tested by building a crosscompiler to powerpc64-linux-gnu.
> 
> OK for mainline?

OK assuming you meant mips64-linux-gnu or some MIPS triple?

Thanks,
Matthew