RE: [PATCH, testsuite] Add loop unrolling command line options for some test cases

2011-09-26 Thread Jiangning Liu
 -Original Message-
 From: Richard Guenther [mailto:richard.guent...@gmail.com]
 Sent: Saturday, September 24, 2011 6:12 PM
 To: Jiangning Liu
 Cc: Mike Stump; gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
 Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
 for some test cases
 
 On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu jiangning@arm.com
 wrote:
  Hi Mike,
 
  OK. I will wait 24 more hours. If no objections by then, I will get
 it
  checked into trunk.
 
 I don't think you need -funroll-loops though.
 

The intention of those test cases are not hurt if -funroll-loops is added,
right?

  Thanks,
  -Jiangning
 
  -Original Message-
  From: Mike Stump [mailto:mikest...@comcast.net]
  Sent: Thursday, September 22, 2011 3:10 AM
  To: Jiangning Liu
  Cc: gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
  Subject: Re: [PATCH, testsuite] Add loop unrolling command line
 options
  for some test cases
 
  On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
   The fix is to explicitly turn on loop unroll and set max-unroll-
 times
  to 8,
   which is larger than the unrolling times being detected in the
 cases.
 
  Sounds reasonable to me.  Ok, though, do watch for any comments by
  people that know more than I.
 
 
 
 
 






Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases

2011-09-26 Thread Richard Guenther
On Mon, Sep 26, 2011 at 9:08 AM, Jiangning Liu jiangning@arm.com wrote:
 -Original Message-
 From: Richard Guenther [mailto:richard.guent...@gmail.com]
 Sent: Saturday, September 24, 2011 6:12 PM
 To: Jiangning Liu
 Cc: Mike Stump; gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
 Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
 for some test cases

 On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu jiangning@arm.com
 wrote:
  Hi Mike,
 
  OK. I will wait 24 more hours. If no objections by then, I will get
 it
  checked into trunk.

 I don't think you need -funroll-loops though.


 The intention of those test cases are not hurt if -funroll-loops is added,
 right?

Right.

  Thanks,
  -Jiangning
 
  -Original Message-
  From: Mike Stump [mailto:mikest...@comcast.net]
  Sent: Thursday, September 22, 2011 3:10 AM
  To: Jiangning Liu
  Cc: gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
  Subject: Re: [PATCH, testsuite] Add loop unrolling command line
 options
  for some test cases
 
  On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
   The fix is to explicitly turn on loop unroll and set max-unroll-
 times
  to 8,
   which is larger than the unrolling times being detected in the
 cases.
 
  Sounds reasonable to me.  Ok, though, do watch for any comments by
  people that know more than I.
 
 
 
 
 







Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases

2011-09-24 Thread Richard Guenther
On Thu, Sep 22, 2011 at 6:22 AM, Jiangning Liu jiangning@arm.com wrote:
 Hi Mike,

 OK. I will wait 24 more hours. If no objections by then, I will get it
 checked into trunk.

I don't think you need -funroll-loops though.

 Thanks,
 -Jiangning

 -Original Message-
 From: Mike Stump [mailto:mikest...@comcast.net]
 Sent: Thursday, September 22, 2011 3:10 AM
 To: Jiangning Liu
 Cc: gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
 Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
 for some test cases

 On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
  The fix is to explicitly turn on loop unroll and set max-unroll-times
 to 8,
  which is larger than the unrolling times being detected in the cases.

 Sounds reasonable to me.  Ok, though, do watch for any comments by
 people that know more than I.







Re: [PATCH, testsuite] Add loop unrolling command line options for some test cases

2011-09-21 Thread Mike Stump
On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
 The fix is to explicitly turn on loop unroll and set max-unroll-times to 8,
 which is larger than the unrolling times being detected in the cases.

Sounds reasonable to me.  Ok, though, do watch for any comments by people that 
know more than I.


RE: [PATCH, testsuite] Add loop unrolling command line options for some test cases

2011-09-21 Thread Jiangning Liu
Hi Mike,

OK. I will wait 24 more hours. If no objections by then, I will get it
checked into trunk.

Thanks,
-Jiangning

 -Original Message-
 From: Mike Stump [mailto:mikest...@comcast.net]
 Sent: Thursday, September 22, 2011 3:10 AM
 To: Jiangning Liu
 Cc: gcc-patches@gcc.gnu.org; r...@cebitec.uni-bielefeld.de
 Subject: Re: [PATCH, testsuite] Add loop unrolling command line options
 for some test cases
 
 On Sep 21, 2011, at 1:22 AM, Jiangning Liu wrote:
  The fix is to explicitly turn on loop unroll and set max-unroll-times
 to 8,
  which is larger than the unrolling times being detected in the cases.
 
 Sounds reasonable to me.  Ok, though, do watch for any comments by
 people that know more than I.