Re: [PATCH][AArch64] Restrict usage of SBFIZ to valid range only

[Richard Earnshaw]

On 16/10/12 17:34, Ian Bolton wrote:

Subject: [PATCH][AArch64] Restrict usage of SBFIZ to valid range only

This fixes an issue where we were generating an SBFIZ with
operand 3 outside of the valid range (as determined by the
size of the destination register and the amount of shift).

My patch checks that the range is valid before allowing
the pattern to be used.

This has now had full regression testing and all is OK.

OK for aarch64-trunk and aarch64-4_7-branch?

Cheers,
Ian


2012-10-15  Ian Bolton  

* gcc/config/aarch64/aarch64.md
(_shft_): Restrict based on op2.


-


diff --git a/gcc/config/aarch64/aarch64.md
b/gcc/config/aarch64/aarch64.md
index e6086a9..3bfe6e6 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -2311,7 +2311,7 @@
 (ashift:GPI (ANY_EXTEND:GPI
  (match_operand:ALLX 1 "register_operand" "r"))
 (match_operand 2 "const_int_operand" "n")))]
-  ""
+  " <= ( - UINTVAL (operands[2]))"
"bfiz\\t%0, %1, %2, #"
[(set_attr "v8type" "bfm")
 (set_attr "mode" "")]





New and improved version is at the end of this email.

This has had full regression testing and all is OK.

OK for aarch64-trunk and aarch64-4_7-branch?

Cheers,
Ian



2012-10-16  Ian Bolton  

   * gcc/config/aarch64/aarch64.md
   (_shft_): Restrict operands.



OK both.

R.





diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
index e6086a9..e77496f 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -2311,8 +2311,13 @@
 (ashift:GPI (ANY_EXTEND:GPI
  (match_operand:ALLX 1 "register_operand" "r"))
 (match_operand 2 "const_int_operand" "n")))]
-  ""
-  "bfiz\\t%0, %1, %2, #"
+  "UINTVAL (operands[2]) < "
+{
+  operands[3] = ( <= ( - UINTVAL (operands[2])))
+ ? GEN_INT ()
+ : GEN_INT ( - UINTVAL (operands[2]));
+  return "bfiz\t%0, %1, %2, %3";
+}
[(set_attr "v8type" "bfm")
 (set_attr "mode" "")]
  )

RE: [PATCH][AArch64] Restrict usage of SBFIZ to valid range only

[Ian Bolton]

> Subject: [PATCH][AArch64] Restrict usage of SBFIZ to valid range only
> 
> This fixes an issue where we were generating an SBFIZ with
> operand 3 outside of the valid range (as determined by the
> size of the destination register and the amount of shift).
> 
> My patch checks that the range is valid before allowing
> the pattern to be used.
> 
> This has now had full regression testing and all is OK.
> 
> OK for aarch64-trunk and aarch64-4_7-branch?
> 
> Cheers,
> Ian
> 
> 
> 2012-10-15  Ian Bolton  
> 
>   * gcc/config/aarch64/aarch64.md
>   (_shft_): Restrict based on op2.
> 
> 
> -
> 
> 
> diff --git a/gcc/config/aarch64/aarch64.md
> b/gcc/config/aarch64/aarch64.md
> index e6086a9..3bfe6e6 100644
> --- a/gcc/config/aarch64/aarch64.md
> +++ b/gcc/config/aarch64/aarch64.md
> @@ -2311,7 +2311,7 @@
> (ashift:GPI (ANY_EXTEND:GPI
>  (match_operand:ALLX 1 "register_operand" "r"))
> (match_operand 2 "const_int_operand" "n")))]
> -  ""
> +  " <= ( - UINTVAL (operands[2]))"
>"bfiz\\t%0, %1, %2, #"
>[(set_attr "v8type" "bfm")
> (set_attr "mode" "")]
> 
> 
> 

New and improved version is at the end of this email.

This has had full regression testing and all is OK.

OK for aarch64-trunk and aarch64-4_7-branch?

Cheers,
Ian



2012-10-16  Ian Bolton  

  * gcc/config/aarch64/aarch64.md
  (_shft_): Restrict operands.




diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
index e6086a9..e77496f 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -2311,8 +2311,13 @@
(ashift:GPI (ANY_EXTEND:GPI
 (match_operand:ALLX 1 "register_operand" "r"))
(match_operand 2 "const_int_operand" "n")))]
-  ""
-  "bfiz\\t%0, %1, %2, #"
+  "UINTVAL (operands[2]) < "
+{
+  operands[3] = ( <= ( - UINTVAL (operands[2])))
+ ? GEN_INT ()
+ : GEN_INT ( - UINTVAL (operands[2]));
+  return "bfiz\t%0, %1, %2, %3";
+}
   [(set_attr "v8type" "bfm")
(set_attr "mode" "")]
 )