RE: [PATCH][i386] Adding CLDEMOTE instruction

[Peryt, Sebastian]

> -Original Message-
> From: Uros Bizjak [mailto:ubiz...@gmail.com]
> Sent: Wednesday, May 9, 2018 1:53 PM
> To: Peryt, Sebastian <sebastian.pe...@intel.com>
> Cc: gcc-patches@gcc.gnu.org; Kirill Yukhin <kirill.yuk...@gmail.com>
> Subject: Re: [PATCH][i386] Adding CLDEMOTE instruction
> 
> On Tue, May 8, 2018 at 1:58 PM, Peryt, Sebastian <sebastian.pe...@intel.com>
> wrote:
> > Sorry, forgot attachment.
> >
> > Sebastian
> >
> >
> > -Original Message-
> > From: Peryt, Sebastian
> > Sent: Tuesday, May 8, 2018 1:56 PM
> > To: gcc-patches@gcc.gnu.org
> > Cc: Uros Bizjak <ubiz...@gmail.com>; Kirill Yukhin
> > <kirill.yuk...@gmail.com>; Peryt, Sebastian
> > <sebastian.pe...@intel.com>
> > Subject: [PATCH][i386] Adding CLDEMOTE instruction
> >
> > Hi,
> >
> > This patch adds support for CLDEMOTE instruction.
> >
> > Is it ok for trunk and after few day for backport to GCC-8?
> >
> > 2018-05-08  Sebastian Peryt  <sebastian.pe...@intel.com>
> >
> > gcc/
> >
> > * common/config/i386/i386-common.c
> (OPTION_MASK_ISA_CLDEMOTE_SET,
> > OPTION_MASK_ISA_CLDEMOTE_UNSET): New defines.
> > (ix86_handle_option): Handle -mcldemote.
> > * config.gcc: New header.
> > * config/i386/cldemoteintrin.h: New file.
> > * config/i386/cpuid.h (bit_CLDEMOTE): New bit.
> > * config/i386/driver-i386.c (host_detect_local_cpu): Detect
> > -mcldemote.
> > * config/i386/i386-c.c (ix86_target_macros_internal): Handle
> > OPTION_MASK_ISA_CLDEMOTE.
> > * config/i386/i386.c (ix86_target_string): Added -mcldemote.
> > (ix86_valid_target_attribute_inner_p): Ditto.
> > (enum ix86_builtins): Added IX86_BUILTIN_CLDEMOTE.
> > (ix86_init_mmx_sse_builtins): Define __builtin_ia32_cldemote.
> > (ix86_expand_builtin): Expand IX86_BUILTIN_CLDEMOTE.
> > * config/i386/i386.h (TARGET_CLDEMOTE, TARGET_CLDEMOTE_P): New.
> > * config/i386/i386.md (UNSPECV_CLDEMOTE): New.
> > (cldemote): New.
> > * config/i386/i386.opt: Added -mcldemote.
> > * config/i386/x86intrin.h: New header.
> > * doc/invoke.texi: Added -mcldemote.
> >
> > 2018-05-08  Sebastian Peryt  <sebastian.pe...@intel.com>
> >
> > gcc/testsuite/
> >
> > * gcc.target/i386/cldemote-1.c: New test.
> 
> OK for mainline.
> 
> is there a compelling reason why we want this new feature in gcc-8 release
> branch?
>

After some additional internal discussion I figured for now it's not required 
to backport it.
I'll backport it if/when it'll be required in the future.
 
> Thanks,
> Uros.

Thanks,
Sebastian

Re: [PATCH][i386] Adding CLDEMOTE instruction

[Uros Bizjak]

On Tue, May 8, 2018 at 1:58 PM, Peryt, Sebastian
 wrote:
> Sorry, forgot attachment.
>
> Sebastian
>
>
> -Original Message-
> From: Peryt, Sebastian
> Sent: Tuesday, May 8, 2018 1:56 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Uros Bizjak ; Kirill Yukhin ; 
> Peryt, Sebastian 
> Subject: [PATCH][i386] Adding CLDEMOTE instruction
>
> Hi,
>
> This patch adds support for CLDEMOTE instruction.
>
> Is it ok for trunk and after few day for backport to GCC-8?
>
> 2018-05-08  Sebastian Peryt  
>
> gcc/
>
> * common/config/i386/i386-common.c (OPTION_MASK_ISA_CLDEMOTE_SET,
> OPTION_MASK_ISA_CLDEMOTE_UNSET): New defines.
> (ix86_handle_option): Handle -mcldemote.
> * config.gcc: New header.
> * config/i386/cldemoteintrin.h: New file.
> * config/i386/cpuid.h (bit_CLDEMOTE): New bit.
> * config/i386/driver-i386.c (host_detect_local_cpu): Detect
> -mcldemote.
> * config/i386/i386-c.c (ix86_target_macros_internal): Handle
> OPTION_MASK_ISA_CLDEMOTE.
> * config/i386/i386.c (ix86_target_string): Added -mcldemote.
> (ix86_valid_target_attribute_inner_p): Ditto.
> (enum ix86_builtins): Added IX86_BUILTIN_CLDEMOTE.
> (ix86_init_mmx_sse_builtins): Define __builtin_ia32_cldemote.
> (ix86_expand_builtin): Expand IX86_BUILTIN_CLDEMOTE.
> * config/i386/i386.h (TARGET_CLDEMOTE, TARGET_CLDEMOTE_P): New.
> * config/i386/i386.md (UNSPECV_CLDEMOTE): New.
> (cldemote): New.
> * config/i386/i386.opt: Added -mcldemote.
> * config/i386/x86intrin.h: New header.
> * doc/invoke.texi: Added -mcldemote.
>
> 2018-05-08  Sebastian Peryt  
>
> gcc/testsuite/
>
> * gcc.target/i386/cldemote-1.c: New test.

OK for mainline.

is there a compelling reason why we want this new feature in gcc-8
release branch?

Thanks,
Uros.

RE: [PATCH][i386] Adding CLDEMOTE instruction

[Peryt, Sebastian]

Sorry, forgot attachment.

Sebastian


-Original Message-
From: Peryt, Sebastian 
Sent: Tuesday, May 8, 2018 1:56 PM
To: gcc-patches@gcc.gnu.org
Cc: Uros Bizjak ; Kirill Yukhin ; 
Peryt, Sebastian 
Subject: [PATCH][i386] Adding CLDEMOTE instruction

Hi,

This patch adds support for CLDEMOTE instruction.

Is it ok for trunk and after few day for backport to GCC-8?

2018-05-08  Sebastian Peryt  

gcc/

* common/config/i386/i386-common.c (OPTION_MASK_ISA_CLDEMOTE_SET,
OPTION_MASK_ISA_CLDEMOTE_UNSET): New defines.
(ix86_handle_option): Handle -mcldemote.
* config.gcc: New header.
* config/i386/cldemoteintrin.h: New file.
* config/i386/cpuid.h (bit_CLDEMOTE): New bit.
* config/i386/driver-i386.c (host_detect_local_cpu): Detect
-mcldemote.
* config/i386/i386-c.c (ix86_target_macros_internal): Handle
OPTION_MASK_ISA_CLDEMOTE.
* config/i386/i386.c (ix86_target_string): Added -mcldemote.
(ix86_valid_target_attribute_inner_p): Ditto.
(enum ix86_builtins): Added IX86_BUILTIN_CLDEMOTE.
(ix86_init_mmx_sse_builtins): Define __builtin_ia32_cldemote.
(ix86_expand_builtin): Expand IX86_BUILTIN_CLDEMOTE.
* config/i386/i386.h (TARGET_CLDEMOTE, TARGET_CLDEMOTE_P): New.
* config/i386/i386.md (UNSPECV_CLDEMOTE): New.
(cldemote): New.
* config/i386/i386.opt: Added -mcldemote.
* config/i386/x86intrin.h: New header.
* doc/invoke.texi: Added -mcldemote.

2018-05-08  Sebastian Peryt  

gcc/testsuite/

* gcc.target/i386/cldemote-1.c: New test.

Thanks,
Sebastian


0002-CLDEMOTE.PATCH
Description: 0002-CLDEMOTE.PATCH