RE: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-05 Thread Kyrylo Tkachov via Gcc-patches 
Hi Prathamesh,

> -Original Message-
> From: Prathamesh Kulkarni 
> Sent: 05 January 2021 11:42
> To: Kyrylo Tkachov 
> Cc: gcc Patches 
> Subject: Re: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle
> in vext intrinsics
> 
> On Mon, 4 Jan 2021 at 16:01, Kyrylo Tkachov 
> wrote:
> >
> > Hi Prathamesh
> >
> > > -Original Message-
> > > From: Prathamesh Kulkarni 
> > > Sent: 04 January 2021 10:27
> > > To: gcc Patches ; Kyrylo Tkachov
> > > 
> > > Subject: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle
> in
> > > vext intrinsics
> > >
> > > Hi Kyrill,
> > > The attached patch replaces __builtin_vextv8qi with __builtin_shuffle
> > > for vext_s8.
> > > Just wanted to confirm if this is in the correct direction ?
> > > If yes, I will send a follow up patch that converts for all vext 
> > > intrinsics.
> >
> > Yeah, that does look correct (aarch64 does it that way).
> > As before, please make sure to delete any now-unused builtins as well.
> Thanks, does the attached patch look OK ?

Ok if testing and bootstrap shows no problems.
Thanks,
Kyrill

> Testing in progress.
> 
> Thanks,
> Prathamesh
> >
> > Thanks,
> > Kyrill
> >
> > >
> > > Thanks,
> > > Prathamesh

Re: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-05 Thread Prathamesh Kulkarni via Gcc-patches 
On Mon, 4 Jan 2021 at 16:01, Kyrylo Tkachov  wrote:
>
> Hi Prathamesh
>
> > -Original Message-
> > From: Prathamesh Kulkarni 
> > Sent: 04 January 2021 10:27
> > To: gcc Patches ; Kyrylo Tkachov
> > 
> > Subject: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in
> > vext intrinsics
> >
> > Hi Kyrill,
> > The attached patch replaces __builtin_vextv8qi with __builtin_shuffle
> > for vext_s8.
> > Just wanted to confirm if this is in the correct direction ?
> > If yes, I will send a follow up patch that converts for all vext intrinsics.
>
> Yeah, that does look correct (aarch64 does it that way).
> As before, please make sure to delete any now-unused builtins as well.
Thanks, does the attached patch look OK ?
Testing in progress.

Thanks,
Prathamesh
>
> Thanks,
> Kyrill
>
> >
> > Thanks,
> > Prathamesh


vext-2.diff
Description: Binary data

RE: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in vext intrinsics

2021-01-04 Thread Kyrylo Tkachov via Gcc-patches 
Hi Prathamesh

> -Original Message-
> From: Prathamesh Kulkarni 
> Sent: 04 January 2021 10:27
> To: gcc Patches ; Kyrylo Tkachov
> 
> Subject: [PR66791][ARM] Replace __builtin_vext* with __buitlin_shuffle in
> vext intrinsics
> 
> Hi Kyrill,
> The attached patch replaces __builtin_vextv8qi with __builtin_shuffle
> for vext_s8.
> Just wanted to confirm if this is in the correct direction ?
> If yes, I will send a follow up patch that converts for all vext intrinsics.

Yeah, that does look correct (aarch64 does it that way).
As before, please make sure to delete any now-unused builtins as well.

Thanks,
Kyrill

> 
> Thanks,
> Prathamesh