Re: Re: [PATCH v1] RISC-V: Introduce gcc option mrvv-vector-bits for RVV

2024-02-23 Thread juzhe.zh...@rivai.ai
I personally think it's better to has VLS compile option and attribute in 
GCC-14.
Since there are many people porting different libraury 
(eigen/highway/xnnpack/openBLAS,...) with VLS feature,
they test them with Clang.

If we don't support it, we will end up with Clang can compile those lib but 
GCC-14 can't which will make RISC-V
folks think GCC is still pretty far behind than Clang.

Besides, VLS compile option and attribute are pretty safe codes, I would 
surprise that it will cause issues on current RVV support.

So, +1 from my side to support VLS compile option and attribute on GCC-14.

But I'd like to CC more RISC-V GCC folks to see the votes. 
If most of the people don't want this in GCC-14 and defer it to GCC-15, I won't 
insist on it.

Thanks.



juzhe.zh...@rivai.ai
 
From: Jeff Law
Date: 2024-02-23 16:29
To: Kito Cheng; pan2.li
CC: gcc-patches; juzhe.zhong; yanzhang.wang
Subject: Re: [PATCH v1] RISC-V: Introduce gcc option mrvv-vector-bits for RVV
 
 
On 2/23/24 01:22, Kito Cheng wrote:
> I would prefer to only keep zvl and scalable or zvl only, since I
> don't see too much value in specifying a value which different from
> zvl*b, that's a legacy option used before zvl*b option was introduced,
> and the reason to add that is that could used for compatible with
> clang/LLVM for riscv_rvv_vector_bits attribute I think?
And if we want this (I'm not sure), it really feels like it ought to 
defer to gcc-15.
 
jeff
 
 


RE: Re: [PATCH v1] RISC-V: Introduce gcc option mrvv-vector-bits for RVV

2024-02-23 Thread Li, Pan2
> I would prefer to only keep zvl and scalable or zvl only, since I

> don't see too much value in specifying a value which different from

> zvl*b, that's a legacy option used before zvl*b option was introduced,

> and the reason to add that is that could used for compatible with

> clang/LLVM for riscv_rvv_vector_bits attribute I think?



Yes, exactly to be compatible with clang/llvm. Just take zvl is good enough 
IMO, and update in v2 once we have alignment.



> And if we want this (I'm not sure), it really feels like it ought to defer to 
> gcc-15.

> But I'd like to CC more RISC-V GCC folks to see the votes.

> If most of the people don't want this in GCC-14 and defer it to GCC-15, I 
> won't insist on it.



Sure, let’s wait for a while.



Pan

From: juzhe.zh...@rivai.ai 
Sent: Friday, February 23, 2024 4:38 PM
To: jeffreyalaw ; kito.cheng ; Li, 
Pan2 
Cc: gcc-patches ; Wang, Yanzhang 
; Robin Dapp ; palmer 
; vineetg ; Patrick O'Neill 
; Edwin Lu 
Subject: Re: Re: [PATCH v1] RISC-V: Introduce gcc option mrvv-vector-bits for 
RVV

I personally think it's better to has VLS compile option and attribute in 
GCC-14.
Since there are many people porting different libraury 
(eigen/highway/xnnpack/openBLAS,...) with VLS feature,
they test them with Clang.

If we don't support it, we will end up with Clang can compile those lib but 
GCC-14 can't which will make RISC-V
folks think GCC is still pretty far behind than Clang.

Besides, VLS compile option and attribute are pretty safe codes, I would 
surprise that it will cause issues on current RVV support.

So, +1 from my side to support VLS compile option and attribute on GCC-14.

But I'd like to CC more RISC-V GCC folks to see the votes.
If most of the people don't want this in GCC-14 and defer it to GCC-15, I won't 
insist on it.

Thanks.


juzhe.zh...@rivai.ai<mailto:juzhe.zh...@rivai.ai>

From: Jeff Law<mailto:jeffreya...@gmail.com>
Date: 2024-02-23 16:29
To: Kito Cheng<mailto:kito.ch...@gmail.com>; pan2.li<mailto:pan2...@intel.com>
CC: gcc-patches<mailto:gcc-patches@gcc.gnu.org>; 
juzhe.zhong<mailto:juzhe.zh...@rivai.ai>; 
yanzhang.wang<mailto:yanzhang.w...@intel.com>
Subject: Re: [PATCH v1] RISC-V: Introduce gcc option mrvv-vector-bits for RVV


On 2/23/24 01:22, Kito Cheng wrote:
> I would prefer to only keep zvl and scalable or zvl only, since I
> don't see too much value in specifying a value which different from
> zvl*b, that's a legacy option used before zvl*b option was introduced,
> and the reason to add that is that could used for compatible with
> clang/LLVM for riscv_rvv_vector_bits attribute I think?
And if we want this (I'm not sure), it really feels like it ought to
defer to gcc-15.

jeff