Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
../../gcc/tree-vect-generic.c: In member function 'virtual unsigned int
{anonymous}::pass_lower_vector_ssa::execute(function*)':
../../gcc/tree-vect-generic.c:127:70: error: 'a2' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
return gimplify_build3 (gsi, BIT_FIELD_REF, type, t, bitsize, bitpos);
^
../../gcc/tree-vect-generic.c:847:8: note: 'a2' was declared here
tree a2;
^
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
2015-10-13 18:35 GMT+03:00 Jeff Law : > On 10/13/2015 08:56 AM, Ilya Enkovich wrote: >> >> 2015-10-12 13:37 GMT+03:00 Alan Lawrence : >>> >>> On 09/10/15 22:01, Jeff Law wrote: >>> So my question for the series as a whole is whether or not we need to do something for the other languages, particularly Fortran. I was a bit surprised to see this stuff bleed into the C/C++ front-ends and obviously wonder if it's bled into Fortran, Ada, Java, etc. >>> >>> >>> >>> Isn't that just because, we have GNU extensions to C/C++, for vectors? I >>> admit I don't know enough Ada/Fortran to know whether we've added GNU >>> extensions to those languages as well... >>> >>> A. >> >> >> I also got an impression only GNU vector extensions should be >> affected. And those are for C/C++ only. > > I'd be surprised if Fortran doesn't have vector capabilities. I think some > sanity checking in there would be wise. Vector type in language doesn't mean SIMD. AFAIK OpenMP is used in Fortran for SIMD features. Also I would get a lot of Fortran regressions in case such feature exists due to fixed IL checker. Thanks, Ilya > > jeff
Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
On 10/13/2015 08:56 AM, Ilya Enkovich wrote: 2015-10-12 13:37 GMT+03:00 Alan Lawrence : On 09/10/15 22:01, Jeff Law wrote: So my question for the series as a whole is whether or not we need to do something for the other languages, particularly Fortran. I was a bit surprised to see this stuff bleed into the C/C++ front-ends and obviously wonder if it's bled into Fortran, Ada, Java, etc. Isn't that just because, we have GNU extensions to C/C++, for vectors? I admit I don't know enough Ada/Fortran to know whether we've added GNU extensions to those languages as well... A. I also got an impression only GNU vector extensions should be affected. And those are for C/C++ only. I'd be surprised if Fortran doesn't have vector capabilities. I think some sanity checking in there would be wise. jeff
Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
2015-10-12 13:37 GMT+03:00 Alan Lawrence : > On 09/10/15 22:01, Jeff Law wrote: > >> So my question for the series as a whole is whether or not we need to do >> something for the other languages, particularly Fortran. I was a bit >> surprised to see this stuff bleed into the C/C++ front-ends and >> obviously wonder if it's bled into Fortran, Ada, Java, etc. > > > Isn't that just because, we have GNU extensions to C/C++, for vectors? I > admit I don't know enough Ada/Fortran to know whether we've added GNU > extensions to those languages as well... > > A. I also got an impression only GNU vector extensions should be affected. And those are for C/C++ only. Thanks, Ilya
Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
On 09/10/15 22:01, Jeff Law wrote: So my question for the series as a whole is whether or not we need to do something for the other languages, particularly Fortran. I was a bit surprised to see this stuff bleed into the C/C++ front-ends and obviously wonder if it's bled into Fortran, Ada, Java, etc. Isn't that just because, we have GNU extensions to C/C++, for vectors? I admit I don't know enough Ada/Fortran to know whether we've added GNU extensions to those languages as well... A.
Re: [[Boolean Vector, patch 5/5] Support boolean vectors in vector lowering
On 10/02/2015 08:11 AM, Ilya Enkovich wrote: Hi, This patch supports boolean vectors in vector lowering. Main change is to lower vector comparison into comparisons, not cond_exprs. Thanks, Ilya -- 2015-10-02 Ilya Enkovich * tree-vect-generic.c (elem_op_func): Add new operand to hold vector type. (do_unop): Adjust to modified function type. (do_binop): Likewise. (do_plus_minus): Likewise. (do_negate); Likewise. (expand_vector_piecewise): Likewise. (do_cond): Likewise. (do_compare): Use comparison instead of condition. (expand_vector_divmod): Use boolean vector type for comparison. (expand_vector_operations_1): Skip scalar mask operations. This is fine too. So my question for the series as a whole is whether or not we need to do something for the other languages, particularly Fortran. I was a bit surprised to see this stuff bleed into the C/C++ front-ends and obviously wonder if it's bled into Fortran, Ada, Java, etc. jeff
