Re: [C++ Patch] Locations related grokdeclarator tweak

2019-01-21 Thread Paolo Carlini

Hi,

On 21/01/19 18:22, Jason Merrill wrote:

On 1/18/19 6:13 AM, Paolo Carlini wrote:
a tweak to typespec_loc, where the existing conditional turns out to 
be just a special case of the full min_location that we want in order 
to do the right thing for testcases like diagnostic/trailing1.C. 
Tested x86_64-linux.


This is OK, but I don't think we want to keep messing with diagnostic 
locations now that we're in stage 4.  This isn't a regression fix, is it?


I agree, isn't a regression fix and probably we don't want to (further 
;) mess with locations in stage 4. In any case, I'm essentially done 
with most of the low hanging fruits, I continued for a while with what I 
had ready... Anyway, that said, what do you think, shall I schedule this 
one for next Stage 1?


Thanks! Paolo.



Re: [C++ Patch] Locations related grokdeclarator tweak

2019-01-21 Thread Jason Merrill

On 1/18/19 6:13 AM, Paolo Carlini wrote:
a tweak to typespec_loc, where the existing conditional turns out to be 
just a special case of the full min_location that we want in order to do 
the right thing for testcases like diagnostic/trailing1.C. Tested 
x86_64-linux.


This is OK, but I don't think we want to keep messing with diagnostic 
locations now that we're in stage 4.  This isn't a regression fix, is it?


Jason